Skip to content

Also set the subject when the subject is not too long #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2019
Merged

Also set the subject when the subject is not too long #414

merged 1 commit into from
Aug 22, 2019

Conversation

@nickvergessen
Copy link
Member

Fix #413

@nickvergessen
Also set the subject when the subject is not too long
aab3988 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 17 milestone Aug 22, 2019
Ivansss
Ivansss approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nickvergessen
Copy link
Member Author

/backport to stable16

@nickvergessen nickvergessen merged commit dcf452b into master Aug 22, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 22, 2019
Closed
@backportbot-nextcloud
Copy link

backport to stable16 in #415

@delete-merged-branch delete-merged-branch bot deleted the bugfix/413/empty-subject-data branch August 22, 2019 10:08
@rullzer rullzer mentioned this pull request Aug 23, 2019
Merged
@nickvergessen nickvergessen mentioned this pull request Sep 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivansss Ivansss Ivansss approved these changes

@mario mario Awaiting requested review from mario

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to review bug feature: push 📲 regression

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Empty $data['subject'] [bug]

3 participants

@nickvergessen @Ivansss