Empty $data['subject'] [bug]

[CezaryGoralski]

Hello you have bug in triming notifications subjects at notifications/Push.php

notifications/lib/Push.php

Line 268 in 73bdc21

if (strlen($subject) > $dataLength) {

if (strlen($subject) > $dataLength) { $data['subject'] = substr($subject, 0, $dataLength) . '…'; }

and it should be
if (strlen($subject) > $dataLength) { $data['subject'] = substr($subject, 0, $dataLength) . '…'; }else{ $data['subject'] = $notification->getParsedSubject(); }
because otherwise when the parsedSubject length will be less than 255 the $data['subject'] field is gona be empty

[nickvergessen]

Arg, of course... that Is why I got the empty notifications.

Thanks for the pointers