Fix hide download and printing #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/hide-download-print
branch
from
2ae6fbe to
015b467
Compare
skjnldsv
commented
Aug 11, 2021
| // The download has to be forced to use the URL of the file; by default | ||
| // "PDFViewerApplication.download" uses a blob, but this causes a CSP error | ||
| // (at least, in Firefox) when trying to download it. | ||
| PDFViewerApplication.download = function() { |
There was a problem hiding this comment.
Download was already disabled within the app (we have the big button on top)
There was a problem hiding this comment.
files_pdfviewer/templates/viewer.php
Line 144 in bbf6b54
kesselb
approved these changes
Aug 11, 2021
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #311