Repository navigation
Add words to README to draw attention to the use of upgrades.exclude, potential for files to be removed during installation/upgrades. - #1862
Merged
Conversation
… potential for files to be removed during installation/upgrades.
Contributor
|
I think this needs a rebase to fix the CI |
Contributor
Author
Done. |
This was referenced Apr 4, 2023
Closed
This was referenced Oct 21, 2023
ananace
pushed a commit
to ananace/docker-nextcloud
that referenced
this pull request
May 10, 2024
… potential for files to be removed during installation/upgrades. (nextcloud#1862)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During installation and upgrades files under the main folder may be removed if not listed in upgrade.exclude. Adding a note to the README, in the section discussing the use of persistent volumes, would help make this behaviour clearer and reduce the risk of accidental data loss.
Examples of situations where this change may provide benefit include:
This PR addresses essentially the same issue as PR #1168 (and potentially replaces it). I've opened a new PR as I've proposed a rephrased explanation that I think is clearer about the options, and because the previous PR is outdated.