Skip to content

Add note about not placing files inside /var/www/html - #1168

Closed
myzhang1029 wants to merge 1 commit into
nextcloud:masterfrom
myzhang1029:patch-1
Closed

myzhang1029 wants to merge 1 commit into
nextcloud:masterfrom
myzhang1029:patch-1

Conversation

@myzhang1029

Copy link
Copy Markdown

Existing files inside /var/www/html get deleted by the upgrade script. This update documents that. (#1165)

Existing files inside /var/www/html get deleted by the upgrade script. This update documents that. (#1165)

Signed-off-by: Zhang Maiyun <myzhang1029@hotmail.com>
Comment thread README.md
nextcloud
```

Please note that anything inside `/var/www/html` will be removed by the installation script, except for `config`, `data`, `custom_apps`, `themes` and `version.php`. So make sure you do not leave other important files inside.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just refer to upgrade.exclude?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree. That would probably be better.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please note that anything inside `/var/www/html` will be removed by the installation script, except for `config`, `data`, `custom_apps`, `themes` and `version.php`. So make sure you do not leave other important files inside.
Please note that anything inside `/var/www/html` will be removed by the installation script, except for those listed in [upgrade.exclude](https://github.com/nextcloud/docker/blob/master/upgrade.exclude). So make sure you do not leave other important files inside.

Comment thread README.md
@bsiddans

Copy link
Copy Markdown
Contributor

I'd love to help get this one over the line - in addition to the issue mentioned above there's also #1528. This looks like a straight-forward solution compared to #1548.

With regard to the proposed addition, would a slight tweak to the wording help make clear that this issue is relevant for both installation, and upgrades? E.g.:

Users should note that data inside the main folder (/var/www/html) may be removed during installation and upgrades. Users should consider:

  • Mounting storage volumes to locations outside of /var/www/html; and/or
  • Listing files and folders that should not be removed from the main folder in upgrade.exclude.

I'm not sure what the status of this PR is but I'm happy to submit a new one if required.

@J0WI

J0WI commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

I think you need to start from scratch with this PR. It's too outdated.

@J0WI

J0WI commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Fixed in #1862

@J0WI J0WI closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants