Skip to content

fix: Instantiation of ContactsManager #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix: Instantiation of ContactsManager #4394

merged 1 commit into from
Mar 19, 2025
+20 −14

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Mar 19, 2025 •
edited
Loading

Introduced by nextcloud/server#51380

@artonge artonge self-assigned this Mar 19, 2025
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews php Pull requests that update Php code labels Mar 19, 2025
@artonge artonge force-pushed the artonge/fix/constructor_call branch from 12f6918 to 85f6cc1 Compare March 19, 2025 10:15
@artonge artonge requested a review from GVodyanov as a code owner March 19, 2025 10:15
@artonge
fix: Instantiation of ContactsManager
800f4bd 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/constructor_call branch from 85f6cc1 to 800f4bd Compare March 19, 2025 10:18
@codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.54%. Comparing base (fbce2f3) to head (800f4bd).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
lib/Service/SocialApiService.php 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              main    #4394       +/-   ##
============================================
+ Coverage     2.32%   65.54%   +63.21%     
- Complexity       0      265      +265     
============================================
  Files           96       26       -70     
  Lines         4767      772     -3995     
  Branches      1188        0     -1188     
============================================
+ Hits           111      506      +395     
+ Misses        4535      266     -4269     
+ Partials       121        0      -121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge merged commit 9493cea into main Mar 19, 2025
40 checks passed
@artonge artonge deleted the artonge/fix/constructor_call branch March 19, 2025 10:21
@artonge
Copy link
Contributor Author

artonge commented Mar 19, 2025

/backport to stable6.0

@artonge
Copy link
Contributor Author

artonge commented Mar 19, 2025

/backport to stable6.1

@backportbot backportbot bot mentioned this pull request Mar 19, 2025
Closed
2 tasks
@artonge
Copy link
Contributor Author

artonge commented Mar 19, 2025

/backport to stable7.0

This was referenced Mar 19, 2025
Merged
Closed
@hamza221 hamza221 added the regression Regression of a previous working feature label Apr 4, 2025
@ChristophWurst ChristophWurst mentioned this pull request Apr 4, 2025
Merged
@hamza221 hamza221 mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamza221 hamza221 hamza221 approved these changes

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug Something isn't working php Pull requests that update Php code regression Regression of a previous working feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @hamza221