Skip to content

fix(cardav): only show users from enabled addressBooks in contacts menu #51380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(cardav): only show users from enabled addressBooks in contacts menu #51380

merged 1 commit into from
Mar 17, 2025

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Mar 10, 2025 •
edited
Loading

  • Resolves: #

Summary

Only show contacts from Enabled address Books in contact menu

TODO

  • Fix tests

Checklist

@hamza221 hamza221 added bug 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Mar 10, 2025
@hamza221 hamza221 self-assigned this Mar 10, 2025
@hamza221 hamza221 requested review from a team and SebastianKrupinski as code owners March 10, 2025 19:40
@hamza221 hamza221 requested review from come-nc, nfebe and provokateurin and removed request for a team March 10, 2025 19:40
@hamza221 hamza221 changed the title fix(cardav): only show useres from enabled addressBooks in contacts menu fix(cardav): only show users from enabled addressBooks in contacts menu Mar 10, 2025
come-nc
come-nc previously requested changes Mar 11, 2025
View reviewed changes
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Mar 11, 2025
ChristophWurst
ChristophWurst approved these changes Mar 11, 2025
View reviewed changes
@SebastianKrupinski
Copy link
Contributor

Tested. Works!

@hamza221 hamza221 requested a review from come-nc March 13, 2025 12:13
@hamza221
Copy link
Contributor Author

/backport to stable31

ChristophWurst
ChristophWurst reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS

@hamza221
Copy link
Contributor Author

/backport to stable30

@hamza221
Copy link
Contributor Author

/backport to stable29

ChristophWurst
ChristophWurst reviewed Mar 13, 2025
View reviewed changes
@hamza221 hamza221 force-pushed the fix/noid/contactsmenu-ab-enabled branch 2 times, most recently from 32f8e91 to 53e2eb9 Compare March 14, 2025 09:58
@hamza221 hamza221 mentioned this pull request Mar 14, 2025
Merged
@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2025
@hamza221 hamza221 added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 14, 2025
ChristophWurst
ChristophWurst requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/server/pull/51380/files#r1998480122 marked as resolved but is not resolved

@hamza221
fix(cardav): only show useres from enabled addressBooks in contacts menu
c9d9abd 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/noid/contactsmenu-ab-enabled branch from 53e2eb9 to c9d9abd Compare March 17, 2025 10:56
@hamza221 hamza221 merged commit bf06b25 into master Mar 17, 2025
203 of 213 checks passed
@hamza221 hamza221 deleted the fix/noid/contactsmenu-ab-enabled branch March 17, 2025 16:51
This was referenced Mar 17, 2025
Merged
Merged
Merged
@artonge artonge mentioned this pull request Mar 19, 2025
Merged
@hamza221 hamza221 mentioned this pull request Aug 18, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD GretaD approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews bug feature: carddav Related to CardDAV internals pending documentation This pull request needs an associated documentation update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hamza221 @SebastianKrupinski @ChristophWurst @GretaD @come-nc