Fix display name of new users #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
This was referenced Sep 5, 2024
|
Wait, I messed it 🤦 Back to Developing, not ready for review yet. |
Although the display name of users is updated in a circle when it is changed in the user settings, the new display name was not shown if the user was then added to a circle due to a missing update of the member and, therefore, the cached name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
fix-display-name-of-new-users
branch
from
0ffd9bc to
3903094
Compare
Alright, ready for review now. |
|
Old accounts don't get updated by |
Well, that's a separate issue and can be tackled separately. |
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nextcloud/contacts#3646
Although since #1648 the display name of users is updated in a circle when it is changed in the user settings, the new display name was not shown if the user was then added to a circle; when the display name is changed it needs to be updated both for the circles and the members, similarly to how it is done when updating the display name in the
MaintenanceService.Originally this pull request had an additional commit to set the display name of the associated member based on the
IUserAPI instead of the account data when a user was created; this was done on the basis that the user was updated after being created due to the avatar being generated, but that it was just a happy coincidence and the user should be properly set up from the beginning. But that was wrong 🤦 When theUserCreatedevent is triggered the user does not even have a display name set, and theUserChangedevent is then triggered not only when the avatar is generated, but when the display name is actually set in the newly created user. Due to that the extra commit was dropped.How to test (scenario 1)
Result with this pull request
The display name of the user is shown in the circle
Result without this pull request
The id of the user is shown in the circle
How to test (scenario 2)
Result with this pull request
The display name of the user is shown in the circle
Result without this pull request
The id of the user is shown in the circle