Skip to content

Conversation

@SergeyMosin
Copy link

@SergeyMosin SergeyMosin commented Jul 9, 2023

Fix #5389

One way to resolve #5030

image

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08% ⚠️

Comparison is base (7f39c7b) 22.66% compared to head (8fa9d99) 22.58%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5355      +/-   ##
============================================
- Coverage     22.66%   22.58%   -0.08%     
  Complexity      372      372              
============================================
  Files           237      238       +1     
  Lines         11725    11763      +38     
  Branches       2282     2297      +15     
============================================
  Hits           2657     2657              
- Misses         9068     9106      +38     
Flag Coverage Δ
javascript 13.83% <0.00%> (-0.06%) ⬇️
php 65.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/components/Editor/Properties/PropertyText.vue 0.00% <0.00%> (ø)
src/mixins/PropertyLinksMixin.js 0.00% <0.00%> (ø)
src/views/EditSidebar.vue 0.00% <ø> (ø)
src/views/EditSimple.vue 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thank you very much for the PR ❤️

I rebased and fixed linter issues.

@st3iny st3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 8, 2023
@st3iny st3iny added this to the v4.5.0 milestone Aug 8, 2023
@st3iny st3iny added enhancement New feature request Feature: Editor labels Aug 8, 2023
@st3iny st3iny mentioned this pull request Aug 8, 2023
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@ChristophWurst
Copy link
Member

"linkifyjs" is extraneous

almost

@st3iny st3iny enabled auto-merge August 8, 2023 10:32
@st3iny st3iny merged commit ba23fe1 into nextcloud:main Aug 8, 2023
@szaimen
Copy link
Contributor

szaimen commented Aug 8, 2023

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request Feature: Editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve handling of links for online events Don't always show input fields

4 participants