Skip to content

[stable32] feat: Add comment support #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 28 commits into from
Nov 13, 2025
Merged

[stable32] feat: Add comment support #844

nickvergessen merged 28 commits into from
Nov 13, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 24, 2025 •
edited by nickvergessen
Loading

Backport of #842

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 32.0.2 milestone Oct 24, 2025
@nickvergessen
Copy link
Member

nickvergessen commented Oct 24, 2025

Cherry pick #843

nickvergessen and others added 22 commits November 10, 2025 16:51
@nickvergessen @DorraJaouad
fix(API): Improve config handling
eb18edd 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
feat: Add comment support
ef3356c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
ci(psalm): Add psalm CI
5866cc9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
fix: Add Override attribute
75c0e50 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
ci(phpunit): Setup and fix PHPUnit
8e15f21 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
ci(Actions): Update GitHub actions
b57dbdb 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
ci: Lock specific versions
7ad0bcf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
ci: Fix cs config path
c4ce0b1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
fix(reuse): Add license for composer files
90793ea 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
feat(add): Allow overwriting an entry
1109c72 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
fix(phpunit): ignore phpunit cache
a9b5ace 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@DorraJaouad
feat(App): add comment field in input
0cc5906 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
feat(App): support editing comment in UI
d6fb035 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(BruteForceItem): use item object directly to maintain reactivity
8d63d6c 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
feat(App): reword whitelist to allow list
daa539e 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: adjust test
ba06b9c 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@nickvergessen @DorraJaouad
build: Fix browserslist version
4a3e65d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
fix(comments): Store comments lazy and enforce max length as well
a2dcda5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
fix(comment): Wording refinement for the comment
b2aa717 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@DorraJaouad
fix(api): Load comment from lazy config section
07502be 
Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(App): extend placeholder text for more clarity
a2facbf 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: adjust package lock, it was conflicting with stable32
a953632 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the backport/842/stable32 branch from 71dbe11 to a953632 Compare November 10, 2025 15:55
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.72956% with 37 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable32@ae1ab89). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/App.vue 77.34% 29 Missing ⚠️
src/services/bruteforceSettingsServices.js 0.00% 6 Missing ⚠️
...alogs_dist_chunks_PublicAuthPrompt-B9s61JiV_mjs.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             stable32     #844   +/-   ##
===========================================
  Coverage            ?   14.11%           
===========================================
  Files               ?      107           
  Lines               ?     1799           
  Branches            ?      130           
===========================================
  Hits                ?      254           
  Misses              ?     1440           
  Partials            ?      105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickvergessen
fix(cs): FIx PHP coding style
cda798d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Fix missing dependencies
112c0b6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(comments): Fix conflict resolution
b4aa6d8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@DorraJaouad DorraJaouad marked this pull request as ready for review November 12, 2025 07:52
@nickvergessen
Copy link
Member

nickvergessen commented Nov 12, 2025

I'll fix PHP CI soon

@nickvergessen
ci: Downgrade to allow PHP 8.1
da23cc4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz blizzz mentioned this pull request Nov 12, 2025
Merged
9 tasks
@nickvergessen
ci(psalm): Fix min PHP version
1b25e8e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

nickvergessen commented Nov 13, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
2987486 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nickvergessen
nickvergessen approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@nickvergessen nickvergessen merged commit 497d968 into stable32 Nov 13, 2025
54 checks passed
@nickvergessen nickvergessen deleted the backport/842/stable32 branch November 13, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@nickvergessen nickvergessen

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 32.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @DorraJaouad @nextcloud-command