Skip to content

feat: Add comment support #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 21 commits into from
Oct 24, 2025
Merged

feat: Add comment support #842

DorraJaouad merged 21 commits into from
Oct 24, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 22, 2025 •
edited by DorraJaouad
Loading

Fix #561
Fix #1

image image
  • Allow a comment on add
  • Allow editing?
  • Add frontend @DorraJaouad

@nickvergessen
fix(API): Improve config handling
ae86b3e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat: Add comment support
9bef465 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci(psalm): Add psalm CI
4ad4ba4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix: Add Override attribute
000e580 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci(phpunit): Setup and fix PHPUnit
4ac2678 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci(Actions): Update GitHub actions
38dc2e5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@nickvergessen
ci: Lock specific versions
0a4db5c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Fix cs config path
b99f339 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(reuse): Add license for composer files
5888675 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(add): Allow overwriting an entry
e60878b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(phpunit): ignore phpunit cache
5d82a2a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
nickvergessen commented Oct 23, 2025
View reviewed changes
nickvergessen
nickvergessen commented Oct 23, 2025
View reviewed changes
nickvergessen
nickvergessen commented Oct 23, 2025
View reviewed changes
DorraJaouad and others added 7 commits October 24, 2025 09:23
@DorraJaouad
feat(App): add comment field in input
c4e9198 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
feat(App): support editing comment in UI
59c033e 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(BruteForceItem): use item object directly to maintain reactivity
6dba3aa 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
feat(App): reword whitelist to allow list
fa527d2 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: adjust test
7745151 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@nickvergessen @DorraJaouad
build: Fix browserslist version
a57d3a1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @DorraJaouad
fix(comments): Store comments lazy and enforce max length as well
6e5eaa3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@DorraJaouad DorraJaouad force-pushed the feat/561/comment-for-allowed-ips branch from e794385 to 6e5eaa3 Compare October 24, 2025 07:31
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 24, 2025

/compile /

DorraJaouad
DorraJaouad reviewed Oct 24, 2025
View reviewed changes
@nickvergessen @DorraJaouad
fix(comment): Wording refinement for the comment
b78106a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@DorraJaouad DorraJaouad force-pushed the feat/561/comment-for-allowed-ips branch from 402227f to cd5ce46 Compare October 24, 2025 07:59
@DorraJaouad
fix(api): Load comment from lazy config section
2d8b180 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/561/comment-for-allowed-ips branch from cd5ce46 to 2d8b180 Compare October 24, 2025 08:00
@DorraJaouad
Copy link
Collaborator

DorraJaouad commented Oct 24, 2025

/compile /

@nextcloud-command
chore(assets): Recompile assets
3332392 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@DorraJaouad DorraJaouad merged commit 7a133d7 into master Oct 24, 2025
53 checks passed
@DorraJaouad DorraJaouad deleted the feat/561/comment-for-allowed-ips branch October 24, 2025 08:38
@DorraJaouad
Copy link
Collaborator

DorraJaouad commented Oct 24, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Oct 24, 2025
Merged
2 tasks
@SystemKeeper SystemKeeper mentioned this pull request Dec 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@nickvergessen nickvergessen

Labels

2. developing enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a comment field on a whitelisted entry Run tests

4 participants

@nickvergessen @DorraJaouad @nextcloud-command