Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 6, 2025

Backport of PR #7781

@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews labels Nov 6, 2025
@backportbot backportbot bot added this to the 8.34.0 milestone Nov 6, 2025
@ShGKme ShGKme force-pushed the backport/7781/stable8 branch from 755a7d6 to 28c7e3a Compare November 6, 2025 17:17
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.61%. Comparing base (085edf3) to head (dd5b1a9).
⚠️ Report is 3 commits behind head on stable8.

Files with missing lines Patch % Lines
src/components/NcFormBoxSwitch/NcFormBoxSwitch.vue 31.81% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7795      +/-   ##
===========================================
- Coverage    44.69%   44.61%   -0.08%     
===========================================
  Files          187      188       +1     
  Lines         4652     4707      +55     
  Branches      1211     1226      +15     
===========================================
+ Hits          2079     2100      +21     
- Misses        2478     2512      +34     
  Partials        95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme force-pushed the backport/7781/stable8 branch from 28c7e3a to f162c7a Compare November 6, 2025 17:21
@ShGKme ShGKme marked this pull request as draft November 6, 2025 17:29
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/7781/stable8 branch from f162c7a to dd5b1a9 Compare November 6, 2025 17:37
@ShGKme ShGKme marked this pull request as ready for review November 6, 2025 17:40
@ShGKme
Copy link
Contributor

ShGKme commented Nov 6, 2025

Always getting lost in these 3 different defineEmits formats... (Vue 3.2, Vue 3.3, experimental).

@ShGKme ShGKme merged commit f515c3e into stable8 Nov 6, 2025
19 of 23 checks passed
@ShGKme ShGKme deleted the backport/7781/stable8 branch November 6, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants