-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add NcFormBoxSwitch #7781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7781 +/- ##
=======================================
Coverage 51.57% 51.57%
=======================================
Files 96 96
Lines 3143 3143
Branches 863 863
=======================================
Hits 1621 1621
Misses 1274 1274
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GVodyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and the code looks good!
f77a4d4 to
8f194c1
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
22717cb to
b4d47e1
Compare
|
Rebased after merging the base component |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I do not think we need duplicated events but 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but quickly toggling it causes the text to be selected.
Could we somehow disable the double-click to select text behavior? Or more generally, disable text selection for FormBoxButton and co. maybe?
Edit: Actually yes, it seems to not happen with FormBoxButton despite the text still being selectable there too. So I'm guessing this should receive the same treatment?
|
@kra-mo user selection is disabled in both components. What web-browser you are testing with? |
Interesting because it does work for one but not the other. macOS Safari. |
|
I was just about to push removing the event you didn't want to have, split them into a separated PR =\ |
|
I'll consider your merge as "I like the events" then 👀 |
|
/backport to stable8 |
☑️ Resolves
NcFormBoxButton🖼️ Screenshots
Accessible input position:
🏁 Checklist
stable8for maintained Vue 2 version or not applicable