Skip to content

feat: add NcFormBox and adjust NcRadioGroup to NcFormbox and NcFormGroup #7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

feat: add NcFormBox and adjust NcRadioGroup to NcFormbox and NcFormGroup #7690

merged 2 commits into from
Nov 3, 2025
+211 −65

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 20, 2025 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

image
Before After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.1.0 milestone Oct 20, 2025
@ShGKme ShGKme requested a review from susnux October 20, 2025 17:00
@ShGKme ShGKme self-assigned this Oct 20, 2025
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews labels Oct 20, 2025
@ChristophWurst ChristophWurst marked this pull request as ready for review October 21, 2025 09:13
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Oct 21, 2025

Adjusting PR state to labels

This was referenced Oct 21, 2025
Open
Open
@ChristophWurst

This comment was marked as resolved.

Sign in to view
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 21, 2025

/backport to stable8

GVodyanov
GVodyanov approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, nice!

@susnux susnux mentioned this pull request Oct 21, 2025
Merged
3 tasks
susnux
susnux reviewed Oct 21, 2025
View reviewed changes
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 21, 2025

Rebased to have clean CI, no changes in the code

@ShGKme ShGKme changed the title feat: add NcFormGroup and adjust NcRadioGroup to NcFieldset and NcFormGroup feat: add NcFormBox and adjust NcRadioGroup to NcFormbox and NcFormGroup Oct 29, 2025
@ShGKme ShGKme marked this pull request as draft October 29, 2025 14:47
Base automatically changed from feat/NcFieldset to main October 30, 2025 20:50
@susnux susnux marked this pull request as ready for review October 30, 2025 20:54
@ShGKme ShGKme marked this pull request as draft October 30, 2025 22:27
@ShGKme ShGKme removed the 3. to review Waiting for reviews label Oct 30, 2025
ShGKme added 2 commits November 3, 2025 17:56
@ShGKme
feat: add NcFormGroup
340c497 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(NcRadioGroup): re-implement using NcFieldset and NcFormGroup
188fb84 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 3, 2025 •
edited
Loading

  • Rebased
  • Fixed a minor issue with horizontal items stretching (no before/after difference now for the last example)
  • Fixed a typo in re-export

@ShGKme ShGKme marked this pull request as ready for review November 3, 2025 16:57
@codecov
Copy link

codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.57%. Comparing base (4e3b308) to head (188fb84).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7690   +/-   ##
=======================================
  Coverage   51.57%   51.57%           
=======================================
  Files          96       96           
  Lines        3141     3141           
  Branches      862      863    +1     
=======================================
  Hits         1620     1620           
  Misses       1273     1273           
  Partials      248      248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme requested a review from susnux November 3, 2025 17:02
AndyScherzinger
AndyScherzinger approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger
Copy link
Contributor

AndyScherzinger commented Nov 3, 2025

@susnux can you have a look please 🙏 Thanks in advance!

@susnux
Copy link
Contributor

susnux commented Nov 3, 2025

@susnux can you have a look please 🙏 Thanks in advance!

Sure I am on it

@susnux susnux merged commit e14b022 into main Nov 3, 2025
29 checks passed
@susnux susnux deleted the feat/NcFormGroup branch November 3, 2025 18:34
@backportbot backportbot bot mentioned this pull request Nov 3, 2025
Merged
2 tasks
@susnux susnux modified the milestones: 9.1.0, 9.2.0 Nov 4, 2025
@ShGKme ShGKme mentioned this pull request Nov 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@GVodyanov GVodyanov GVodyanov approved these changes

Assignees

@ShGKme ShGKme

Labels

enhancement New feature or request

Projects

None yet

Milestone

9.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ShGKme @ChristophWurst @AndyScherzinger @susnux @GVodyanov