Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 3, 2025

Backport of #7690

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews labels Nov 3, 2025
@backportbot backportbot bot added this to the 8.33.0 milestone Nov 3, 2025
@ShGKme ShGKme force-pushed the backport/7690/stable8 branch from 37850be to fc2a639 Compare November 3, 2025 19:24
Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@ShGKme
Copy link
Contributor

ShGKme commented Nov 4, 2025

Requires merged NcFormGroup backport

@ShGKme ShGKme changed the title [stable8] feat: add NcFormBox and adjust NcRadioGroup to NcFormbox and NcFormGroup [stable8] feat: add NcFormBox and adjust NcRadioGroup to NcFormBox and NcFormGroup Nov 4, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Nov 4, 2025

having [Vue warn]: useCssModule() is not supported in the global build but unsure if it is a styleguidist issue, checking

@susnux susnux modified the milestones: 8.33.0, 8.34.0 Nov 4, 2025
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/7690/stable8 branch from fc2a639 to 823115f Compare November 5, 2025 14:03
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.00%. Comparing base (68e8736) to head (7385a25).
⚠️ Report is 8 commits behind head on stable8.

Files with missing lines Patch % Lines
src/components/NcFormBox/NcFormBox.vue 56.00% 11 Missing ⚠️
src/components/NcFormBox/useNcFormBox.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7765      +/-   ##
===========================================
+ Coverage    44.88%   45.00%   +0.12%     
===========================================
  Files          180      182       +2     
  Lines         4465     4495      +30     
  Branches      1168     1174       +6     
===========================================
+ Hits          2004     2023      +19     
- Misses        2366     2377      +11     
  Partials        95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme force-pushed the backport/7690/stable8 branch from 823115f to 1a10480 Compare November 5, 2025 15:25
@ShGKme ShGKme marked this pull request as ready for review November 5, 2025 15:26
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/7690/stable8 branch from 1a10480 to 7385a25 Compare November 5, 2025 18:19
@ShGKme ShGKme merged commit 2c15ef2 into stable8 Nov 5, 2025
19 of 21 checks passed
@ShGKme ShGKme deleted the backport/7690/stable8 branch November 5, 2025 19:10
@AndyScherzinger
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants