fix(NcDateTimePicker): adjust input padding inline end #7208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler+nextcloud@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler+nextcloud@mailbox.org>
raimund-schluessler
added
enhancement
Antreesy
approved these changes
Jul 28, 2025
ShGKme
approved these changes
Jul 28, 2025
susnux
reviewed
Jul 28, 2025
| } | ||
| .vue-date-time-picker--clearable :deep(.dp__input) { | ||
| padding-inline-end: var(--default-clickable-area); |
There was a problem hiding this comment.
Should be not just update the --dp-input-padding variable here?
There was a problem hiding this comment.
You mean like this?
Suggested change
| padding-inline-end: var(--default-clickable-area); | |
| --dp-input-padding: 6px var(--default-clickable-area) 6px 12px; |
This should also work, I don't have a preference here, honestly.
There was a problem hiding this comment.
but also if 6px/12px will change, we have to update in in both places. -inline-end is limiting changes
There was a problem hiding this comment.
My reasoning was just that the variables are public API but the class names could break someday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcDateTimePickerinput field, so that less space is wasted if no clearable button is present.🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable