Skip to content

fix(NcDateTimePicker): adjust input padding inline end #7208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

fix(NcDateTimePicker): adjust input padding inline end #7208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5e138
fix(NcDateTimePicker): adjust input padding inline end
raimund-schluessler Jul 28, 2025
35ea9f5
fix: fixup
raimund-schluessler Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/NcDateTimePicker/NcDateTimePicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ function cancelSelection() {
:aria-labels
:auto-apply="!confirm"
class="vue-date-time-picker"
:class="{ 'vue-date-time-picker--clearable': clearable }"
:cancel-text="t('Cancel')"
:clearable
:day-names
Expand Down Expand Up @@ -671,7 +672,7 @@ function cancelSelection() {
--dp-cell-padding: 5px;
--dp-common-padding: 10px;
--dp-input-icon-padding: var(--default-clickable-area);
--dp-input-padding: 6px 30px 6px 12px;
--dp-input-padding: 6px 12px;
--dp-menu-min-width: 260px;
--dp-action-buttons-padding: 1px 6px;
--dp-row-margin: 5px 0;
Expand All @@ -692,6 +693,10 @@ function cancelSelection() {
@include meta.load-css('@vuepic/vue-datepicker/dist/main.css');
}

.vue-date-time-picker--clearable :deep(.dp__input) {
padding-inline-end: var(--default-clickable-area);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be not just update the --dp-input-padding variable here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like this?

Suggested change
padding-inline-end: var(--default-clickable-area);
--dp-input-padding: 6px var(--default-clickable-area) 6px 12px;

This should also work, I don't have a preference here, honestly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but also if 6px/12px will change, we have to update in in both places. -inline-end is limiting changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was just that the variables are public API but the class names could break someday.

}

.vue-date-time-picker__timezone {
min-width: unset;
width: 100%;
Expand Down
Loading