Skip to content

[stable8] feat(NcAppSidebar): add info slot #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

[stable8] feat(NcAppSidebar): add info slot #6843

merged 3 commits into from
Apr 25, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Apr 25, 2025 •
edited by Antreesy
Loading

Backport of #6666

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
    • @click.self -> @click.self.native
    • warn -> Vue.util.warn
    • downgrade NcAppSidebarHeader to lang="js" (build fails with defineProps<{}>())
    • replace shorthand v-binds

@Antreesy @backportbot
feat(NcAppSidebar): expose CSS variable with close button offset
25974cb 
- var(--app-sidebar-close-button-offset)

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Apr 25, 2025
@backportbot backportbot bot added this to the 8.26.0 milestone Apr 25, 2025
@Antreesy Antreesy force-pushed the backport/6666/stable8 branch 2 times, most recently from 299aa59 to a84f111 Compare April 25, 2025 10:08
@Antreesy Antreesy marked this pull request as ready for review April 25, 2025 10:13
@Antreesy
Copy link
Contributor

Antreesy commented Apr 25, 2025

Tested against nextcloud/spreed#14926

image

@Antreesy Antreesy requested a review from ShGKme April 25, 2025 10:13
Antreesy added 2 commits April 25, 2025 14:01
@Antreesy
feat(NcAppSidebar): introduce NcAppSidebarHeader for a11y navigation
4c89007 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(NcAppSidebar): introduce 'info' slot for customization
7bd618c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/6666/stable8 branch from a84f111 to 7bd618c Compare April 25, 2025 12:06
@ShGKme ShGKme changed the title [stable8] feat(NcAppSidebar): add 'content' slot [stable8] feat(NcAppSidebar): add info slot Apr 25, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Apr 25, 2025

  • downgrade NcAppSidebarHeader to lang="js" (build fails with defineProps<{}>())

Weird... It is supported in Vue 2

@Antreesy Antreesy merged commit 550ecee into stable8 Apr 25, 2025
23 checks passed
@Antreesy Antreesy deleted the backport/6666/stable8 branch April 25, 2025 13:00
@Antreesy Antreesy mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews enhancement New feature or request feature: app-sidebar Related to the app-sidebar component

Projects

None yet

Milestone

8.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @ShGKme @susnux