-
Notifications
You must be signed in to change notification settings - Fork 95
feat(NcAppSidebar): add info slot
#6666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54cd97c to
9d6aba4
Compare
9d6aba4 to
f086d2e
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically makes sense - not sure about design.
But in general I like the idea of splitting it into a layout component and the specialized components, so 👍
DorraJaouad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paddings seem to be off, also close button will not be placed consistent.
I think we need to polish the implementation a bit before pushing this to public API.
ce12f05 to
8319b4e
Compare
8319b4e to
d6e9b39
Compare
b22c2e1 to
070eb52
Compare
|
/backport! to stable8 |
|
Proposals:
|
- var(--app-sidebar-close-button-offset) Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
953262f to
b94acdf
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
b94acdf to
e818f86
Compare
ShGKme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
info slot



☑️ Resolves
infoslotvar(--app-sidebar-close-button-offset)for custom content positioning (respecting the space taken by close button)NcAppSidebarHeaderfor a11y navigationSee https://github.com/nextcloud-libraries/nextcloud-vue/pull/6666/files?w=1 for non-whitespace changes
See https://github.com/nextcloud-libraries/nextcloud-vue/tree/feat/noid/appsidebar-header-empty-slot-vue2 for Vue2 branch to test with apps
🖼️ Screenshots
Quick prototype for Talk:
2025-04-23_13h59_29.mp4
🏁 Checklist
stable8requested