refactor(NcChip): use defineSlots for proper slot definition
#6792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
force-pushed
the
chore/nc-chip-ts
branch
2 times, most recently
from
a168318 to
729dfc8
Compare
ShGKme
reviewed
Apr 16, 2025
susnux
force-pushed
the
chore/nc-chip-ts
branch
from
729dfc8 to
6c2b368
Compare
ShGKme
approved these changes
Apr 16, 2025
This resolves 2 errors reported by Typescript when building the package (missing "private" type exports during the declaration creation). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/nc-chip-ts
branch
from
6c2b368 to
e6c02b8
Compare
Contributor
Author
|
Partly already done - otherwise replaced by #6903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This resolves 2 errors reported by Typescript when building the package (missing "private" type exports during the declaration creation).
🏁 Checklist
stable8for maintained Vue 2 version or not applicable