You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
refactor(NcChip): use defineSlots for proper slot definition
This resolves 2 errors reported by Typescript when building the package
(missing "private" type exports during the declaration creation).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy file name to clipboardExpand all lines: src/components/NcChip/NcChip.vue
+27-9Lines changed: 27 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -77,7 +77,6 @@ export default {
77
77
'nc-chip--no-icon': !hasIcon(),
78
78
}">
79
79
<spanv-if="hasIcon()"class="nc-chip__icon">
80
-
<!-- @slot The icon slot can be used to set the chip icon. Make sure that the icon is not exceeding a height of `24px`. For round icons a exact size of `24px` is recommended. -->
81
80
<slotname="icon">
82
81
<!-- The default icon wrapper uses a size of 18px to ensure the icon is not clipped by the round chip style -->
83
82
<NcIconSvgWrapperv-if="iconPath || iconSvg"
@@ -88,7 +87,6 @@ export default {
88
87
</slot>
89
88
</span>
90
89
<spanclass="nc-chip__text">
91
-
<!-- @slot The default slot can be used to set the text that is shown -->
92
90
<slot>{{ text }}</slot>
93
91
</span>
94
92
<NcActionsv-if="canClose || hasActions()"
@@ -103,15 +101,16 @@ export default {
103
101
</template>
104
102
{{ ariaLabelClose }}
105
103
</NcActionButton>
106
-
<!-- @slot The actions slot can be used to add custom actions to the chips actions -->
0 commit comments