Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(depencenies): ⌚ Add PSR Clock interface as dependency #4

Merged
merged 1 commit into from
Jan 2, 2023
Merged

feat(depencenies): ⌚ Add PSR Clock interface as dependency #4

merged 1 commit into from
Jan 2, 2023

Conversation

nickvergessen
Copy link
Contributor

To not cause issues on the OCP interface extending PSR, similar to the logger
Ref: nextcloud/3rdparty#1262

@nickvergessen
feat(depencenies): ⌚ Add PSR Click interface as dependency
8f43f2f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Contributor Author

cc @come-nc

@nickvergessen nickvergessen added the enhancement New feature or request label Dec 22, 2022
This was referenced Dec 22, 2022
Merged
Merged
come-nc
come-nc approved these changes Jan 2, 2023
View reviewed changes
Copy link

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix PR name s/Click/Clock/ for posterity

@nickvergessen nickvergessen changed the title feat(depencenies): ⌚ Add PSR Click interface as dependency feat(depencenies): ⌚ Add PSR Clock interface as dependency Jan 2, 2023
@nickvergessen
Copy link
Contributor Author

Please fix PR name s/Click/Clock/ for posterity

Done, thanks for the hint

@nickvergessen nickvergessen merged commit 03b5032 into master Jan 2, 2023
@nickvergessen nickvergessen deleted the compatibility/add-psr-clock-interface branch January 2, 2023 10:45
@ChristophWurst
Copy link
Contributor

Did we merge this too early? https://github.com/nextcloud-deps/ocp/blob/stable26/composer.json has the dep :s

@ChristophWurst ChristophWurst mentioned this pull request Mar 6, 2023
Merged
@nickvergessen
Copy link
Contributor Author

Well not specifically. The problem is I was waiting for the PHP 7.4 drop, then forgot to merge the PR and then didn't want to break OCP anymore afterwards. So yeah, reverting in stable26 should do a trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@come-nc come-nc come-nc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @ChristophWurst @come-nc