feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface by nickvergessen · Pull Request #35872 · nextcloud/server

nickvergessen · 2022-12-22T19:13:37Z

Summary

ITimeFactory now implements PSR-20: https://www.php-fig.org/psr/psr-20/#21-clockinterface

TODO

3rdparty feat(PSR): ⌚ Add PSR Clock interface as dependency 3rdparty#1262
OCP update so Psalm can find the interface feat(depencenies): ⌚ Add PSR Clock interface as dependency nextcloud-deps/ocp#4

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

lib/public/AppFramework/Utility/ITimeFactory.php

ChristophWurst

Given how easy it is to get a mutable object form the immutable one I wouldn't include the helper but I'm okay if we do.

Nice addition to the PSR API family 👍

ChristophWurst · 2022-12-23T14:41:14Z

Might or might not make sense to deprecate getTime right away.

nickvergessen · 2022-12-23T15:47:41Z

Might or might not make sense to deprecate getTime right away.

Same for the getDateTime() I think

nickvergessen · 2022-12-23T15:51:53Z

lib/private/AppFramework/Utility/TimeFactory.php

+		return \DateTime::createFromImmutable($this->now());
+	}
+
+	public function withTimeZone(\DateTimeZone $timezone): static {


: static is 8.0+ only, but currently linting is still run against 7.4 while we plan to drop it.
Could remove the typing for now, or we keep it and make sure the 7.4 lint job is removed already

ChristophWurst · 2023-01-09T15:56:49Z

I would love to see this documented at https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/psr.html :)

nickvergessen · 2023-01-09T16:01:13Z

Will do, after it's merged

ChristophWurst

nickvergessen · 2023-01-23T10:36:34Z

Rebased, now that 7.4 is dropped

nickvergessen · 2023-02-23T15:54:37Z

Dang, this slipped through. To preserve stability in OCP, I'm moving it to 27

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen · 2023-03-06T09:04:21Z

Docs in #37039 (comment) and nextcloud/documentation#9722

ChristophWurst · 2023-10-11T08:59:36Z

lib/public/AppFramework/Utility/ITimeFactory.php

+ * Use this to get a timestamp or DateTime object in code to remain testable
+ *
 * @since 8.0.0
+ * @since 26.0.0 Extends the \Psr\Clock\ClockInterface interface


are you sure about that? ;)

YOu mean extends vs implements?

I'm pretty sure it's correct here, but yeah on the actual implementation the comment could be adjusted

The since 26. I just had Mail integration tests fail because I used now for 26. It's only there for 27+ :)

Ah, yeah see comment above:

Dang, this slipped through. To preserve stability in OCP, I'm moving it to 27

Sorry about that :(

Correct in the docs though:
https://github.com/nextcloud/documentation/pull/9722/files#diff-57ff377b410d357ae058639b6b02b9c84b599ab1ffcc89c99f6d2b0bb7864d84R53

Fix in #40865

nickvergessen added enhancement 3. to review Waiting for reviews labels Dec 22, 2022

nickvergessen added this to the Nextcloud 26 milestone Dec 22, 2022

nickvergessen requested review from ChristophWurst and come-nc December 22, 2022 19:13

nickvergessen self-assigned this Dec 22, 2022

nickvergessen mentioned this pull request Dec 22, 2022

feat(PSR): ⌚ Add PSR Clock interface as dependency nextcloud/3rdparty#1262

Merged

ChristophWurst reviewed Dec 22, 2022

View reviewed changes

lib/public/AppFramework/Utility/ITimeFactory.php Outdated Show resolved Hide resolved

ChristophWurst approved these changes Dec 23, 2022

View reviewed changes

nickvergessen commented Dec 23, 2022

View reviewed changes

nickvergessen force-pushed the feature/noid/psr-clock-interface branch from 589cf70 to c4e4d91 Compare December 23, 2022 16:00

nickvergessen force-pushed the feature/noid/psr-clock-interface branch from c4e4d91 to 2b12b75 Compare January 2, 2023 10:48

nickvergessen marked this pull request as ready for review January 2, 2023 11:25

ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jan 9, 2023

ChristophWurst approved these changes Jan 9, 2023

View reviewed changes

come-nc approved these changes Jan 10, 2023

View reviewed changes

nickvergessen force-pushed the feature/noid/psr-clock-interface branch from 2b12b75 to acf0412 Compare January 23, 2023 10:35

blizzz mentioned this pull request Feb 1, 2023

26.0.0 beta 2 #36484

Merged

skjnldsv mentioned this pull request Feb 23, 2023

26.0.0 beta 5 #36834

Merged

nickvergessen modified the milestones: Nextcloud 26, Nextcloud 27 Feb 23, 2023

feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface

c297f8e

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the feature/noid/psr-clock-interface branch from acf0412 to c297f8e Compare March 3, 2023 14:37

nickvergessen enabled auto-merge March 3, 2023 14:37

nickvergessen disabled auto-merge March 5, 2023 15:55

nickvergessen merged commit eddc6f2 into master Mar 6, 2023

nickvergessen deleted the feature/noid/psr-clock-interface branch March 6, 2023 08:49

This was referenced Mar 6, 2023

Changes for developers & admins for Nextcloud 27 #37039

Closed

feat(developer): Document PSR-20 implementation of ITimeFactory nextcloud/documentation#9722

Merged

nickvergessen removed the pending documentation This pull request needs an associated documentation update label Mar 6, 2023

ChristophWurst reviewed Oct 11, 2023

View reviewed changes

nickvergessen mentioned this pull request Oct 11, 2023

Fix version number in ITimeFactory after it was delayed #40865

Merged

4 tasks

Uh oh!

Conversation

nickvergessen commented Dec 22, 2022 • edited by ChristophWurst Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Dec 23, 2022

Uh oh!

nickvergessen commented Dec 23, 2022

Uh oh!

nickvergessen Dec 23, 2022

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Jan 9, 2023

Uh oh!

nickvergessen commented Jan 9, 2023

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Jan 23, 2023

Uh oh!

nickvergessen commented Feb 23, 2023

Uh oh!

nickvergessen commented Mar 6, 2023

Uh oh!

ChristophWurst Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickvergessen commented Dec 22, 2022 •

edited by ChristophWurst

Loading

ChristophWurst Oct 11, 2023 •

edited

Loading