Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[Rel Eng] Dial In LM Eval Tests Phase 1 #289

Merged
merged 26 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1009145
dialing in accuracy tests
robertgshaw2-neuralmagic Jun 8, 2024
09d6786
added new files
robertgshaw2-neuralmagic Jun 8, 2024
251112d
format
robertgshaw2-neuralmagic Jun 8, 2024
4e98546
refactored workflow
robertgshaw2-neuralmagic Jun 8, 2024
0689d1e
plumbing
robertgshaw2-neuralmagic Jun 8, 2024
b66dfc1
newline nit
robertgshaw2-neuralmagic Jun 8, 2024
3828a7e
Update remote-push.yaml
robertgshaw2-neuralmagic Jun 8, 2024
4a98aeb
make workflows work
robertgshaw2-neuralmagic Jun 8, 2024
9f1cc2c
hopefully fix
robertgshaw2-neuralmagic Jun 8, 2024
bc2b3f6
update other workflows for `lm-eval` changes (#292)
robertgshaw2-neuralmagic Jun 8, 2024
9109677
added missing configs
robertgshaw2-neuralmagic Jun 9, 2024
bf4b830
Merge branch 'rel-eng/dial-in-accuracy-tests' of https://github.com/n…
robertgshaw2-neuralmagic Jun 9, 2024
e9106b1
added gptq models
robertgshaw2-neuralmagic Jun 9, 2024
f20641d
readded
robertgshaw2-neuralmagic Jun 9, 2024
c51beba
updated configs
robertgshaw2-neuralmagic Jun 9, 2024
3bb927c
Update nm-build-test.yml
robertgshaw2-neuralmagic Jun 10, 2024
6c6818e
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 10, 2024
c130028
updated to include .sh
robertgshaw2-neuralmagic Jun 11, 2024
cbb4380
updated to use lm_eval_label
robertgshaw2-neuralmagic Jun 11, 2024
60c0309
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 11, 2024
344bf78
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 11, 2024
a79075d
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 11, 2024
bebf6d3
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 13, 2024
ce0fcdb
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 16, 2024
0dba00a
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 20, 2024
593c8e9
Merge branch 'main' into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic Jun 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions .github/actions/nm-lm-eval-smoke/action.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
name: run lm-eval full accuracy test
description: 'run lm-eval full accuracy test'
name: run lm-eval accuracy test
description: 'run lm-eval accuracy test'
inputs:
python:
description: 'python version, e.g. 3.10.12'
required: true
venv:
description: 'name for python virtual environment'
required: true
lm_eval_configuration:
description: 'file containing test configuration'
required: true
runs:
using: composite
steps:
- id: lm-eval
run: |
# move source directories
mv vllm vllm-ignore || echo "no 'vllm' folder to move"
mv csrc csrc-ignore || echo "no 'csrc' folder to move"
mgoin marked this conversation as resolved.
Show resolved Hide resolved

if [ -n "${{ inputs.venv }}" ]; then
COMMIT=${{ github.sha }}
VENV="${{ inputs.venv }}-${COMMIT:0:7}"
Expand All @@ -26,7 +25,7 @@ runs:
pip3 install pytest openai==1.3.9

SUCCESS=0
pytest -v tests/accuracy/test_lm_eval_correctness.py || SUCCESS=$?
echo "test=${SUCCESS}" >> "$GITHUB_OUTPUT"
./.github/scripts/nm-run-lm-eval-vllm -c ${{ inputs.lm_eval_configuration }} || SUCCESS=$?
echo "lm_eval=${SUCCESS}" >> "$GITHUB_OUTPUT"
exit ${SUCCESS}
shell: bash
125 changes: 0 additions & 125 deletions .github/scripts/lm_eval_compare_hf_vs_vllm.py

This file was deleted.

50 changes: 50 additions & 0 deletions .github/scripts/nm-run-lm-eval-gsm-hf-baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
#!/bin/bash
robertgshaw2-neuralmagic marked this conversation as resolved.
Show resolved Hide resolved
# We can use this script to compute baseline accuracy on GSM for transformers.
robertgshaw2-neuralmagic marked this conversation as resolved.
Show resolved Hide resolved
#
# Make sure you have lm-eval-harness installed:
# pip install git+https://github.com/EleutherAI/lm-evaluation-harness.git@9516087b81a61d0e220b22cc1b75be76de23bc10

usage() {
echo``
echo "Runs lm eval harness on GSM8k using huggingface transformers."
echo "This pathway is intended to be used to create baselines for "
echo "our automated nm-test-accuracy workflow"
echo
echo "usage: ${0} <options>"
echo
echo " -m - huggingface stub or local directory of the model"
echo " -b - batch size to run the evaluation at"
echo " -d - device to use (e.g. cuda, cuda:0, auto, cpu)"
echo " -l - limit number of samples to run"
echo " -f - number of fewshot samples to use"
echo
}

while getopts "m:b:d:l:f:" OPT; do
case ${OPT} in
m )
MODEL="$OPTARG"
;;
b )
BATCH_SIZE="$OPTARG"
;;
d )
DEVICE="$OPTARG"
;;
l )
LIMIT="$OPTARG"
;;
f )
FEWSHOT="$OPTARG"
;;
\? )
usage
exit 1
;;
esac
done

lm_eval --model hf \
--model_args pretrained=$MODEL \
--tasks gsm8k --num_fewshot $FEWSHOT --limit $LIMIT \
mgoin marked this conversation as resolved.
Show resolved Hide resolved
--batch_size $BATCH_SIZE --device $DEVICE
30 changes: 30 additions & 0 deletions .github/scripts/nm-run-lm-eval-vllm
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#!/bin/bash
robertgshaw2-neuralmagic marked this conversation as resolved.
Show resolved Hide resolved
# We can use this script to compute baseline accuracy on GSM for transformers.
#
# Make sure you have lm-eval-harness installed:
# pip install git+https://github.com/EleutherAI/lm-evaluation-harness.git@9516087b81a61d0e220b22cc1b75be76de23bc10

usage() {
echo``
echo "Runs lm eval harness on GSM8k using vllm server and compares to "
echo "precomputed baseline (measured by HF transformers."
echo
echo "usage: ${0} <options>"
echo
echo " -c - path to the test data config (e.g. neuralmagic/lm-eval/YOUR_CONFIG.yaml)"
echo
}

while getopts "c:" OPT; do
case ${OPT} in
c )
CONFIG="$OPTARG"
;;
\? )
usage
exit 1
;;
esac
done

LM_EVAL_TEST_DATA_FILE=$CONFIG pytest -v tests/accuracy/test_lm_eval_correctness.py
27 changes: 19 additions & 8 deletions .github/workflows/nm-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ on:
type: string
required: true
test_skip_list:
description: 'file containing tests to skip'
description: 'file containing tests to skip (see neuralmagic/tests)'
type: string
required: true
# benchmark related parameters
Expand All @@ -66,6 +66,19 @@ on:
description: "When set to true, the workflow pushes all benchmarking results to gh-pages UI"
type: string
default: "false"
# lm-eval related parameters
lm_eval_label:
description: "requested runner label (specifies instance)"
type: string
default: ""
lm_eval_timeout:
description: "time limit for lm_eval in minutes"
type: string
default: "60"
lm_eval_configuration:
description: "configuration for lm-eval test (see neuralmagic/lm-eval)"
type: string
default: ""

jobs:

Expand Down Expand Up @@ -134,16 +147,14 @@ jobs:
push_benchmark_results_to_gh_pages: "${{ github.event_name == 'schedule' || inputs.push_benchmark_results_to_gh_pages }}"
secrets: inherit

TEST-ACCURACY-FULL:
LM-EVAL-SOLO:
needs: [BUILD]
if: ${{ inputs.wf_category == 'WEEKLY' || inputs.wf_category == 'RELEASE' }}
uses: ./.github/workflows/nm-test-accuracy-full.yml
uses: ./.github/workflows/nm-lm-eval.yml
with:
label: ${{ inputs.test_label_multi }}
timeout: ${{ inputs.benchmark_timeout }}
label: ${{ inputs.test_label_solo }}
dbarbuzzi marked this conversation as resolved.
Show resolved Hide resolved
timeout: ${{ inputs.lm_eval_timeout }}
gitref: ${{ inputs.gitref }}
Gi_per_thread: ${{ inputs.Gi_per_thread }}
nvcc_threads: ${{ inputs.nvcc_threads }}
python: ${{ inputs.python }}
whl: ${{ needs.BUILD.outputs.whl }}
lm_eval_configuration: ${{ inputs.lm_eval_configuration }}
secrets: inherit
Loading
Loading