This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 10
[Rel Eng] Dial In LM Eval Tests Phase 1 #289
Merged
robertgshaw2-neuralmagic
merged 26 commits into
main
from
rel-eng/dial-in-accuracy-tests
Jun 21, 2024
Merged
[Rel Eng] Dial In LM Eval Tests Phase 1 #289
robertgshaw2-neuralmagic
merged 26 commits into
main
from
rel-eng/dial-in-accuracy-tests
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgshaw2-neuralmagic
changed the title
Rel eng/dial in accuracy tests
Rel eng/dial in accuracy tests part 1
Jun 8, 2024
robertgshaw2-neuralmagic
requested review from
andy-neuma,
mgoin,
dbarbuzzi,
derekk-nm and
dhuangnm
June 8, 2024 20:33
…euralmagic/nm-vllm into rel-eng/dial-in-accuracy-tests
robertgshaw2-neuralmagic
changed the title
Rel eng/dial in accuracy tests part 1
[ REL ENG] Dial In Accuracy Tests Phase 1
Jun 9, 2024
robertgshaw2-neuralmagic
changed the title
[ REL ENG] Dial In Accuracy Tests Phase 1
[ Rel Eng ] Dial In Accuracy Tests Phase 1
Jun 9, 2024
robertgshaw2-neuralmagic
changed the title
[ Rel Eng ] Dial In Accuracy Tests Phase 1
[Rel Eng] Dial In Accuracy Tests Phase 1
Jun 9, 2024
robertgshaw2-neuralmagic
changed the title
[Rel Eng] Dial In Accuracy Tests Phase 1
[Rel Eng] Dial In LM Eval Tests Phase 1
Jun 10, 2024
derekk-nm
reviewed
Jun 10, 2024
derekk-nm
reviewed
Jun 10, 2024
derekk-nm
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should work.
Just raised a potential concern about the type
of arg values passed to lm-eval
, and a nit about the units on an arg.
updated with better comment
dbarbuzzi
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about using a new input (that seems otherwise unused) prior to approval.
mgoin
reviewed
Jun 10, 2024
dhuangnm
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
derekk-nm
pushed a commit
that referenced
this pull request
Jun 24, 2024
WAIT UNTIL UPSTREAM SYNC LANDS TO MERGE SUMMARY: * refactored lm-eval workflows to use a single script for generating a baseline * refactored lm-eval workflows to accept a config file so we can parameterize for the different length runs * added configuration for `remote-push` -> running `llama-3-8b` on 250 GSM prompts * removed lm-eval-smoke such that we have one single pathway for running lm-eval tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAIT UNTIL UPSTREAM SYNC LANDS TO MERGE
SUMMARY:
remote-push
-> runningllama-3-8b
on 250 GSM prompts