This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
requirements-dev.txt and workflow patches
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch runner from aws to gcp
SUMMARY: * update GHA action `nm-build-vllm` to not install `nm-magic-wand-nightly` * update build script to not install `nm-magic-wand-nightly` (we might consider getting rid of this script altogether, since we aren't really using it) * remove unused GHA action `nm-test-vllm`. this has been superseded by `nm-install-test-whl` * update GHA action `nm-install-test-whl` to get version of `nm-magic-wand` if `nm-magic-wand-nightly` is not present * update `setup.py` to default generate "nightly" package and add option based on ENV to generate release package. this also includes managing the dependency on `nm-magic-wand`. * update `set-env` action to set ENV based on `wf_category` input * update "release" workflow to include all supported python versions * delete obsolete "gen-whl" NOTES: - "magic-wand" is only a runtime dependency, so no need to install it during build phase. - this PR makes it so that we by default generate a "nightly" package with a "nightly" version number. if we want to generate a release package we'll need to specify `wf_category` as `RELEASE`. TEST PLAN: runs on remote push. verifying that `wf_category` set to `RELEASE` will generate appropriate package. ran "build" workflow with `wf_category` set to `RELEASE` ... package looks properly named and versioned ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129675592 the "remote push" defaulted to generating a "nightly" package ... please see ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129665988 Co-authored-by: andy-neuma <andy@neuralmagic.com>
SUMMARY:
* make `magic-wand` version check robust
TEST PLAN:
runs on remote push. will be manually triggering NIGHTLY and RELEASE
relative to this branch.
```bash
andy@waldorf:~$ cat test.sh
#!/bin/bash
set -euo pipefail
MAGIC_WAND=$(pip3 show nm-magic-wand-nightly | grep "Version" | cut -d' ' -f2) || echo "nightly not installed"
if [ -z "$MAGIC_WAND" ]; then
MAGIC_WAND=$(pip3 show nm-magic-wand | grep "Version" | cut -d' ' -f2)
fi
echo ${MAGIC_WAND}
andy@waldorf:~$ ./test.sh
WARNING: Package(s) not found: nm-magic-wand-nightly
nightly not installed
0.2.2
andy@waldorf:~$ echo $?
0
```
when "nightly" is installed ...
```bash
andy@waldorf:~$ ./test.sh
0.2.2.20240520
```
---------
Co-authored-by: andy-neuma <andy@neuralmagic.com>
(cherry picked from commit 290c53f)
SUMMARY: * increase "RELEASE" workflow timeouts to 12 hours TEST PLAN: will cherry pick and trigger job manually on release, `v0.3.0` Co-authored-by: andy-neuma <andy@neuralmagic.com> (cherry picked from commit 93183d6)
andy-neuma
requested review from
dbarbuzzi,
dhuangnm,
derekk-nm,
robertgshaw2-neuralmagic and
mgoin
dbarbuzzi
approved these changes
May 21, 2024
Cherry-pick vllm-project#4623 from upstream
This PR skips the `mosaicml/mpt-7b` model in the `tests/models/test_big_models.py::test_models` test when using Python 3.8 since that model has custom code that does not work in Python 3.8. It also skips the clean shutdown test in Python < 3.10 as that was failing for some reason in our CI (running the file through pytest locally passes).
dbarbuzzi
added a commit
that referenced
this pull request
May 22, 2024
SUMMARY: * update `requirements-dev.txt` to address `urllib` dependency * update "build test" only be reusable * update "benchmark" workflow to disambiguate artifacts TEST PLAN: runs on remote push --------- Co-authored-by: Michael Goin <michael@neuralmagic.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: andy-neuma <andy@neuralmagic.com> Co-authored-by: Domenic Barbuzzi <dbarbuzzi@gmail.com>
andy-neuma
added a commit
that referenced
this pull request
May 22, 2024
> [!NOTE] > Cherry-pick of #255 into `v0.3.0` SUMMARY: * update `requirements-dev.txt` to address `urllib` dependency * update "build test" only be reusable * update "benchmark" workflow to disambiguate artifacts TEST PLAN: runs on remote push Co-authored-by: Andy Linfoot <78757007+andy-neuma@users.noreply.github.com> Co-authored-by: Michael Goin <michael@neuralmagic.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: andy-neuma <andy@neuralmagic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
requirements-dev.txtto addressurllibdependencyTEST PLAN:
runs on remote push