This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
updates for nm-magic-wand, nightly or release #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-neuma
requested review from
dbarbuzzi,
mgoin,
dhuangnm and
robertgshaw2-neuralmagic
dbarbuzzi
reviewed
May 17, 2024
dbarbuzzi
approved these changes
May 17, 2024
robertgshaw2-neuralmagic
approved these changes
May 17, 2024
| @@ -306,9 +307,28 @@ def find_version(filepath: str) -> str: | |||
| raise RuntimeError("Unable to find version string.") | |||
|
|
|||
|
|
|||
| # Neuralmagic packaging ENV's | |||
There was a problem hiding this comment.
could these be added to nm-vllm/vllm/envs.py?
This is the central location for env vars - perhaps not b/c this is setup.py, but just thought I would ask
andy-neuma
added a commit
that referenced
this pull request
May 17, 2024
SUMMARY: * update GHA action `nm-build-vllm` to not install `nm-magic-wand-nightly` * update build script to not install `nm-magic-wand-nightly` (we might consider getting rid of this script altogether, since we aren't really using it) * remove unused GHA action `nm-test-vllm`. this has been superseded by `nm-install-test-whl` * update GHA action `nm-install-test-whl` to get version of `nm-magic-wand` if `nm-magic-wand-nightly` is not present * update `setup.py` to default generate "nightly" package and add option based on ENV to generate release package. this also includes managing the dependency on `nm-magic-wand`. * update `set-env` action to set ENV based on `wf_category` input * update "release" workflow to include all supported python versions * delete obsolete "gen-whl" NOTES: - "magic-wand" is only a runtime dependency, so no need to install it during build phase. - this PR makes it so that we by default generate a "nightly" package with a "nightly" version number. if we want to generate a release package we'll need to specify `wf_category` as `RELEASE`. TEST PLAN: runs on remote push. verifying that `wf_category` set to `RELEASE` will generate appropriate package. ran "build" workflow with `wf_category` set to `RELEASE` ... package looks properly named and versioned ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129675592 the "remote push" defaulted to generating a "nightly" package ... please see ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129665988 --------- Co-authored-by: andy-neuma <andy@neuralmagic.com>
andy-neuma
added a commit
that referenced
this pull request
May 17, 2024
SUMMARY: * update GHA action `nm-build-vllm` to not install `nm-magic-wand-nightly` * update build script to not install `nm-magic-wand-nightly` (we might consider getting rid of this script altogether, since we aren't really using it) * remove unused GHA action `nm-test-vllm`. this has been superseded by `nm-install-test-whl` * update GHA action `nm-install-test-whl` to get version of `nm-magic-wand` if `nm-magic-wand-nightly` is not present * update `setup.py` to default generate "nightly" package and add option based on ENV to generate release package. this also includes managing the dependency on `nm-magic-wand`. * update `set-env` action to set ENV based on `wf_category` input * update "release" workflow to include all supported python versions * delete obsolete "gen-whl" NOTES: - "magic-wand" is only a runtime dependency, so no need to install it during build phase. - this PR makes it so that we by default generate a "nightly" package with a "nightly" version number. if we want to generate a release package we'll need to specify `wf_category` as `RELEASE`. TEST PLAN: runs on remote push. verifying that `wf_category` set to `RELEASE` will generate appropriate package. ran "build" workflow with `wf_category` set to `RELEASE` ... package looks properly named and versioned ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129675592 the "remote push" defaulted to generating a "nightly" package ... please see ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129665988 Co-authored-by: andy-neuma <andy@neuralmagic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
nm-build-vllmto not installnm-magic-wand-nightlynm-magic-wand-nightly(we might consider getting rid of this script altogether, since we aren't really using it)nm-test-vllm. this has been superseded bynm-install-test-whlnm-install-test-whlto get version ofnm-magic-wandifnm-magic-wand-nightlyis not presentsetup.pyto default generate "nightly" package and add option based on ENV to generate release package. this also includes managing the dependency onnm-magic-wand.set-envaction to set ENV based onwf_categoryinputNOTES:
wf_categoryasRELEASE.TEST PLAN:
runs on remote push. verifying that
wf_categoryset toRELEASEwill generate appropriate package.ran "build" workflow with
wf_categoryset toRELEASE... package looks properly named and versioned ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129675592the "remote push" defaulted to generating a "nightly" package ... please see ... https://github.com/neuralmagic/nm-vllm/actions/runs/9129665988