Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Reset data.js #137

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

varun-sundar-rabindranath

SUMMARY:
Reset data.js - #136 modifies the datastore making it incompatible with the existing datastore

  • Noteworthy changes:
    • Add benchmark names : This groups the metrics by benchmark-names. The existing version has a flat structure.
    • Shorten metric names : Breaks the "constant metric name" guarantee that the UI uses to match benchmarks between commits
    • Add information to "extra" : This is not a breaking change - Just adds additional information to the "extra" field. This information is very useful for the UI (i.e. lets us filter charts by these values)

TEST PLAN:
No testing

@robertgshaw2-neuralmagic
Copy link
Collaborator

Should we delete or just rename to data-date.js?

@robertgshaw2-neuralmagic
Copy link
Collaborator

Sorry this is such a nit. But for alpha ordering (if we do this over a long period of time), we are going to wish we started date first

Can you switch suffix to 2024_03_18?

Preemtively approving

@varun-sundar-rabindranath
Copy link
Author

updated suffix to 2024_03_18 👍

@varun-sundar-rabindranath varun-sundar-rabindranath merged commit d43a922 into nm-gh-pages Mar 18, 2024
@varun-sundar-rabindranath varun-sundar-rabindranath deleted the varun/nm-gh-pages-reset branch March 18, 2024 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants