This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Fix nightly - 03/18/2024 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-sundar-rabindranath
requested review from
mgoin and
robertgshaw2-neuralmagic
robertgshaw2-neuralmagic
approved these changes
Mar 18, 2024
Merged
varun-sundar-rabindranath
added a commit
that referenced
this pull request
Mar 18, 2024
SUMMARY: Reset data.js - #136 modifies the datastore making it incompatible with the existing datastore - Noteworthy changes: - Add benchmark names : This groups the metrics by benchmark-names. The existing version has a flat structure. - Shorten metric names : Breaks the "constant metric name" guarantee that the UI uses to match benchmarks between commits - Add information to "extra" : This is not a breaking change - Just adds additional information to the "extra" field. This information is very useful for the UI (i.e. lets us filter charts by these values) TEST PLAN: No testing --------- Co-authored-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Miscellaneous changes to fix nightly:
github-action-benchmarkfailure based on previous failuregithub-action-benchmarkdoesn't hit the github comment size thresholdgithub-action-benchmarkJSON that is useful in the UITEST PLAN:
Manual testing