This repository was archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 10
Upstream sync 2024 03 07 #103
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cade Daniel <edacih@gmail.com>
Co-authored-by: zhangdacheng <zhangdacheng@ainirobot.com> Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Tao He <sighingnow@gmail.com>
…ect#3175) Co-authored-by: zixiao <shunli.dsl@alibaba-inc.com>
…on (vllm-project#3176) Co-authored-by: guofangze <guofangze@kuaishou.com>
Co-authored-by: Avnish Narayan <avnish@anyscale.com>
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
…llm-project#2992) Co-authored-by: Roger Wang <136131678+ywang96@users.noreply.github.com>
…lm-project#3123) Co-authored-by: lcskrishna <lollachaitanya@gmail.com>
…ts. (vllm-project#3181) Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
bnellnm
approved these changes
Mar 7, 2024
Author
|
@andy-neuma - Same build failure on upstream vllm - as noted by @mgoin vllm-project#3265 |
bnellnm
reviewed
Mar 7, 2024
Member
bnellnm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should hold off until the setup.py issues are resolved. cc @mgoin @robertgshaw2-neuralmagic
bnellnm
suggested changes
Mar 7, 2024
Member
bnellnm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undoing prior approval until setup.py can be resolved.
Author
|
Wait for upstream to resolve build issues - upstream WIP vllm-project#3266 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
385da2dae2b90e5273da8dfce881727bd9c574a1NOTE:
TEST PLAN:
Tests on this PR