Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Conversation

@varun-sundar-rabindranath

SUMMARY:

  • sync "nm-vllm" fork with upstream as of 2024-03-07 around 4:00 EST -
    385da2dae2b90e5273da8dfce881727bd9c574a1
  • resolved merge conflicts

NOTE:

(vllm-test) varun@ip-192-168-198-190 nm-vllm % git remote -v 
origin	https://github.com/neuralmagic/nm-vllm.git (fetch)
origin	https://github.com/neuralmagic/nm-vllm.git (push)
upstream	https://github.com/vllm-project/vllm.git (fetch)
upstream	https://github.com/vllm-project/vllm.git (push)

TEST PLAN:
Tests on this PR

ronensc and others added 30 commits February 21, 2024 18:18
Co-authored-by: Cade Daniel <edacih@gmail.com>
Co-authored-by: zhangdacheng <zhangdacheng@ainirobot.com>
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Tao He <sighingnow@gmail.com>
pian13131 and others added 18 commits March 4, 2024 09:23
…on (vllm-project#3176)

Co-authored-by: guofangze <guofangze@kuaishou.com>
Co-authored-by: Avnish Narayan <avnish@anyscale.com>
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
…llm-project#2992)

Co-authored-by: Roger Wang <136131678+ywang96@users.noreply.github.com>
)

Co-authored-by: Antoni Baum <antoni.baum@protonmail.com>
@varun-sundar-rabindranath
Copy link
Author

@andy-neuma - Same build failure on upstream vllm - as noted by @mgoin vllm-project#3265

Copy link
Member

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should hold off until the setup.py issues are resolved. cc @mgoin @robertgshaw2-neuralmagic

Copy link
Member

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undoing prior approval until setup.py can be resolved.

@varun-sundar-rabindranath
Copy link
Author

Wait for upstream to resolve build issues - upstream WIP vllm-project#3266

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.