Skip to content

A simple addition of dynamic_ncols=True #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simon-mo merged 2 commits into from
Mar 6, 2024
Merged

A simple addition of dynamic_ncols=True #3242

simon-mo merged 2 commits into from
Mar 6, 2024

Conversation

@chujiezheng
Copy link

@chujiezheng chujiezheng commented Mar 6, 2024 •
edited
Loading

It can be useful when using tmux where the window size may change.

simon-mo
simon-mo approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@simon-mo simon-mo enabled auto-merge (squash) March 6, 2024 21:59
@simon-mo simon-mo disabled auto-merge March 6, 2024 21:59
@simon-mo simon-mo enabled auto-merge (squash) March 6, 2024 21:59
@simon-mo simon-mo merged commit 4cb3b92 into vllm-project:main Mar 6, 2024
dtransposed pushed a commit to afeldman-nm/vllm that referenced this pull request Mar 26, 2024
@chujiezheng
Add tqdm dynamic_ncols=True (vllm-project#3242)
0da6507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chujiezheng @simon-mo