Fix issue if async task count does not evenly divide accross process pool #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markurtz
reviewed
Apr 17, 2025
sjmonson
force-pushed
the
fix/max_concurrency
branch
from
0c28b6a to
be0f52a
Compare
sjmonson
force-pushed
the
fix/max_concurrency
branch
from
be0f52a to
26d59fe
Compare
sjmonson
commented
Apr 18, 2025
sjmonson
force-pushed
the
fix/max_concurrency
branch
from
c6bdb83 to
a691329
Compare
markurtz
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SchedulingStrategy.processing_requests_limitdoes not evenly divide overSchedulingStrategy.processes_limitthen we will either run too few requests or run "0" requests which will cause and unlimited number of request to be scheduled at a time.