This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
fix(deploy): don't hang when there are no files to deploy #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
reviewed
Sep 23, 2020
src/deploy/index.js
Outdated
| phase: 'stop' | ||
| }) | ||
|
|
||
| if (filesCount <= 0 && functionsCount <= 0) { |
There was a problem hiding this comment.
[sand] Since filesCount and functionsCount cannot be negative, would === be clearer than <=?
There was a problem hiding this comment.
That's me being probably too protective with my code.
ehmicky
approved these changes
Sep 23, 2020
erezrokah
force-pushed
the
fix/deploy_hang_when_no_files
branch
from
b2ecf3f
to
20c0b3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Related to netlify/cli#1227.
Going to follow up with a CLI matching PR.
At the moment the deploy command hangs if there are no files to deploy.
This can happen when running
netlify deploy --dir publicon a project with an emptypublicdirectory and nonetlify.tomlfile (see issue above).The state of deploy remains
newso the following code hangs:js-client/src/deploy/util.js
Line 47 in 5565004
- Test plan
Will test this in the CLI repo.
- Description for the changelog
Throw an error when
deployis called and there are no files to deploy (previously hanged).- A picture of a cute animal (not mandatory but encouraged)
🐱