fix(command-deploy): handle deploy error when there are no files to deploy #1274
Conversation
| } catch (e) { | ||
| warn(`Failed canceling deploy with id ${deployId}: ${e.message}`) | ||
| } | ||
| await cancelDeploy({ api, deployId, warn }) |
There was a problem hiding this comment.
We can throw an error and let the calling function cancel the deploy, but we would need lift the spinner handling too.
| @@ -220,6 +222,9 @@ const runDeploy = async ({ | |||
| filter: getDeployFilesFilter({ site, deployFolder }), | |||
| }) | |||
| } catch (e) { | |||
| if (deployId) { | |||
There was a problem hiding this comment.
[sand] Should this be put inside an additional try/catch inner block around deployEdgeHandlers() + api.deploy() instead? Like this, there would be no need to check if deployId exists.
There was a problem hiding this comment.
That would mean we need to re-throw the error after canceling the deploy to reach the other part of the error handling code (we could also refactor that part when we do netlify/js-client#157 to have a dedicated try/catch per operation to have better error reporting).
There was a problem hiding this comment.
Going to merge and release. We can discuss this in netlify/js-client#157
- Summary
Fixes #1227
Dependant on netlify/js-client#161
Handles the error thrown by
js-clientwhen there are no files to deploy (cancels the created deploy).- Test plan
Will push a test once is netlify/js-client#161 merged and published
- Description for the changelog
Handle deploy error when there are no files to deploy
- A picture of a cute animal (not mandatory but encouraged)
🐳