[dev] child process now close properly. #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 14, 2019 19:59
The strings show 'SIGINT' and 'SIGTERM', which are not part of the execa API as far as I can see. These are available on process.on(), which is why they've been switched around.
|
Thanks for the PR @waynevanson. This was a broader issue and has been addressed in the latest release (64d6e67). Please update and provide feedback if it is still a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #653
- Summary
Basically when I'd run
parcel src/index.htmlvianetlify dev -c, pressingCTRL + C(SIGTERM) would not shut down the process.- Test plan
Run netlify dev and cancel it over and over again, even if it doesn't start completely. If it doesnt break, it works.
- Description for the changelog
Child processes now exit when SIGTERM command (
CTRL + C) is issued.- A picture of a cute animal (not mandatory but encouraged)
Have some hot diggity dogs.