Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] pass process.exit() to child processes #653

Closed
waynevanson opened this issue Dec 13, 2019 · 4 comments
Closed

[dev] pass process.exit() to child processes #653

waynevanson opened this issue Dec 13, 2019 · 4 comments

Comments

@waynevanson
Copy link

waynevanson commented Dec 13, 2019

- Do you want to request a feature or report a bug?
Bug

- What is the current behavior?
Pressing CTRL + C after running netlify dev:exec "parcel src/index.html" netlify dev -c parcel src/index.html closes only the netlify server. It should close both, so when I restart the server it can run both again. Instead, I end up with x11 servers running.

edit: I'm using the TOML to set the command, so I changed above to match.

- If the current behavior is a bug, please provide the steps to reproduce.
These are mentioned above.

- What is the expected behavior?
Both servers close when I press CTRL + C on keyboard in terminal

- Local Environment Information

────────────────────┐
 Environment Info   │
────────────────────┘

  System:
    OS: Linux 5.3 Ubuntu 19.10 (Eoan Ermine)
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 13.1.0 - ~/.nvm/versions/node/v13.1.0/bin/node
    Yarn: 1.19.2 - /usr/bin/yarn
    npm: 6.13.0 - ~/.nvm/versions/node/v13.1.0/bin/npm
  Browsers:
    Chrome: 78.0.3904.108

I'd love to write a pull on this.

@RaeesBhatti
Copy link
Contributor

@waynevanson Thanks for reporting this. A PR would be very welcome!

@cco3
Copy link

cco3 commented Jan 15, 2020

This still seems to be a problem when using "--offline --dir"

@cco3
Copy link

cco3 commented Feb 25, 2020

I just tried 2.35.0 and still have a problem when using --dir. No --dir flag works fine now.

@RaeesBhatti Can you confirm that the fix should work with --dir?

@RaeesBhatti
Copy link
Contributor

RaeesBhatti commented Apr 13, 2020

Thank you for your patience. This is no longer a problem. Please upgrade to latest version netlify-cli@2.45.0 and let us know if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants