refactor: enable and fix promise rules #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Mar 16, 2021
| @@ -2,16 +2,16 @@ const middy = require('middy') | |||
| const { jsonBodyParser, validator, httpErrorHandler, httpHeaderNormalizer } = require('middy/middlewares') | |||
|
|
|||
| /* Normal lambda code */ | |||
| const businessLogic = (event, context, callback) => { | |||
| const businessLogic = async (event) => { | |||
There was a problem hiding this comment.
erezrokah
commented
Mar 16, 2021
| @@ -65,6 +65,7 @@ const startServer = async ({ cwd, env = {}, args = [] }) => { | |||
| }) | |||
| } | |||
| }) | |||
| // eslint-disable-next-line promise/prefer-await-to-callbacks | |||
There was a problem hiding this comment.
I'm not sure how to handle this error.
erezrokah
added
the
type: chore
erezrokah
requested review from
eduardoboucas
and removed request for
eduardoboucas
eduardoboucas
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1891
It seems
prefer-await-to-callbacksrelies too much on argument names.