chore: enable lint rules in .eslintrc.js and fix errors

[erezrokah]

We have a bunch of eslint rules disabled in out configuration

cli/.eslintrc.js

Line 8 in f9ec206

'class-methods-use-this': 0,

We should enable those one by one and fix related errors. This is an envelope issue for related PRs.

TODO

• class-methods-use-this
• complexity
• max-depth
• max-lines
• max-lines-per-function
• max-nested-callbacks
• max-statements
• no-param-reassign
• no-process-exit
• fp/no-class
• fp/no-delete
• fp/no-get-set
• fp/no-let
• fp/no-loops
• fp/no-mutating-assign
• fp/no-mutating-methods
• fp/no-mutation
• fp/no-proxy
• fp/no-this
• import/max-dependencies
• node/no-sync
• promise/catch-or-return
• promise/no-callback-in-promise
• promise/no-nesting
• promise/no-return-wrap
• promise/prefer-await-to-callbacks
• promise/prefer-await-to-then
• you-dont-need-lodash-underscore/get
• unicorn/prefer-spread
• unicorn/consistent-destructuring
• unicorn/no-array-push-push
• unicorn/filename-case

[ehmicky]

Related: #1437

[tinfoil-knight]

@erezrokah Can I pick up the first one: class-methods-use-this?

[ehmicky]

@tinfoil-knight Please feel free to pick any of these, including class-methods-use-this. Thanks a lot for your help! ❤️

[tinfoil-knight]

I'm picking up fp/no-loops while class-methods-use-this is under review.