[NAE-1901] Taskref rendering update #203

renczesstefan · 2023-06-13T09:51:36Z

Description

It is now possible to render taskref as list of tasks (aka. taskView).

Implements NAE-1901

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

Depends on #198

How Has Been This Tested?

This was tested manually and with unit tests.

Test Configuration

Name	Tested on
OS	macOS Ventura 13.1
Runtime	Node 14.19.3
Dependency Manager	NPM 6.14.17
Framework version	Angular 13.3.1
Run parameters
Other configuration

Checklist:

- added component resolution to data-field-template.component component

- modified resolveComponentPortal

- added abstract-base-data-field.component.ts - refactored data component attributes - corrected tests

- updated abstract components - modified data-field-template.component.html

- updated filter-data-fields-module

# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html

- modified task content rendering algorithm to keep taskRef in datafields when it is needed - created default component for taskref and update taskref components according to component register - updated data-fields.module.ts -

- fixing tests.

- added default component

- corrected test

- removed unnecessary component resolution - marked unused code as deprecated - implemented resolution for updateOn strategy

- corrected tests

- modified abstract classes according to test

projects/netgrif-components-core/src/lib/data-fields/boolean-field/models/boolean-field.ts

projects/netgrif-components-core/src/lib/data-fields/models/abstract-data-field.spec.ts

...ts/netgrif-components-core/src/lib/data-fields/multichoice-field/models/multichoice-field.ts

projects/netgrif-components-core/src/lib/registry/component-registry.service.ts

...netgrif-components-core/src/lib/task-content/task-content/abstract-task-content.component.ts

projects/netgrif-components/src/lib/data-fields/text-field/public-api.ts

- modified according to PR

minop

could we arrange a meeting to go over the high-level ideas of the changes? Due to the size of the PR, I was unable to fully grasp what is being done and what the ultimate goal of the changes is

minop · 2023-06-15T08:31:22Z

docs/typedoc/components-core/modules.html

are docs/ files supposed to be part of the repository? I thought they were auto-generated

minop · 2023-06-15T08:47:01Z

...rif-components-core/src/lib/data-fields/base-component/abstract-base-data-field.component.ts

+            this.dataField = dataFieldPortalData.dataField;
+            this.formControlRef = dataFieldPortalData.formControlRef;
+            this.showLargeLayout = dataFieldPortalData.showLargeLayout;
+            if (!this.formControlRef) {


formControlRef is guaranteed to always be false, since @Input()s are first set during the OnInit lifecycle hook

I think in this case it is not guaranteed. It is possible, that dataFieldPortalData contains defined formControlRef that is provided through AbstractDataFieldTemplateComponent and AbstractFieldComponentResolver via datafield object.
But you are right it would be better to check whether datafield has registered formcontrol, I will change it.

minop · 2023-06-15T08:48:41Z

...rif-components-core/src/lib/data-fields/base-component/abstract-base-data-field.component.ts

+            if (!this.formControlRef) {
+                this.formControlRef = new FormControl('', {updateOn: this.dataField.getUpdateOnStrategy()});
+            }
+            if (!this.dataField.initialized) {


if the datafield was already initialized and we have created a new FormControl is it a problem?

AS mentioned above, a I changed the check.

minop · 2023-06-15T08:51:45Z

...-fields/boolean-field/boolean-default-field/abstract-boolean-default-field.component.spec.ts

+                            undefined,
+                            undefined,
+                            [{validationRule: 'requiredTrue', validationMessage: 'this is custom message'}]),
+                        formControlRef: new FormControl(),


must a FormControl be set to the field? Is it not more natura for there to be no control yet?

minop · 2023-06-15T08:54:59Z

.../data-fields/boolean-field/boolean-default-field/abstract-boolean-default-field.component.ts

+        return this._translate.instant('dataField.values.boolean.' + this.dataField.value);
+    }
+
+    private resolveErrorMessage(dataField: BooleanField, search: string, generalMessage: string) {


this implementation seems quite generic. Why is it specific only for a boolean field?

This is refactored too in other PR, there it is managed as generic function.

minop · 2023-06-15T13:08:06Z

...ts/src/lib/data-fields/task-ref-field/task-ref-list-field/task-ref-list-field.component.html

@@ -0,0 +1 @@
+<ng-template [cdkPortalOutlet]="componentPortal"></ng-template>


what is the point of this component? Can't the host just display the portal?

minop · 2023-06-15T13:15:16Z

projects/netgrif-components/src/lib/data-fields/text-field/text-field.component.html

-                              [showLargeLayout]="showLargeLayout"></nc-simple-text-field>
-    </div>
-</ng-template>
+<!--<ng-template #textFieldTemplate let-showLargeLayout="showLargeLayout">-->


why leave this in?

minop · 2023-06-15T13:17:16Z

...nents/src/lib/data-fields/user-field/user-default-field/user-default-field.component.spec.ts

+                        editable: true,
+                        hidden: true
+                    }, undefined, []),
+                    formControlRef: new FormControl(),


minop · 2023-06-15T13:18:20Z

...ata-fields/user-list-field/user-list-default-field/user-list-default-field.component.spec.ts

+                            hidden: true
+                        }, undefined,
+                        undefined),
+                    formControlRef: new FormControl(),


minop · 2023-06-15T13:23:07Z

...onents/src/lib/task-content/field-component-resolver/field-component-resolver.component.html

@@ -1,54 +1,4 @@
 <div fxLayout="row" fxLayoutAlign="start center" class="netgrif-input" [ngClass]="{'min-row-height': isField() && !isCustomHeight()}" [ngSwitch]="getElementType()">


can't the ngSwitch be completely replaced with portals?

DataGroup does not have a field implementation and we may want to deprecate the use of them in future resleases. Builder does not supports them neither. A fully portal-based solution would be better, so I decided to replace ngSwitch, and add ngIf for remiaining fields, then if the datagroup solution will be removed, we can remove the div too.

- corrected according to PR

# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html

- revert ngSwitch

- corrected according to tests.

pull-request-quantifier-deprecated · 2023-06-26T07:40:45Z

This PR has 6855 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +4342 -2513
Percentile : 100%

Total files changed: 291

Change summary by file extension:
.html : +433 -551
.ts : +3756 -1829
.scss : +153 -133

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

sonarqubecloud · 2023-06-26T07:45:32Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
4 Security Hotspots
100 Code Smells

33.0% Coverage
1.4% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

dpulls · 2024-02-09T09:44:09Z

🎉 All dependencies have been resolved !

renczesstefan added 8 commits May 18, 2023 14:53

[NAE-1890] Data field component register

d7a0221

- added component resolution to data-field-template.component component

[NAE-1890] Data field component register

ae8ead0

- modified resolveComponentPortal

[NAE-1890] Data field component register

e3d54c6

- added abstract-base-data-field.component.ts - refactored data component attributes - corrected tests

[NAE-1890] Data field component register

bfa7e61

- updated abstract components - modified data-field-template.component.html

[NAE-1890] Data field component register

5809dc9

- updated filter-data-fields-module

[NAE-1890] Data field component register

ec714c8

- updated filter-data-fields-module

Merge branch 'NAE-1890' into NAE-1901

ed936f9

# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html

[NAE-1901] Taskref rendering update

aac3f8f

- modified task content rendering algorithm to keep taskRef in datafields when it is needed - created default component for taskref and update taskref components according to component register - updated data-fields.module.ts -

renczesstefan added improvement New feature or request Medium labels Jun 13, 2023

renczesstefan requested review from tuplle, minop, Kovy95, machacjozef and mazarijuraj June 13, 2023 09:51

renczesstefan self-assigned this Jun 13, 2023

pull-request-quantifier-deprecated bot added Extra Large and removed Medium labels Jun 13, 2023

renczesstefan added 8 commits June 13, 2023 15:37

[NAE-1901] Taskref rendering update

fe09d23

- fixing tests.

[NAE-1901] Taskref rendering update

655f8cb

- added default component

[NAE-1901] Taskref rendering update

75b1616

- corrected test

[NAE-1890] Frontend component register

a1169be

- corrected test

[NAE-1890] Frontend component register

badb563

- removed unnecessary component resolution - marked unused code as deprecated - implemented resolution for updateOn strategy

[NAE-1890] Frontend component register

21e6d31

- corrected tests

Merge branch 'NAE-1890' into NAE-1901

90ca20f

[NAE-1890] Frontend component register

980a6f4

- modified abstract classes according to test

Kovy95 requested changes Jun 15, 2023

View reviewed changes

[NAE-1901] Tasref rendering update

d556f34

- modified according to PR

minop requested changes Jun 15, 2023

View reviewed changes

Kovy95 previously approved these changes Jun 15, 2023

View reviewed changes

renczesstefan requested a review from minop June 16, 2023 08:33

[NAE-1901] Tasref rendering update

db44d0b

- corrected according to PR

renczesstefan dismissed Kovy95’s stale review via db44d0b June 16, 2023 08:41

renczesstefan added 2 commits June 16, 2023 10:44

Merge branch 'release/6.4.0' into NAE-1890

20bb8d5

# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html

Merge branch 'NAE-1890' into NAE-1901

3720c19

# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html

Kovy95 mentioned this pull request Jun 21, 2023

[NAE-1900] New component design #204

Merged

18 tasks

renczesstefan added 2 commits June 26, 2023 07:39

[NAE-1901] Tasref rendering update

147e06c

- revert ngSwitch

[NAE-1901] Tasref rendering update

0bf1106

- corrected according to tests.

machacjozef merged commit 34f310f into release/6.4.0 Feb 9, 2024

		@@ -0,0 +1 @@
		<ng-template [cdkPortalOutlet]="componentPortal"></ng-template>

		@@ -1,54 +1,4 @@
		<div fxLayout="row" fxLayoutAlign="start center" class="netgrif-input" [ngClass]="{'min-row-height': isField() && !isCustomHeight()}" [ngSwitch]="getElementType()">

[NAE-1901] Taskref rendering update #203

[NAE-1901] Taskref rendering update #203

Uh oh!

Conversation

renczesstefan commented Jun 13, 2023 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Third party dependencies

Blocking Pull requests

How Has Been This Tested?

Test Configuration

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

minop left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated bot commented Jun 26, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

sonarqubecloud bot commented Jun 26, 2023

Uh oh!

dpulls bot commented Feb 9, 2024

Uh oh!

Uh oh!

renczesstefan commented Jun 13, 2023 •

edited by atlassian bot

Loading