-
Notifications
You must be signed in to change notification settings - Fork 4
[NAE-1890] Data field component register #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- added component resolution to data-field-template.component component
- modified resolveComponentPortal
- added abstract-base-data-field.component.ts - refactored data component attributes - corrected tests
- updated abstract components - modified data-field-template.component.html
- updated filter-data-fields-module
- updated filter-data-fields-module
The merge-base changed after approval.
- corrected test
- removed unnecessary component resolution - marked unused code as deprecated - implemented resolution for updateOn strategy
- corrected tests
# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SonarCloud Quality Gate failed. |
Description
Implemented component resolving through portal.
Implements NAE-1890
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
THis was tested manually and with unit tests.
Test Configuration
Checklist: