Skip to content

Conversation

renczesstefan
Copy link
Member

@renczesstefan renczesstefan commented May 19, 2023

Description

Implemented component resolving through portal.

Implements NAE-1890

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

THis was tested manually and with unit tests.

Test Configuration

Name Tested on
OS macOS Ventura 13.1
Runtime Node 14.19.3
Dependency Manager NPM 6.14.17
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

- added component resolution to data-field-template.component component
- modified resolveComponentPortal
- added abstract-base-data-field.component.ts
- refactored data component attributes
- corrected tests
- updated abstract components
- modified data-field-template.component.html
- updated filter-data-fields-module
- updated filter-data-fields-module
@renczesstefan renczesstefan mentioned this pull request Jun 2, 2023
18 tasks
mazarijuraj
mazarijuraj previously approved these changes Jun 5, 2023
@renczesstefan renczesstefan dismissed mazarijuraj’s stale review June 9, 2023 07:41

The merge-base changed after approval.

- removed unnecessary component resolution
- marked unused code as deprecated
- implemented resolution for updateOn strategy
# Conflicts:
#	docs/compodoc/components/js/search/search_index.js
#	docs/typedoc/components-core/modules.html
@pull-request-quantifier-deprecated

This PR has 6247 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +3906 -2341
Percentile : 100%

Total files changed: 269

Change summary by file extension:
.html : +406 -534
.ts : +3377 -1688
.scss : +123 -119

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 93 Code Smells

33.1% 33.1% Coverage
1.6% 1.6% Duplication

@machacjozef machacjozef merged commit 3720c19 into release/6.4.0 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants