Skip to content

fixes #16647: navigation contrast issues updated #16750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fixes #16647: navigation contrast issues updated #16750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netbox/project-static/dist/netbox.css
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 10 additions & 0 deletions netbox/project-static/styles/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,13 @@ $hover-bg: rgba(var(--tblr-secondary-rgb), 0.08);

// Ensure active nav-pill has a background color in dark mode
$nav-pills-link-active-bg: rgba(var(--tblr-secondary-rgb), 0.15);

// Colors
$rich-black: #001423;
$rich-black-light: #081B2A;
$rich-black-lighter: #0D202E;
$rich-black-lightest: #1A2C39;
$bright-teal: #00F2D4;
$dark-teal: #00857D;

$primary: $dark-teal;
48 changes: 46 additions & 2 deletions netbox/project-static/styles/overrides/_tabler.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,55 @@ pre {
}

table a {
// Adjust table anchor link contrast as not enough contrast in dark mode
filter: brightness(110%);
color: $dark-teal;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we can remove this section; the link color should already be set to $dark-teal.

}

// Override background color alpha value
[data-bs-theme=dark] ::selection {
background-color: rgba(var(--tblr-primary-rgb),.48)
}

// Side navigation
.navbar-vertical {
background-color: $rich-black;
.dropdown-item {
color: white!important;
}
.text-secondary {
color: $gray-400!important;
}
}
Comment on lines +47 to +56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these to transitional/_navigation.scss just to keep all these tweaks in one place.


// Dark mode colors
@if $enable-dark-mode {
@include color-mode(dark, true) {
--#{$prefix}link-color: #{$bright-teal};
--#{$prefix}secondary: #{$gray-400};
}
}

// Dark mode overrides
body[data-bs-theme=dark] {

// Background colors to match brand colors
background-color: $rich-black;
.navbar, .page-header {
background-color: $rich-black;
}
.page, .page-tabs .nav-tabs .nav-link.active {
background-color: $rich-black-light;
}

// Adjust dark table link color without affecting buttons and badges
table {
a {
color: $bright-teal;
}
.badge a {
color: inherit;
}
.btn {
color: var(--#{$prefix}body-color);
}
}
}