fixes #16647: navigation contrast issues updated #16750
Conversation
There was a problem hiding this comment.
Thanks @andrewgormley!
I have one minor concern regarding the submenu headings in the navigation menu: At first glance it feels difficult to distinguish the headings from the link items as they're very similar in color.
This is actually something I struggled with during the initial UI overhaul in v4.0. Any suggestions for making them stand out a bit? Maybe we could color them teal?
| @@ -36,11 +36,55 @@ pre { | |||
| } | |||
|
|
|||
| table a { | |||
| // Adjust table anchor link contrast as not enough contrast in dark mode | |||
| filter: brightness(110%); | |||
| color: $dark-teal; | |||
There was a problem hiding this comment.
I'm pretty sure we can remove this section; the link color should already be set to $dark-teal.
| // Side navigation | ||
| .navbar-vertical { | ||
| background-color: $rich-black; | ||
| .dropdown-item { | ||
| color: white!important; | ||
| } | ||
| .text-secondary { | ||
| color: $gray-400!important; | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's move these to transitional/_navigation.scss just to keep all these tweaks in one place.
|
Closing this in favor of PR #16759, which includes all the changes herein. |
Fixes: #16647
PR fixes issues outlined in #16647
The above also required new color variables to be added in-line with the new brand guidelines. Please be aware that I have changed the primary color in keeping with the new colors which was required by one of the tasks above, this has affected other parts of the UI but everything looks as expected.