Add support for IPv6 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruelea
force-pushed
the
feature/support-ipv6-reservation
branch
from
0d22757 to
eaa8366
Compare
henrybear327
requested review from
alexandernorth,
henrybear327 and
jstudler
henrybear327
requested changes
Sep 24, 2024
henrybear327
force-pushed
the
feature/support-ipv6-reservation
branch
from
3c85251 to
4d448c3
Compare
henrybear327
force-pushed
the
feature/support-ipv6-reservation
branch
2 times, most recently
from
3943f8d to
9ff1212
Compare
henrybear327
requested changes
Sep 27, 2024
bruelea
force-pushed
the
feature/support-ipv6-reservation
branch
2 times, most recently
from
a7a2764 to
81fbe16
Compare
Thanks, for the feedback! @henrybear327. I edited the code accordingly and changed the error handling in the claim controllers to requeue the object if the assignment fails and not returning an error. |
henrybear327
requested changes
Sep 27, 2024
There was a problem hiding this comment.
2 small tweaks! Thanks for addressing the comments @bruelea!
henrybear327
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
LGTM! :) Thanks @bruelea
(and nice catch on the spelling error :D)
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
bruelea
force-pushed
the
feature/support-ipv6-reservation
branch
from
26f3cc1 to
eea770e
Compare
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
bruelea
force-pushed
the
feature/support-ipv6-reservation
branch
from
eea770e to
593568c
Compare
henrybear327
approved these changes
Sep 30, 2024
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
* add support for IPv6 * fix prefixLength validation pattern * apply suggestions and improve error handing in controller * remove comment for completed TODO Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com> * fix typo * use IPv4Family constant in test Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com> * fix test after rebase --------- Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: