- 
                Notifications
    You must be signed in to change notification settings 
- Fork 12
Fix CRD group name not following conventions #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Note: merge only after  | 
5d84484    to
    0b7be53      
    Compare
  
    | Why netboxlabs.com and not netbox.dev? NetBox Labs is the company and not the community, this project is hosted on the community. | 
| 
 @jstudler, the netbox.dev domain is not mentioned when looking at the github, but only netboxlabs.com. Also @rboucher-me mentioned this would be their preference when asked. Those were the 2 main reasons. | 
| We will make another release after this is merged, as this is a breaking change | 
0b7be53    to
    9a2cd1f      
    Compare
  
    | After some discussions on Slack, we decided that we would prefer to stick with the  The main reasons are 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @faebr
| @faebr please resolve the rebase conflict :( Thanks! | 
eea770e    to
    593568c      
    Compare
  
    New discussion requiring new changes
| @MaIT-HgA do you want to rebase this PR and make it ready for merging :) | 
…/domain occurences to be consistent with a fesh kubebuilder project
8e1d5a2    to
    a206a4e      
    Compare
  
    | 
 done :) | 
| Thanks @MaIT-HgA for rebasing it! As discussed during the meeting, we have decided to postpone the merging of this PR, as this would require migration to be done for the existing CRs and it's currently de-scoped from our development sprint. | 
| This PR will be closed, an easier solution has been found. We will remove the crd group from the PROJECT file and thus the already created crd's are alligned again. New crd's can be added without a group or inside a new group after enabling multi-group support in the said file. | 
Uh oh!
There was an error while loading. Please reload this page.