Skip to content

Add Claude provider selector and Bedrock - #691

Merged
braginini merged 2 commits into
mainfrom
feature/improve-agent-config-claude-layout
Jun 30, 2026
Merged

Add Claude provider selector and Bedrock#691
braginini merged 2 commits into
mainfrom
feature/improve-agent-config-claude-layout

Conversation

@braginini

@braginini braginini commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Issue ticket number and link

Screenshot 2026-06-29 at 19 12 24

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

netbirdio/docs#819

E2E tests

Optional: override the image tags used by the Playwright e2e workflow.
Defaults to main when omitted.

management-cloud-tag: main
reverse-proxy-tag: main

Summary by CodeRabbit

  • New Features
    • Added an in-tab provider selector to the Claude Code setup flow (Anthropic, Vertex AI, and Bedrock).
    • Updated Claude Code setup instructions to render dynamically based on the selected provider.
  • Bug Fixes
    • Updated the agent network providers “Learn more” link to point to the current documentation site.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a860453-4ea6-4a2d-8be4-f386a5070f3d

📥 Commits

Reviewing files that changed from the base of the PR and between 43bfed2 and 7c43ea6.

📒 Files selected for processing (1)
  • src/modules/agent-network/AgentConnectModal.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/modules/agent-network/AgentConnectModal.tsx

📝 Walkthrough

Walkthrough

The Providers page “Learn more” link now points to the NetBird documentation URL. The Claude Code tab in AgentConnectModal now uses an in-tab provider selector for Anthropic, Vertex AI, and Bedrock, with provider-specific snippets and no separate Vertex AI tab.

Changes

Agent Network UI Updates

Layer / File(s) Summary
Providers page doc link update
src/app/(dashboard)/agent-network/providers/page.tsx
Changes the “Learn more” InlineLink href from the demo domain to the NetBird docs URL.
Claude Code in-tab provider selector
src/modules/agent-network/AgentConnectModal.tsx
Adds SelectDropdown; introduces claudeProvider state for "anthropic", "vertex", and "bedrock"; renders provider-specific Claude snippets inside the claude-code tab; removes the separate claude-code-vertex tab and its content block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • netbirdio/dashboard#688: Updates the same AgentConnectModal.tsx Claude Code flow with Vertex AI-specific tab/snippet behavior.

Suggested reviewers

  • mlsmaycon
  • heisbrot

Poem

🐇 I hopped to docs and found the way,
A dropdown now picks clouds to stay.
Anthropic, Vertex, Bedrock too,
The Claude tab sparkles brand new.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change by calling out the new Claude provider selector and Bedrock support.
Description check ✅ Passed The description mostly follows the template and includes docs and E2E sections, but it lacks an actual issue ticket number/link.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/improve-agent-config-claude-layout

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/modules/agent-network/AgentConnectModal.tsx

Oops! Something went wrong! :(

ESLint: 9.39.3

TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Object'
| property 'configs' -> object with constructor 'Object'
| property 'flat' -> object with constructor 'Object'
| ...
| property 'plugins' -> object with constructor 'Object'
--- property 'react' closes the circle
Referenced from: /.eslintrc.json
at JSON.stringify ()
at /node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2255:45
at Array.map ()
at ConfigValidator.formatErrors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2246:23)
at ConfigValidator.validateConfigSchema (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2277:84)
at ConfigArrayFactory._normalizeConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3123:19)
at ConfigArrayFactory._loadConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3088:21)
at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3393:21)
at ConfigArrayFactory._loadExtends (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3261:25)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3199:25)
(node:2) ESLintRCWarning: You are using an eslintrc configuration file, which is deprecated and support will be removed in v10.0.0. Please migrate to an eslint.config.js file. See https://eslint.org/docs/latest/use/configure/migration-guide for details. An eslintrc configuration file is used because you have the ESLINT_USE_FLAT_CONFIG environment variable set to false. If you want to use an eslint.config.js file, remove the environment variable. If you want to find the location of the eslintrc configuration file, use the --debug flag.
(Use node --trace-warnings ... to show where the warning was created)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/modules/agent-network/AgentConnectModal.tsx`:
- Around line 164-173: The Bedrock config snippet in AgentConnectModal hardcodes
a specific ANTHROPIC_MODEL value, which can mislead users whose account or
region uses a different model ID. Update the Snippet content in the
claudeProvider === "bedrock" branch to use a placeholder, or thread the selected
model into AgentConnectModal and interpolate that value instead of the fixed
string. Keep the rest of the Bedrock settings unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7cd8583-aa09-4384-89c5-4b63176f8d7f

📥 Commits

Reviewing files that changed from the base of the PR and between 19ad8d6 and 43bfed2.

📒 Files selected for processing (2)
  • src/app/(dashboard)/agent-network/providers/page.tsx
  • src/modules/agent-network/AgentConnectModal.tsx

Comment thread src/modules/agent-network/AgentConnectModal.tsx
@braginini
braginini merged commit 9230b3e into main Jun 30, 2026
8 checks passed
@braginini
braginini deleted the feature/improve-agent-config-claude-layout branch June 30, 2026 09:50
JuliusFreudenberger pushed a commit to JuliusFreudenberger/nix-config that referenced this pull request Jul 2, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [netbirdio/dashboard](https://github.com/netbirdio/dashboard) | minor | `v2.39.0` → `v2.90.3` |
| netbirdio/netbird | minor | `v0.73.2-rootless` → `v0.74.1-rootless` |
| netbirdio/netbird-server | minor | `0.73.2` → `0.74.1` |
| netbirdio/reverse-proxy | minor | `0.73.2` → `0.74.1` |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/12) for more information.

---

### Release Notes

<details>
<summary>netbirdio/dashboard (netbirdio/dashboard)</summary>

### [`v2.90.3`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.3)

[Compare Source](netbirdio/dashboard@v2.90.2...v2.90.3)

#### What's Changed

- Show reason for peer login expiration events by [@&#8203;bcmmbaga](https://github.com/bcmmbaga) in [#&#8203;694](netbirdio/dashboard#694)
- Reload nginx after patching CSP header by [@&#8203;pappz](https://github.com/pappz) in [#&#8203;687](netbirdio/dashboard#687)
- Fix peer table page reset when switching kind by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;696](netbirdio/dashboard#696)
- Feature/add provider session by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;695](netbirdio/dashboard#695)
- Add Metrics settings tab with metrics push toggle by [@&#8203;pappz](https://github.com/pappz) in [#&#8203;613](netbirdio/dashboard#613)
- Feature/add skip tls verification by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;697](netbirdio/dashboard#697)

**Full Changelog**: <netbirdio/dashboard@v2.90.2...v2.90.3>

### [`v2.90.2`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.2)

[Compare Source](netbirdio/dashboard@v2.90.1...v2.90.2)

#### What's Changed

- Add Claude provider selector and Bedrock by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;691](netbirdio/dashboard#691)
- Prevent gated useFetchApi hooks from overwriting shared cache entries by [@&#8203;bcmmbaga](https://github.com/bcmmbaga) in [#&#8203;692](netbirdio/dashboard#692)

**Full Changelog**: <netbirdio/dashboard@v2.90.1...v2.90.2>

### [`v2.90.1`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.1)

[Compare Source](netbirdio/dashboard@v2.90.0...v2.90.1)

#### What's Changed

- The empty-state peer card now renders AddPeerDropdown by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;686](netbirdio/dashboard#686)
- Support Vertex keyfile upload and agent config by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;688](netbirdio/dashboard#688)
- Prefill Vertex endpoint by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;689](netbirdio/dashboard#689)

**Full Changelog**: <netbirdio/dashboard@v2.90.0...v2.90.1>

### [`v2.90.0`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.0)

[Compare Source](netbirdio/dashboard@v2.80.0...v2.90.0)

#### What's Changed

- Fix CSP blocking OIDC token endpoint by [@&#8203;maxbrc](https://github.com/maxbrc) in [#&#8203;680](netbirdio/dashboard#680)
- Agent Network by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;684](netbirdio/dashboard#684)

#### New Contributors

- [@&#8203;maxbrc](https://github.com/maxbrc) made their first contribution in [#&#8203;680](netbirdio/dashboard#680)

**Full Changelog**: <netbirdio/dashboard@v2.80.0...v2.90.0>

### [`v2.80.0`](https://github.com/netbirdio/dashboard/releases/tag/v2.80.0)

[Compare Source](netbirdio/dashboard@v2.39.0...v2.80.0)

#### What's Changed

- Add Logout URL to the Identity Provider dialog by [@&#8203;TechHutTV](https://github.com/TechHutTV) in [#&#8203;657](netbirdio/dashboard#657)
- Edit banner to IPv6 kh link by [@&#8203;TechHutTV](https://github.com/TechHutTV) in [#&#8203;662](netbirdio/dashboard#662)
- Insert link to remote jobs documentation by [@&#8203;semp26](https://github.com/semp26) in [#&#8203;664](netbirdio/dashboard#664)
- DNS Zones & Setup modal improvements by [@&#8203;braginini](https://github.com/braginini) in [#&#8203;669](netbirdio/dashboard#669)
- Update banner by [@&#8203;heisbrot](https://github.com/heisbrot) in [#&#8203;672](netbirdio/dashboard#672)
- Update announcements.json by [@&#8203;mlsmaycon](https://github.com/mlsmaycon) in [#&#8203;673](netbirdio/dashboard#673)
- Merge NetBird cloud edition into the dashboard by [@&#8203;mlsmaycon](https://github.com/mlsmaycon) in [#&#8203;674](netbirdio/dashboard#674)
- Restrict cloud/licensed-only API calls in open-source mode by [@&#8203;mlsmaycon](https://github.com/mlsmaycon) in [#&#8203;675](netbirdio/dashboard#675)
- Preserve inactivity expiration on partial peer updates by [@&#8203;bcmmbaga](https://github.com/bcmmbaga) in [#&#8203;676](netbirdio/dashboard#676)

#### New Contributors

- [@&#8203;TechHutTV](https://github.com/TechHutTV) made their first contribution in [#&#8203;657](netbirdio/dashboard#657)
- [@&#8203;semp26](https://github.com/semp26) made their first contribution in [#&#8203;664](netbirdio/dashboard#664)

**Full Changelog**: <netbirdio/dashboard@v2.39.0...v2.80.0>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.jfreudenberger.de/JuliusFreudenberger/nix-config/pulls/10
Co-authored-by: Renovate Bot <renovate@jfreudenberger.de>
Co-committed-by: Renovate Bot <renovate@jfreudenberger.de>
ocoj pushed a commit to ocoj/dashboard that referenced this pull request Jul 17, 2026
ocoj pushed a commit to ocoj/dashboard that referenced this pull request Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants