Fix CSP blocking OIDC token endpoint - #680
Conversation
📝 WalkthroughWalkthroughThe ChangesCSP Origin Extraction Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/init_react_envs.sh`:
- Around line 94-95: The AUTH_AUTHORITY_ORIGIN derivation in init_react_envs.sh
only strips path segments, so query strings and fragments can leak into the CSP
list. Update the AUTH_AUTHORITY_ORIGIN extraction logic to normalize
AUTH_AUTHORITY to a true origin by removing any trailing ?query or `#fragment` as
well as any path, then keep appending it to CSP_DOMAINS. Use the existing
AUTH_AUTHORITY_ORIGIN and CSP_DOMAINS variables in the shell block to locate the
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 58dd68b0-345c-4e99-a843-9476fc2bbba2
📒 Files selected for processing (1)
docker/init_react_envs.sh
|
Hey @maxbrc thanks for the contribution! |
|
Thanks @jnfrati! Fixed the failing check (docs checkbox in the template). CodeRabbit had a point but it was out of scope, it's resolved. |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [netbirdio/dashboard](https://github.com/netbirdio/dashboard) | minor | `v2.39.0` → `v2.90.3` | | netbirdio/netbird | minor | `v0.73.2-rootless` → `v0.74.1-rootless` | | netbirdio/netbird-server | minor | `0.73.2` → `0.74.1` | | netbirdio/reverse-proxy | minor | `0.73.2` → `0.74.1` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/12) for more information. --- ### Release Notes <details> <summary>netbirdio/dashboard (netbirdio/dashboard)</summary> ### [`v2.90.3`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.3) [Compare Source](netbirdio/dashboard@v2.90.2...v2.90.3) #### What's Changed - Show reason for peer login expiration events by [@​bcmmbaga](https://github.com/bcmmbaga) in [#​694](netbirdio/dashboard#694) - Reload nginx after patching CSP header by [@​pappz](https://github.com/pappz) in [#​687](netbirdio/dashboard#687) - Fix peer table page reset when switching kind by [@​braginini](https://github.com/braginini) in [#​696](netbirdio/dashboard#696) - Feature/add provider session by [@​braginini](https://github.com/braginini) in [#​695](netbirdio/dashboard#695) - Add Metrics settings tab with metrics push toggle by [@​pappz](https://github.com/pappz) in [#​613](netbirdio/dashboard#613) - Feature/add skip tls verification by [@​braginini](https://github.com/braginini) in [#​697](netbirdio/dashboard#697) **Full Changelog**: <netbirdio/dashboard@v2.90.2...v2.90.3> ### [`v2.90.2`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.2) [Compare Source](netbirdio/dashboard@v2.90.1...v2.90.2) #### What's Changed - Add Claude provider selector and Bedrock by [@​braginini](https://github.com/braginini) in [#​691](netbirdio/dashboard#691) - Prevent gated useFetchApi hooks from overwriting shared cache entries by [@​bcmmbaga](https://github.com/bcmmbaga) in [#​692](netbirdio/dashboard#692) **Full Changelog**: <netbirdio/dashboard@v2.90.1...v2.90.2> ### [`v2.90.1`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.1) [Compare Source](netbirdio/dashboard@v2.90.0...v2.90.1) #### What's Changed - The empty-state peer card now renders AddPeerDropdown by [@​braginini](https://github.com/braginini) in [#​686](netbirdio/dashboard#686) - Support Vertex keyfile upload and agent config by [@​braginini](https://github.com/braginini) in [#​688](netbirdio/dashboard#688) - Prefill Vertex endpoint by [@​braginini](https://github.com/braginini) in [#​689](netbirdio/dashboard#689) **Full Changelog**: <netbirdio/dashboard@v2.90.0...v2.90.1> ### [`v2.90.0`](https://github.com/netbirdio/dashboard/releases/tag/v2.90.0) [Compare Source](netbirdio/dashboard@v2.80.0...v2.90.0) #### What's Changed - Fix CSP blocking OIDC token endpoint by [@​maxbrc](https://github.com/maxbrc) in [#​680](netbirdio/dashboard#680) - Agent Network by [@​braginini](https://github.com/braginini) in [#​684](netbirdio/dashboard#684) #### New Contributors - [@​maxbrc](https://github.com/maxbrc) made their first contribution in [#​680](netbirdio/dashboard#680) **Full Changelog**: <netbirdio/dashboard@v2.80.0...v2.90.0> ### [`v2.80.0`](https://github.com/netbirdio/dashboard/releases/tag/v2.80.0) [Compare Source](netbirdio/dashboard@v2.39.0...v2.80.0) #### What's Changed - Add Logout URL to the Identity Provider dialog by [@​TechHutTV](https://github.com/TechHutTV) in [#​657](netbirdio/dashboard#657) - Edit banner to IPv6 kh link by [@​TechHutTV](https://github.com/TechHutTV) in [#​662](netbirdio/dashboard#662) - Insert link to remote jobs documentation by [@​semp26](https://github.com/semp26) in [#​664](netbirdio/dashboard#664) - DNS Zones & Setup modal improvements by [@​braginini](https://github.com/braginini) in [#​669](netbirdio/dashboard#669) - Update banner by [@​heisbrot](https://github.com/heisbrot) in [#​672](netbirdio/dashboard#672) - Update announcements.json by [@​mlsmaycon](https://github.com/mlsmaycon) in [#​673](netbirdio/dashboard#673) - Merge NetBird cloud edition into the dashboard by [@​mlsmaycon](https://github.com/mlsmaycon) in [#​674](netbirdio/dashboard#674) - Restrict cloud/licensed-only API calls in open-source mode by [@​mlsmaycon](https://github.com/mlsmaycon) in [#​675](netbirdio/dashboard#675) - Preserve inactivity expiration on partial peer updates by [@​bcmmbaga](https://github.com/bcmmbaga) in [#​676](netbirdio/dashboard#676) #### New Contributors - [@​TechHutTV](https://github.com/TechHutTV) made their first contribution in [#​657](netbirdio/dashboard#657) - [@​semp26](https://github.com/semp26) made their first contribution in [#​664](netbirdio/dashboard#664) **Full Changelog**: <netbirdio/dashboard@v2.39.0...v2.80.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.jfreudenberger.de/JuliusFreudenberger/nix-config/pulls/10 Co-authored-by: Renovate Bot <renovate@jfreudenberger.de> Co-committed-by: Renovate Bot <renovate@jfreudenberger.de>
Calculate the origin URL for AUTH_AUTHORITY and add it to CSP_DOMAINS.
Fixes #679
Documentation
Summary by CodeRabbit