Feat: make errors more helpful #1263
Conversation
WalkthroughAdds an entrypoint checks directory, many new entrypoint.d health/permission/mount-check scripts (including a Python mount analyzer), updates entrypoint orchestration to run those checks and continue on failures, removes several legacy service scripts, updates Dockerfiles to include the checks path and adjust permissions, and adds extensive Docker troubleshooting docs and compose test fixtures. Changes
Sequence Diagram(s)sequenceDiagram
participant C as Container Init
participant E as entrypoint.sh
participant EC as ${ENTRYPOINT_CHECKS}/*
participant M as 10-mounts.py
participant A as Application
C->>E: start
E->>E: render banner
loop each script in ${ENTRYPOINT_CHECKS}
E->>EC: exec script (executable)
EC-->>E: output + exit code
E->>E: log result (continue even on failure)
end
alt 10-mounts.py reports write errors and NETALERTX_DEBUG != "1"
EC->>E: prints table & warnings
E->>C: propagate non-zero exit (entrypoint behavior may stop)
else
E->>A: proceed to start application
end
sequenceDiagram
participant P as 10-mounts.py
participant V as Env vars
participant F as /proc/mounts
participant O as stderr/table
P->>V: read PATHS_TO_CHECK and flags
P->>F: parse mounted filesystems
loop per path
P->>V: resolve path value
P->>F: match mount point & fstype
P->>P: evaluate writeable/mounted/ramdisk & risk flags
end
P->>O: print diagnostic table
alt write errors and NETALERTX_DEBUG != "1"
P->>O: print warnings
P->>P: exit(1)
else
P->>P: exit(0)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Focus areas for review:
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (9)📓 Common learnings📚 Learning: 2025-09-20T03:01:19.912ZApplied to files:
📚 Learning: 2025-10-19T15:29:49.532ZApplied to files:
📚 Learning: 2025-09-20T02:56:24.501ZApplied to files:
📚 Learning: 2025-10-19T01:40:57.095ZApplied to files:
📚 Learning: 2025-09-20T14:08:44.152ZApplied to files:
📚 Learning: 2025-10-26T17:09:18.621ZApplied to files:
📚 Learning: 2025-09-20T14:09:29.159ZApplied to files:
📚 Learning: 2025-10-26T17:12:30.237ZApplied to files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 17
🧹 Nitpick comments (3)
test/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_mounted.yml (1)
44-52: Unused volume declarations reduce clarity.Lines 44-52 declare 8 named volumes, but only 3 are actually referenced in the service (netalertx_db, netalertx_config, test_system_services_active_config). The others (test_netalertx_db, test_netalertx_config, test_netalertx_api, test_netalertx_log, test_system_services_run) appear unused.
Consider removing unused declarations or adding comments explaining their purpose. If they're shared across multiple test configurations, consolidating them into a separate compose file or clarifying their intent would improve maintainability.
test/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_ramdisk.yml (1)
41-49: Duplicate unused volume declarations.This file repeats the same unused volume declarations from the previous mount-test configuration (8 declared, only 3 referenced in netalertx_db, netalertx_config, and test_system_services_run).
Consider consolidating these common volume declarations into a shared base or compose fragment to reduce duplication across test configurations.
test/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.yml (1)
40-48: Unused volume declarations reduce clarity (consistent pattern).This file repeats the same 8 unused volume declarations from previous test configurations. Only 3 are actually referenced (netalertx_db, netalertx_config, test_netalertx_api).
Consolidate these common declarations across all mount-test configurations into a shared compose fragment or base file to improve maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
test/docker_tests/configurations/test_results.logis excluded by!**/*.log
📒 Files selected for processing (64)
.devcontainer/Dockerfile(3 hunks)Dockerfile(3 hunks)docs/docker-troubleshooting/excessive-capabilities.md(1 hunks)docs/docker-troubleshooting/file-permissions.md(1 hunks)docs/docker-troubleshooting/incorrect-user.md(1 hunks)docs/docker-troubleshooting/missing-capabilities.md(1 hunks)docs/docker-troubleshooting/mount-configuration-issues.md(1 hunks)docs/docker-troubleshooting/network-mode.md(1 hunks)docs/docker-troubleshooting/nginx-configuration-mount.md(1 hunks)docs/docker-troubleshooting/port-conflicts.md(1 hunks)docs/docker-troubleshooting/read-only-filesystem.md(1 hunks)docs/docker-troubleshooting/running-as-root.md(1 hunks)install/production-filesystem/entrypoint.d/0-storage-permission.sh(1 hunks)install/production-filesystem/entrypoint.d/10-mounts.py(1 hunks)install/production-filesystem/entrypoint.d/15-first-run-config.sh(1 hunks)install/production-filesystem/entrypoint.d/20-first-run-db.sh(2 hunks)install/production-filesystem/entrypoint.d/30-writable-config.sh(1 hunks)install/production-filesystem/entrypoint.d/35-nginx-config.sh(3 hunks)install/production-filesystem/entrypoint.d/60-user-netalertx.sh(1 hunks)install/production-filesystem/entrypoint.d/80-host-mode-network.sh(3 hunks)install/production-filesystem/entrypoint.d/85-layer-2-capabilities.sh(2 hunks)install/production-filesystem/entrypoint.d/90-excessive-capabilities.sh(1 hunks)install/production-filesystem/entrypoint.d/95-appliance-integrity.sh(1 hunks)install/production-filesystem/entrypoint.d/99-ports-available.sh(1 hunks)install/production-filesystem/entrypoint.sh(1 hunks)install/production-filesystem/services/scripts/check-app-permissions.sh(0 hunks)install/production-filesystem/services/scripts/check-nonpersistent-storage.sh(0 hunks)install/production-filesystem/services/scripts/check-persistent-storage.sh(0 hunks)install/production-filesystem/services/scripts/check-ramdisk.sh(0 hunks)install/production-filesystem/services/scripts/check-root.sh(0 hunks)test/docker_tests/configurations/README.md(1 hunks)test/docker_tests/configurations/docker-compose.missing-caps.yml(1 hunks)test/docker_tests/configurations/docker-compose.readonly.yml(1 hunks)test/docker_tests/configurations/docker-compose.writable.yml(1 hunks)test/docker_tests/configurations/mount-tests/README.md(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_mounted.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_no-mount.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_ramdisk.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_unwritable.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_ramdisk.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_unwritable.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_ramdisk.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_unwritable.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_no-mount.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_ramdisk.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_unwritable.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_mounted.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_ramdisk.yml(1 hunks)test/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_unwritable.yml(1 hunks)test/docker_tests/configurations/test_all_docker_composes.sh(1 hunks)test/docker_tests/test_container_environment.py(10 hunks)test/docker_tests/test_docker_compose_scenarios.py(1 hunks)test/docker_tests/test_mount_diagnostics_pytest.py(1 hunks)test/docker_tests/test_ports_available.py(1 hunks)
💤 Files with no reviewable changes (5)
- install/production-filesystem/services/scripts/check-app-permissions.sh
- install/production-filesystem/services/scripts/check-ramdisk.sh
- install/production-filesystem/services/scripts/check-root.sh
- install/production-filesystem/services/scripts/check-persistent-storage.sh
- install/production-filesystem/services/scripts/check-nonpersistent-storage.sh
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use 'logger.mylog' for logging at levels: none, minimal, verbose, debug, or trace.
Files:
test/docker_tests/test_container_environment.pyinstall/production-filesystem/entrypoint.d/10-mounts.pytest/docker_tests/test_mount_diagnostics_pytest.pytest/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
test/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Tests must reside under 'test/' and use pytest.
Files:
test/docker_tests/test_container_environment.pytest/docker_tests/test_mount_diagnostics_pytest.pytest/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
🧠 Learnings (18)
📓 Common learnings
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: .devcontainer/scripts/setup.sh:146-148
Timestamp: 2025-10-26T17:09:18.621Z
Learning: In `.devcontainer/scripts/setup.sh` and other devcontainer setup scripts for NetAlertX, chmod 666 on /var/run/docker.sock is acceptable because devcontainer environments are single-user development contexts where convenience can take priority over strict permission hardening.
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/setup.sh:103-116
Timestamp: 2025-09-20T14:09:29.159Z
Learning: In NetAlertX devcontainer setup, the netalertx user has write permissions to /var/log/nginx/ directory as it's explicitly chowned to netalertx:www-data in the Dockerfile, so setup.sh can write to nginx log files without sudo.
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/devcontainer.json:5-8
Timestamp: 2025-09-20T02:56:24.501Z
Learning: In the NetAlertX devcontainer setup, the final .devcontainer/Dockerfile is generated by combining the root Dockerfile with .devcontainer/resources/devcontainer-Dockerfile using the generate-dockerfile.sh script. The devcontainer.json should reference the generated file, not the root Dockerfile.
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/stream-logs.sh:5-6
Timestamp: 2025-09-20T14:08:44.292Z
Learning: The .devcontainer/scripts/stream-logs.sh script in NetAlertX is designed as a diagnostic tool for troubleshooting devcontainer startup issues. When log files don't exist, this indicates that the executable/services didn't start properly, which is valuable diagnostic information. Pre-creating missing files would mask this diagnostic behavior.
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/setup.sh:90-96
Timestamp: 2025-09-20T14:08:48.256Z
Learning: In the NetAlertX devcontainer setup, the setup.sh script intentionally removes user_notifications.json from the API directory during development environment initialization to prevent notification clutter that accumulates during container launches and development work.
📚 Learning: 2025-10-26T17:09:18.621Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: .devcontainer/scripts/setup.sh:146-148
Timestamp: 2025-10-26T17:09:18.621Z
Learning: In `.devcontainer/scripts/setup.sh` and other devcontainer setup scripts for NetAlertX, chmod 666 on /var/run/docker.sock is acceptable because devcontainer environments are single-user development contexts where convenience can take priority over strict permission hardening.
Applied to files:
docs/docker-troubleshooting/running-as-root.mddocs/docker-troubleshooting/file-permissions.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_mounted.ymlinstall/production-filesystem/entrypoint.d/90-excessive-capabilities.shinstall/production-filesystem/entrypoint.d/30-writable-config.shdocs/docker-troubleshooting/incorrect-user.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_ramdisk.yml.devcontainer/Dockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_unwritable.ymlinstall/production-filesystem/entrypoint.d/35-nginx-config.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.ymldocs/docker-troubleshooting/mount-configuration-issues.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_unwritable.ymlinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/docker-compose.writable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.ymlinstall/production-filesystem/entrypoint.d/0-storage-permission.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.ymlDockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml
📚 Learning: 2025-09-20T03:01:19.912Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.
Applied to files:
docs/docker-troubleshooting/running-as-root.mddocs/docker-troubleshooting/file-permissions.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_mounted.ymldocs/docker-troubleshooting/port-conflicts.mddocs/docker-troubleshooting/incorrect-user.md.devcontainer/Dockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.ymldocs/docker-troubleshooting/mount-configuration-issues.mdinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/docker-compose.writable.ymltest/docker_tests/configurations/README.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_ramdisk.ymltest/docker_tests/configurations/docker-compose.missing-caps.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.ymltest/docker_tests/configurations/docker-compose.readonly.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.ymlDockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml
📚 Learning: 2025-09-20T14:09:29.159Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/setup.sh:103-116
Timestamp: 2025-09-20T14:09:29.159Z
Learning: In NetAlertX devcontainer setup, the netalertx user has write permissions to /var/log/nginx/ directory as it's explicitly chowned to netalertx:www-data in the Dockerfile, so setup.sh can write to nginx log files without sudo.
Applied to files:
docs/docker-troubleshooting/running-as-root.mddocs/docker-troubleshooting/nginx-configuration-mount.mddocs/docker-troubleshooting/file-permissions.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_mounted.ymlinstall/production-filesystem/entrypoint.d/30-writable-config.shdocs/docker-troubleshooting/incorrect-user.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_ramdisk.yml.devcontainer/Dockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_unwritable.ymlinstall/production-filesystem/entrypoint.d/35-nginx-config.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.ymldocs/docker-troubleshooting/mount-configuration-issues.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_unwritable.ymlinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/docker-compose.writable.ymltest/docker_tests/configurations/README.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_unwritable.ymltest/docker_tests/configurations/docker-compose.missing-caps.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.ymltest/docker_tests/configurations/docker-compose.readonly.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.ymlinstall/production-filesystem/entrypoint.d/0-storage-permission.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.ymlDockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml
📚 Learning: 2025-10-19T15:29:46.423Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1230
File: front/plugins/dhcp_servers/script.py:44-44
Timestamp: 2025-10-19T15:29:46.423Z
Learning: In the NetAlertX dhcp_servers plugin (front/plugins/dhcp_servers/script.py), the nmap command uses both 'sudo' and '--privileged' flag to maintain cross-platform compatibility. While the hardened Docker image stubs sudo and uses capabilities, hardware installations (Debian 12, Ubuntu 24) and the Debian Dockerfile require sudo for raw socket access. This approach ensures the plugin works across all deployment targets.
Applied to files:
docs/docker-troubleshooting/running-as-root.mddocs/docker-troubleshooting/missing-capabilities.mddocs/docker-troubleshooting/network-mode.mdinstall/production-filesystem/entrypoint.d/85-layer-2-capabilities.shdocs/docker-troubleshooting/excessive-capabilities.md
📚 Learning: 2025-10-19T01:40:57.095Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1230
File: .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template:1-2
Timestamp: 2025-10-19T01:40:57.095Z
Learning: In the NetAlertX repository, .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template is an auto-generated file that is intentionally committed to source control. It cannot be regenerated automatically outside the devcontainer environment and is required for the devcontainer to start, creating a bootstrap dependency.
Applied to files:
docs/docker-troubleshooting/nginx-configuration-mount.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_mounted.ymldocs/docker-troubleshooting/port-conflicts.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_ramdisk.yml.devcontainer/Dockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_no-mount.ymlinstall/production-filesystem/entrypoint.d/35-nginx-config.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.ymldocs/docker-troubleshooting/mount-configuration-issues.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_unwritable.ymlinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/docker-compose.writable.ymltest/docker_tests/configurations/README.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_unwritable.ymltest/docker_tests/configurations/docker-compose.missing-caps.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.ymltest/docker_tests/configurations/docker-compose.readonly.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.ymlDockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml
📚 Learning: 2025-10-26T16:45:41.247Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: install/production-filesystem/services/scripts/check-ramdisk.sh:0-0
Timestamp: 2025-10-26T16:45:41.247Z
Learning: In NetAlertX check scripts (install/production-filesystem/services/scripts/check-*.sh), not all checks should exit with non-zero status. Some checks, like check-ramdisk.sh, are warning-only and exit 0 even when issues are detected, allowing the application to start despite suboptimal configuration.
Applied to files:
install/production-filesystem/entrypoint.d/95-appliance-integrity.shinstall/production-filesystem/entrypoint.d/30-writable-config.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.ymltest/docker_tests/test_container_environment.pyinstall/production-filesystem/entrypoint.d/35-nginx-config.shinstall/production-filesystem/entrypoint.shinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_ramdisk.ymlinstall/production-filesystem/entrypoint.d/0-storage-permission.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.yml
📚 Learning: 2025-09-20T14:13:33.635Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:11-16
Timestamp: 2025-09-20T14:13:33.635Z
Learning: In the NetAlertX devcontainer setup, the `python -m venv /opt/venv` command works successfully on Alpine 3.22 despite the typical Alpine behavior of not providing a /usr/bin/python symlink by default. The build completes successfully and pytest runs without issues.
Applied to files:
test/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.yml
📚 Learning: 2025-10-26T15:39:36.707Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: install/production-filesystem/services/scripts/check-first-run-config.sh:0-0
Timestamp: 2025-10-26T15:39:36.707Z
Learning: In NetAlertX startup scripts, critical initialization failures (e.g., unable to create config directory or copy default config files) should exit with non-zero status to fail fast and provide clear error messages, rather than continuing in a broken state.
Applied to files:
install/production-filesystem/entrypoint.d/30-writable-config.shtest/docker_tests/test_container_environment.pytest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_unwritable.ymlinstall/production-filesystem/entrypoint.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_unwritable.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml
📚 Learning: 2025-09-20T14:08:44.292Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/stream-logs.sh:5-6
Timestamp: 2025-09-20T14:08:44.292Z
Learning: The .devcontainer/scripts/stream-logs.sh script in NetAlertX is designed as a diagnostic tool for troubleshooting devcontainer startup issues. When log files don't exist, this indicates that the executable/services didn't start properly, which is valuable diagnostic information. Pre-creating missing files would mask this diagnostic behavior.
Applied to files:
install/production-filesystem/entrypoint.d/30-writable-config.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_unwritable.ymlinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.log_unwritable.yml
📚 Learning: 2025-09-20T14:08:48.256Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/setup.sh:90-96
Timestamp: 2025-09-20T14:08:48.256Z
Learning: In the NetAlertX devcontainer setup, the setup.sh script intentionally removes user_notifications.json from the API directory during development environment initialization to prevent notification clutter that accumulates during container launches and development work.
Applied to files:
docs/docker-troubleshooting/incorrect-user.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_no-mount.ymlinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/docker-compose.writable.ymltest/docker_tests/configurations/README.mdtest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_ramdisk.ymltest/docker_tests/configurations/docker-compose.readonly.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.yml
📚 Learning: 2025-10-19T15:29:49.532Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1230
File: install/production-filesystem/build/init-nginx.sh:3-3
Timestamp: 2025-10-19T15:29:49.532Z
Learning: In Docker build-time initialization scripts (like those in install/production-filesystem/build/), environment variables set in the Dockerfile do not need explicit validation within the scripts. The Docker build process will fail if required environment variables are undefined, providing implicit validation.
Applied to files:
.devcontainer/DockerfileDockerfile
📚 Learning: 2025-09-20T02:56:24.501Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/devcontainer.json:5-8
Timestamp: 2025-09-20T02:56:24.501Z
Learning: In the NetAlertX devcontainer setup, the final .devcontainer/Dockerfile is generated by combining the root Dockerfile with .devcontainer/resources/devcontainer-Dockerfile using the generate-dockerfile.sh script. The devcontainer.json should reference the generated file, not the root Dockerfile.
Applied to files:
.devcontainer/Dockerfiletest/docker_tests/configurations/mount-tests/docker-compose.mount-test.db_mounted.ymlinstall/production-filesystem/entrypoint.d/60-user-netalertx.shtest/docker_tests/configurations/docker-compose.writable.ymltest/docker_tests/configurations/README.mdtest/docker_tests/configurations/docker-compose.missing-caps.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.run_no-mount.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_no-mount.ymltest/docker_tests/configurations/docker-compose.readonly.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.config_mounted.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.active_config_ramdisk.ymltest/docker_tests/configurations/mount-tests/docker-compose.mount-test.api_mounted.yml
📚 Learning: 2025-09-20T14:08:44.152Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:82-92
Timestamp: 2025-09-20T14:08:44.152Z
Learning: In devcontainer builds, source repository files are not available during the Docker build phase. The source code gets mounted into the container after it's built and started, so COPY commands referencing source files will fail. Configuration files need to be handled at runtime (e.g., in setup scripts) rather than during the build stage.
Applied to files:
.devcontainer/Dockerfile
📚 Learning: 2025-10-26T17:12:30.237Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: install/production-filesystem/services/start-php-fpm.sh:25-26
Timestamp: 2025-10-26T17:12:30.237Z
Learning: In NetAlertX's start-php-fpm.sh, PHP-FPM error logging is handled through the PHP-FPM configuration file (PHP_FPM_CONFIG_FILE) rather than through shell redirection. The current redirection pattern (stdout to LOG_APP_PHP_ERRORS, stderr to /dev/stderr) is intentional.
Applied to files:
.devcontainer/DockerfileDockerfile
📚 Learning: 2025-10-26T17:11:17.499Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: install/production-filesystem/services/scripts/update_vendors.sh:22-22
Timestamp: 2025-10-26T17:11:17.499Z
Learning: In install/production-filesystem/services/scripts/update_vendors.sh, suppressing wget stderr with 2>/dev/null is intentional; the script's own error handling (line 27: "ERROR: Failed to download or process OUI data") provides adequate feedback when downloads fail in offline environments.
Applied to files:
install/production-filesystem/entrypoint.d/80-host-mode-network.sh
📚 Learning: 2025-10-10T22:16:02.770Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1214
File: install/ubuntu24/uninstall.sh:129-141
Timestamp: 2025-10-10T22:16:02.770Z
Learning: NetAlertX uninstall procedures should only remove files from the repository (specifically /app files) and should not touch system packages like PHP, nginx, avahi, or other shared system components to avoid damaging user systems.
Applied to files:
install/production-filesystem/entrypoint.d/60-user-netalertx.sh
📚 Learning: 2025-10-10T22:16:02.770Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1214
File: install/ubuntu24/uninstall.sh:129-141
Timestamp: 2025-10-10T22:16:02.770Z
Learning: In the NetAlertX project, hardware installs are not officially supported. Hardware installation methods will be moved from source code to documentation.
Applied to files:
install/production-filesystem/entrypoint.d/60-user-netalertx.sh
🧬 Code graph analysis (2)
test/docker_tests/test_container_environment.py (1)
test/docker_tests/test_ports_available.py (4)
_assert_contains(153-161)_build_volume_args(80-85)_run_container(88-150)_setup_mount_tree(59-77)
test/docker_tests/test_ports_available.py (1)
test/docker_tests/test_container_environment.py (4)
_setup_mount_tree(94-149)_build_volume_args(166-176)_run_container(187-279)_assert_contains(283-293)
🪛 LanguageTool
docs/docker-troubleshooting/read-only-filesystem.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...nt filesystem modifications. ## How to Correct the Issue Enable read-only mode: - In...
(FIX_RESOLVE)
docs/docker-troubleshooting/running-as-root.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...ervice account for security. ## How to Correct the Issue Switch to the dedicated 'net...
(FIX_RESOLVE)
docs/docker-troubleshooting/nginx-configuration-mount.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...n running in read-only mode. ## How to Correct the Issue If you want to use a custom ...
(FIX_RESOLVE)
docs/docker-troubleshooting/file-permissions.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...nt, not root or other users. ## How to Correct the Issue Fix permissions on the host ...
(FIX_RESOLVE)
docs/docker-troubleshooting/port-conflicts.md
[style] ~19-~19: Consider using a different verb for a more formal wording.
Context: ...es are set to the same value ## How to Correct the Issue ### Check for Existing NetAl...
(FIX_RESOLVE)
docs/docker-troubleshooting/incorrect-user.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...r proper security isolation. ## How to Correct the Issue Restore the container to the...
(FIX_RESOLVE)
docs/docker-troubleshooting/missing-capabilities.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...elevated network privileges. ## How to Correct the Issue Add the required capabilitie...
(FIX_RESOLVE)
docs/docker-troubleshooting/network-mode.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...scovery and active scanning. ## How to Correct the Issue Enable host networking mode:...
(FIX_RESOLVE)
docs/docker-troubleshooting/mount-configuration-issues.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ... others should be temporary. ## How to Correct the Issue Review and correct your volu...
(FIX_RESOLVE)
docs/docker-troubleshooting/excessive-capabilities.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...ilities for proper function. ## How to Correct the Issue Limit capabilities to only t...
(FIX_RESOLVE)
🪛 Ruff (0.14.2)
test/docker_tests/test_container_environment.py
202-202: subprocess call: check for execution of untrusted input
(S603)
203-203: Starting a process with a partial executable path
(S607)
283-283: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
665-665: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
666-666: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
694-694: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
695-695: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
install/production-filesystem/entrypoint.d/10-mounts.py
173-173: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
175-175: Do not assign a lambda expression, use a def
Rewrite bool_to_check as a def
(E731)
test/docker_tests/test_mount_diagnostics_pytest.py
1-1: Shebang is present but file is not executable
(EXE001)
12-12: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
12-12: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
13-13: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
13-13: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
21-21: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
43-43: Comment contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF003)
44-44: Comment contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF003)
86-86: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
160-160: subprocess call: check for execution of untrusted input
(S603)
161-161: Starting a process with a partial executable path
(S607)
232-232: Unused function argument: netalertx_test_image
(ARG001)
247-247: subprocess call: check for execution of untrusted input
(S603)
254-254: subprocess call: check for execution of untrusted input
(S603)
268-268: subprocess call: check for execution of untrusted input
(S603)
269-269: Starting a process with a partial executable path
(S607)
275-275: subprocess call: check for execution of untrusted input
(S603)
276-276: Starting a process with a partial executable path
(S607)
287-287: subprocess call: check for execution of untrusted input
(S603)
288-288: Starting a process with a partial executable path
(S607)
374-374: subprocess call: check for execution of untrusted input
(S603)
393-393: subprocess call: check for execution of untrusted input
(S603)
401-401: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
401-401: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
test/docker_tests/test_docker_compose_scenarios.py
22-22: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
38-38: subprocess call: check for execution of untrusted input
(S603)
50-50: subprocess call: check for execution of untrusted input
(S603)
50-50: Starting a process with a partial executable path
(S607)
55-55: subprocess call: check for execution of untrusted input
(S603)
55-55: Starting a process with a partial executable path
(S607)
66-66: Redefinition of unused time from line 11
Remove definition: time
(F811)
81-81: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
103-103: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
126-126: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
168-168: Unused function argument: env_vars
(ARG001)
168-168: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
180-180: subprocess call: check for execution of untrusted input
(S603)
191-191: subprocess call: check for execution of untrusted input
(S603)
191-191: Starting a process with a partial executable path
(S607)
196-196: subprocess call: check for execution of untrusted input
(S603)
196-196: Starting a process with a partial executable path
(S607)
244-244: Redefinition of unused test_host_network_compose from line 218
(F811)
273-273: Redefinition of unused test_host_network_compose from line 244
(F811)
359-359: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
364-364: f-string without any placeholders
Remove extraneous f prefix
(F541)
365-365: f-string without any placeholders
Remove extraneous f prefix
(F541)
366-366: f-string without any placeholders
Remove extraneous f prefix
(F541)
367-367: f-string without any placeholders
Remove extraneous f prefix
(F541)
412-412: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
417-417: f-string without any placeholders
Remove extraneous f prefix
(F541)
418-418: f-string without any placeholders
Remove extraneous f prefix
(F541)
419-419: f-string without any placeholders
Remove extraneous f prefix
(F541)
420-420: f-string without any placeholders
Remove extraneous f prefix
(F541)
test/docker_tests/test_ports_available.py
43-43: subprocess call: check for execution of untrusted input
(S603)
44-44: Starting a process with a partial executable path
(S607)
56-56: subprocess call: check for execution of untrusted input
(S603)
56-56: Starting a process with a partial executable path
(S607)
70-70: Loop control variable target not used within loop body
Rename unused target to _target
(B007)
107-107: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
131-131: subprocess call: check for execution of untrusted input
(S603)
153-153: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
157-161: Avoid specifying long messages outside the exception class
(TRY003)
164-164: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
168-172: Avoid specifying long messages outside the exception class
(TRY003)
220-220: Unused function argument: dummy_container
(ARG001)
🪛 Shellcheck (0.11.0)
test/docker_tests/configurations/test_all_docker_composes.sh
[warning] 39-39: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 40-40: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 47-47: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
[warning] 51-51: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
(SC2069)
install/production-filesystem/entrypoint.sh
[warning] 42-42: RESET appears unused. Verify use (or export if used externally).
(SC2034)
install/production-filesystem/entrypoint.d/0-storage-permission.sh
Outdated
Show resolved
Hide resolved
install/production-filesystem/entrypoint.d/0-storage-permission.sh
Outdated
Show resolved
Hide resolved
install/production-filesystem/entrypoint.d/0-storage-permission.sh
Outdated
Show resolved
Hide resolved
install/production-filesystem/entrypoint.d/80-host-mode-network.sh
Outdated
Show resolved
Hide resolved
|
This is a big PR - let me know once ready and I'll merge. The table is amazing - easy to recognize what's wrong |
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (3)
install/production-filesystem/entrypoint.d/0-storage-permission.sh (1)
57-58: Fixfindcommand syntax errors.Lines 57–58 are missing the terminator for
-exec; each must end with+(or;if preferred). Currently, these commands are malformed and will fail to execute.- find ${READ_WRITE_PATHS} -type d -exec chmod u+rwx {} - find ${READ_WRITE_PATHS} -type f -exec chmod u+rw {} + find "${READ_WRITE_PATHS}" -type d -exec chmod u+rwx {} + 2>/dev/null || true + find "${READ_WRITE_PATHS}" -type f -exec chmod u+rw {} + 2>/dev/null || trueThe diff also quotes the variable to prevent word-splitting on paths with spaces, adds error suppression for consistency with line 54, and uses
+(parallel execution) for efficiency.test/docker_tests/configurations/test_all_docker_composes.sh (1)
49-55: Remove duplicatecdanddocker-compose upcommands.Lines 49 and 51 contain duplicate
cdcommands (the second lacks error handling). Lines 53 and 55 contain duplicatedocker-compose upinvocations with different redirect orders. Line 55's redirect order is incorrect (2>&1 must come after >>).Apply this diff:
cd "$dirname" || exit 1 - # Change to the directory containing the docker-compose file - cd "$dirname" + echo "Running docker-compose up..." >> "$LOG_FILE" timeout 10s docker-compose -f "$basename" up >> "$LOG_FILE" 2>&1 - echo "Running docker-compose up..." >> "$LOG_FILE" - timeout 10s docker-compose -f "$basename" up 2>&1 >> "$LOG_FILE"test/docker_tests/test_ports_available.py (1)
122-124: Resolve script path relative to repo root.The hard-coded relative path
"install/production-filesystem/entrypoint.d/99-ports-available.sh"assumes execution from the repo root. In CI or non-standard environments, thisopen()will raiseFileNotFoundError. Use dynamic repo root resolution similar to test_container_environment.py (lines 113-131 in relevant_code_snippets).Apply this diff:
- # Copy the script content and run it - script_path = "install/production-filesystem/entrypoint.d/99-ports-available.sh" - with open(script_path, 'r') as f: + # Determine repo root from env or by walking up from this file + repo_root_env = os.environ.get("NETALERTX_REPO_ROOT") + if repo_root_env: + repo_root = pathlib.Path(repo_root_env) + else: + repo_root = None + cur = pathlib.Path(__file__).resolve() + for parent in cur.parents: + if (parent / "pyproject.toml").exists() or (parent / ".git").exists(): + repo_root = parent + break + if repo_root is None: + repo_root = cur.parents[2] + + script_path = repo_root / "install" / "production-filesystem" / "entrypoint.d" / "99-ports-available.sh" + with script_path.open('r', encoding='utf-8') as f: script_content = f.read()
🧹 Nitpick comments (2)
install/production-filesystem/entrypoint.d/0-storage-permission.sh (1)
54-54: Quote variable expansion inchownfor robustness.Unquoted variable expansion can cause word-splitting if any paths contain spaces or special characters. This is a lower-risk issue than lines 57–58 (syntax errors), but quoting is a defensive best practice:
- chown -R netalertx ${READ_WRITE_PATHS} 2>/dev/null || true + chown -R netalertx "${READ_WRITE_PATHS}" 2>/dev/null || truetest/docker_tests/test_docker_compose_scenarios.py (1)
273-276: Remove extraneous f-string prefixes.Lines 273-276 (and 326-329) use f-string prefixes without any placeholders. Remove the
fprefix for clarity.Apply this diff:
"volumes": [ - f"./test_data/app_log:/app/log", - f"./test_data/app_api:/app/api", - f"./test_data/nginx_conf:/services/config/nginx/conf.active", - f"./test_data/services_run:/services/run" + "./test_data/app_log:/app/log", + "./test_data/app_api:/app/api", + "./test_data/nginx_conf:/services/config/nginx/conf.active", + "./test_data/services_run:/services/run" ],Apply the same fix to lines 326-329.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
docs/docker-troubleshooting/nginx-configuration-mount.md(1 hunks)install/production-filesystem/entrypoint.d/0-storage-permission.sh(1 hunks)install/production-filesystem/entrypoint.d/80-host-mode-network.sh(2 hunks)install/production-filesystem/entrypoint.d/90-excessive-capabilities.sh(1 hunks)test/docker_tests/configurations/test_all_docker_composes.sh(1 hunks)test/docker_tests/test_docker_compose_scenarios.py(1 hunks)test/docker_tests/test_mount_diagnostics_pytest.py(1 hunks)test/docker_tests/test_ports_available.py(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- install/production-filesystem/entrypoint.d/90-excessive-capabilities.sh
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use 'logger.mylog' for logging at levels: none, minimal, verbose, debug, or trace.
Files:
test/docker_tests/test_mount_diagnostics_pytest.pytest/docker_tests/test_ports_available.pytest/docker_tests/test_docker_compose_scenarios.py
test/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Tests must reside under 'test/' and use pytest.
Files:
test/docker_tests/test_mount_diagnostics_pytest.pytest/docker_tests/test_ports_available.pytest/docker_tests/test_docker_compose_scenarios.py
🧠 Learnings (8)
📚 Learning: 2025-10-26T16:45:41.247Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: install/production-filesystem/services/scripts/check-ramdisk.sh:0-0
Timestamp: 2025-10-26T16:45:41.247Z
Learning: In NetAlertX check scripts (install/production-filesystem/services/scripts/check-*.sh), not all checks should exit with non-zero status. Some checks, like check-ramdisk.sh, are warning-only and exit 0 even when issues are detected, allowing the application to start despite suboptimal configuration.
Applied to files:
install/production-filesystem/entrypoint.d/80-host-mode-network.shinstall/production-filesystem/entrypoint.d/0-storage-permission.sh
📚 Learning: 2025-09-20T14:08:44.292Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/stream-logs.sh:5-6
Timestamp: 2025-09-20T14:08:44.292Z
Learning: The .devcontainer/scripts/stream-logs.sh script in NetAlertX is designed as a diagnostic tool for troubleshooting devcontainer startup issues. When log files don't exist, this indicates that the executable/services didn't start properly, which is valuable diagnostic information. Pre-creating missing files would mask this diagnostic behavior.
Applied to files:
install/production-filesystem/entrypoint.d/80-host-mode-network.shtest/docker_tests/test_ports_available.py
📚 Learning: 2025-09-20T03:01:19.912Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.
Applied to files:
test/docker_tests/test_ports_available.pytest/docker_tests/test_docker_compose_scenarios.pydocs/docker-troubleshooting/nginx-configuration-mount.md
📚 Learning: 2025-10-26T17:09:18.621Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: .devcontainer/scripts/setup.sh:146-148
Timestamp: 2025-10-26T17:09:18.621Z
Learning: In `.devcontainer/scripts/setup.sh` and other devcontainer setup scripts for NetAlertX, chmod 666 on /var/run/docker.sock is acceptable because devcontainer environments are single-user development contexts where convenience can take priority over strict permission hardening.
Applied to files:
test/docker_tests/test_ports_available.pyinstall/production-filesystem/entrypoint.d/0-storage-permission.sh
📚 Learning: 2025-09-20T14:13:33.635Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:11-16
Timestamp: 2025-09-20T14:13:33.635Z
Learning: In the NetAlertX repository with Alpine 3.22 base image, the `python -m venv` command works correctly in the devcontainer setup, likely due to symlink creation in the root Dockerfile that makes `python` available as an alias to `python3`.
Applied to files:
test/docker_tests/test_ports_available.py
📚 Learning: 2025-09-20T02:56:24.501Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/devcontainer.json:5-8
Timestamp: 2025-09-20T02:56:24.501Z
Learning: In the NetAlertX devcontainer setup, the final .devcontainer/Dockerfile is generated by combining the root Dockerfile with .devcontainer/resources/devcontainer-Dockerfile using the generate-dockerfile.sh script. The devcontainer.json should reference the generated file, not the root Dockerfile.
Applied to files:
test/docker_tests/test_ports_available.py
📚 Learning: 2025-10-19T01:40:57.095Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1230
File: .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template:1-2
Timestamp: 2025-10-19T01:40:57.095Z
Learning: In the NetAlertX repository, .devcontainer/resources/devcontainer-overlay/services/config/nginx/netalertx.conf.template is an auto-generated file that is intentionally committed to source control. It cannot be regenerated automatically outside the devcontainer environment and is required for the devcontainer to start, creating a bootstrap dependency.
Applied to files:
docs/docker-troubleshooting/nginx-configuration-mount.md
📚 Learning: 2025-09-20T14:09:29.159Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/setup.sh:103-116
Timestamp: 2025-09-20T14:09:29.159Z
Learning: In NetAlertX devcontainer setup, the netalertx user has write permissions to /var/log/nginx/ directory as it's explicitly chowned to netalertx:www-data in the Dockerfile, so setup.sh can write to nginx log files without sudo.
Applied to files:
docs/docker-troubleshooting/nginx-configuration-mount.mdinstall/production-filesystem/entrypoint.d/0-storage-permission.sh
🧬 Code graph analysis (1)
test/docker_tests/test_ports_available.py (1)
test/docker_tests/test_container_environment.py (4)
_setup_mount_tree(94-149)_build_volume_args(166-176)_run_container(187-279)_assert_contains(283-293)
🪛 LanguageTool
docs/docker-troubleshooting/nginx-configuration-mount.md
[style] ~15-~15: Consider using a different verb for a more formal wording.
Context: ...n running in read-only mode. ## How to Correct the Issue If you want to use a custom ...
(FIX_RESOLVE)
🪛 Ruff (0.14.2)
test/docker_tests/test_mount_diagnostics_pytest.py
1-1: Shebang is present but file is not executable
(EXE001)
12-12: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
12-12: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
13-13: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
13-13: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
21-21: Docstring contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF002)
43-43: Comment contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF003)
44-44: Comment contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF003)
86-86: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
160-160: subprocess call: check for execution of untrusted input
(S603)
161-161: Starting a process with a partial executable path
(S607)
309-309: Unused function argument: netalertx_test_image
(ARG001)
324-324: subprocess call: check for execution of untrusted input
(S603)
331-331: subprocess call: check for execution of untrusted input
(S603)
345-345: subprocess call: check for execution of untrusted input
(S603)
346-346: Starting a process with a partial executable path
(S607)
352-352: subprocess call: check for execution of untrusted input
(S603)
353-353: Starting a process with a partial executable path
(S607)
364-364: subprocess call: check for execution of untrusted input
(S603)
365-365: Starting a process with a partial executable path
(S607)
381-381: subprocess call: check for execution of untrusted input
(S603)
415-415: subprocess call: check for execution of untrusted input
(S603)
423-423: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
423-423: String contains ambiguous ➖ (HEAVY MINUS SIGN). Did you mean - (HYPHEN-MINUS)?
(RUF001)
test/docker_tests/test_ports_available.py
43-43: subprocess call: check for execution of untrusted input
(S603)
44-44: Starting a process with a partial executable path
(S607)
56-56: subprocess call: check for execution of untrusted input
(S603)
56-56: Starting a process with a partial executable path
(S607)
70-70: Loop control variable target not used within loop body
Rename unused target to _target
(B007)
107-107: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
131-131: subprocess call: check for execution of untrusted input
(S603)
153-153: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
157-161: Avoid specifying long messages outside the exception class
(TRY003)
164-164: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
168-172: Avoid specifying long messages outside the exception class
(TRY003)
220-220: Unused function argument: dummy_container
(ARG001)
test/docker_tests/test_docker_compose_scenarios.py
30-30: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
52-52: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
75-75: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
117-117: Unused function argument: env_vars
(ARG001)
117-117: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
129-129: subprocess call: check for execution of untrusted input
(S603)
140-140: subprocess call: check for execution of untrusted input
(S603)
140-140: Starting a process with a partial executable path
(S607)
145-145: subprocess call: check for execution of untrusted input
(S603)
145-145: Starting a process with a partial executable path
(S607)
268-268: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
273-273: f-string without any placeholders
Remove extraneous f prefix
(F541)
274-274: f-string without any placeholders
Remove extraneous f prefix
(F541)
275-275: f-string without any placeholders
Remove extraneous f prefix
(F541)
276-276: f-string without any placeholders
Remove extraneous f prefix
(F541)
321-321: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
326-326: f-string without any placeholders
Remove extraneous f prefix
(F541)
327-327: f-string without any placeholders
Remove extraneous f prefix
(F541)
328-328: f-string without any placeholders
Remove extraneous f prefix
(F541)
329-329: f-string without any placeholders
Remove extraneous f prefix
(F541)
🪛 Shellcheck (0.11.0)
test/docker_tests/configurations/test_all_docker_composes.sh
[warning] 51-51: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
[warning] 55-55: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
(SC2069)
[error] 70-70: Parsing stopped here. Is this keyword correctly matched up?
(SC1089)
install/production-filesystem/entrypoint.d/0-storage-permission.sh
[error] 57-57: Missing ';' or + terminating -exec. You can't use |/||/&&, and ';' has to be a separate, quoted argument.
(SC2067)
[error] 58-58: Missing ';' or + terminating -exec. You can't use |/||/&&, and ';' has to be a separate, quoted argument.
(SC2067)
🔇 Additional comments (9)
docs/docker-troubleshooting/nginx-configuration-mount.md (1)
1-36: Comprehensive troubleshooting guide with clear remediation steps.The documentation clearly explains the issue, security implications, root cause, and provides actionable remediation with specific commands and configuration snippets. Content aligns well with the PR's goal of making errors more helpful with direct remediation guidance.
The remediation steps reference correct mount paths (
/app/system/services/active/config), user ID (20211), and permissions, which align with the mount-configuration status system introduced in this PR.Note: The past review flagged a duplicate "Additional Resources" section at lines 37–38, but that's not visible in the current code, suggesting it's already been addressed. If the duplicate remains beyond the visible range, remove the redundant block to avoid repetition.
install/production-filesystem/entrypoint.d/80-host-mode-network.sh (3)
47-66: Stdout/stderr redirection correctly restored.The diagnostic warning messages on lines 49, 50, and 65 now correctly use
>&2redirection to send output to stderr. This aligns with Unix conventions and is consistent with other diagnostic scripts in the entrypoint.d directory, addressing the issue flagged in the previous review.
2-2: Documentation link aligns with PR objectives.The updated comment on Line 2 and the new documentation link on Line 62 are well-positioned to help users troubleshoot network configuration issues. This supports the PR's goal of providing actionable remediation steps via direct documentation links.
Also applies to: 62-62
43-66: Warning-only behavior is appropriate.The script correctly exits with status 0, allowing the container to start despite non-optimal networking configuration. This follows the pattern of diagnostic-only checks (per the learnings from check-ramdisk.sh) and gives users the option to reconfigure while still running the application.
install/production-filesystem/entrypoint.d/0-storage-permission.sh (1)
1-51: Security alert and initialization look good. The comprehensive warning with direct documentation link and clear remediation guidance aligns well with the PR's goal of making error messages more helpful. The POSIX shell constructs and environment variable setup are sound.test/docker_tests/test_ports_available.py (1)
220-240: Fixture parameterdummy_containeris required for test execution.While Ruff flags
dummy_containeras unused (ARG001), this fixture parameter is essential—it ensures the dummy container is started before the test runs. Removing it would break the test's port-conflict verification. The static analysis hint is a false positive.test/docker_tests/test_mount_diagnostics_pytest.py (3)
293-303: LGTM: active_config_ scenarios now execute correctly.The
active_config_block is properly structured as a peerelifalongside other path handlers (db_, config_, api_, log_, run_), ensuring these test scenarios execute as intended.
376-407: LGTM: Live-container diagnostics path is now reachable.The diagnostic execution and assertions for running containers are correctly unindented and will execute when containers remain up, properly validating the mount diagnostic table output.
86-86: Unicode characters are intentional for table parsing.The ➖ (HEAVY MINUS SIGN) characters flagged by Ruff (RUF001-003) are intentional—they match the emoji output format of the mount diagnostic table from 10-mounts.py. These should not be changed to ASCII hyphens.
install/production-filesystem/entrypoint.d/0-storage-permission.sh
Outdated
Show resolved
Hide resolved
install/production-filesystem/entrypoint.d/0-storage-permission.sh
Outdated
Show resolved
Hide resolved
install/production-filesystem/entrypoint.d/0-storage-permission.sh
Outdated
Show resolved
Hide resolved
install/production-filesystem/entrypoint.d/80-host-mode-network.sh
Outdated
Show resolved
Hide resolved
| local dirname=$(dirname "$file") | ||
| local basename=$(basename "$file") |
| find "$SCRIPT_DIR" -name "docker-compose*.yml" -type f | sort | while read -r file; do | ||
| extract_comments "$file" | ||
| run_test "$file" | ||
| done |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
test/docker_tests/configurations/test_all_docker_composes.sh (1)
48-48: Fix stderr/stdout redirection order.The redirect
2>&1 >> "$LOG_FILE"sends stderr to the original stdout before redirecting stdout to the file, causing stderr to be lost. Move2>&1to come after the file redirect.- timeout 10s docker-compose -f "$basename" up 2>&1 >> "$LOG_FILE" + timeout 10s docker-compose -f "$basename" up >> "$LOG_FILE" 2>&1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
test/docker_tests/configurations/test_all_docker_composes.sh(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.11.0)
test/docker_tests/configurations/test_all_docker_composes.sh
[error] 37-37: Couldn't parse this brace group. Fix to allow more checks.
(SC1073)
[error] 61-61: Expected a '}'. If you have one, try a ; or \n in front of it.
(SC1056)
[error] 61-61: Missing '}'. Fix any mentioned problems and try again.
(SC1072)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
test/docker_tests/test_docker_compose_scenarios.py (2)
279-282: Remove unnecessary f-string prefixes.These strings contain no placeholders; the
fprefix is unnecessary.Apply this diff:
"volumes": [ - f"./test_data/app_log:/app/log", - f"./test_data/app_api:/app/api", - f"./test_data/nginx_conf:/services/config/nginx/conf.active", - f"./test_data/services_run:/services/run" + "./test_data/app_log:/app/log", + "./test_data/app_api:/app/api", + "./test_data/nginx_conf:/services/config/nginx/conf.active", + "./test_data/services_run:/services/run" ],
332-335: Remove unnecessary f-string prefixes.These strings contain no placeholders; the
fprefix is unnecessary.Apply this diff:
"volumes": [ - f"./test_data/app_log:/app/log", - f"./test_data/app_api:/app/api", - f"./test_data/nginx_conf:/services/config/nginx/conf.active", - f"./test_data/services_run:/services/run" + "./test_data/app_log:/app/log", + "./test_data/app_api:/app/api", + "./test_data/nginx_conf:/services/config/nginx/conf.active", + "./test_data/services_run:/services/run" ],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
test/docker_tests/test_docker_compose_scenarios.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use 'logger.mylog' for logging at levels: none, minimal, verbose, debug, or trace.
Files:
test/docker_tests/test_docker_compose_scenarios.py
test/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Tests must reside under 'test/' and use pytest.
Files:
test/docker_tests/test_docker_compose_scenarios.py
🧠 Learnings (1)
📚 Learning: 2025-09-20T03:01:19.912Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.
Applied to files:
test/docker_tests/test_docker_compose_scenarios.py
🪛 Ruff (0.14.2)
test/docker_tests/test_docker_compose_scenarios.py
30-30: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
52-52: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
75-75: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
134-134: subprocess call: check for execution of untrusted input
(S603)
146-146: subprocess call: check for execution of untrusted input
(S603)
146-146: Starting a process with a partial executable path
(S607)
151-151: subprocess call: check for execution of untrusted input
(S603)
151-151: Starting a process with a partial executable path
(S607)
274-274: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
279-279: f-string without any placeholders
Remove extraneous f prefix
(F541)
280-280: f-string without any placeholders
Remove extraneous f prefix
(F541)
281-281: f-string without any placeholders
Remove extraneous f prefix
(F541)
282-282: f-string without any placeholders
Remove extraneous f prefix
(F541)
327-327: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
332-332: f-string without any placeholders
Remove extraneous f prefix
(F541)
333-333: f-string without any placeholders
Remove extraneous f prefix
(F541)
334-334: f-string without any placeholders
Remove extraneous f prefix
(F541)
335-335: f-string without any placeholders
Remove extraneous f prefix
(F541)
🔇 Additional comments (1)
test/docker_tests/test_docker_compose_scenarios.py (1)
117-156: LGTM! Environment variable handling is now correct.The
env_varsparameter is properly merged with the current environment and passed to allsubprocess.runcalls. This addresses the previous review concern.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
test/docker_tests/test_ports_available.py (4)
42-42: Remove redundant import.
subprocessis already imported at line 8. This duplicate import is unnecessary.Apply this diff:
- import subprocess
70-75: Rename unused loop variable.The
targetvariable fromVOLUME_MAP.items()is not used within the loop body. Rename it to_targetto signal it's intentionally unused.Apply this diff:
paths = {} - for key, target in VOLUME_MAP.items(): + for key, _target in VOLUME_MAP.items(): folder_name = f"{label}_{key.upper()}_INTENTIONAL_NETALERTX_TEST"
121-128: Consider safer script injection method.The current shell escaping pattern using
chr(39)+chr(92)+chr(39)+chr(39)is fragile and difficult to maintain. For injecting multi-line shell scripts, consider using base64 encoding or mounting the script as a volume instead.Here's a safer alternative using base64:
# Copy the script content and run it script_path = pathlib.Path("install/production-filesystem/entrypoint.d/99-ports-available.sh") with script_path.open('r', encoding='utf-8') as f: script_content = f.read() - # Use printf to avoid shell interpretation issues - script = f"printf '%s\\n' '{script_content.replace(chr(39), chr(39)+chr(92)+chr(39)+chr(39))}' > /tmp/ports-check.sh && chmod +x /tmp/ports-check.sh && sh /tmp/ports-check.sh" + # Use base64 to safely inject the script + import base64 + encoded = base64.b64encode(script_content.encode('utf-8')).decode('ascii') + script = f"echo '{encoded}' | base64 -d > /tmp/ports-check.sh && chmod +x /tmp/ports-check.sh && sh /tmp/ports-check.sh" cmd.extend(["--entrypoint", "/bin/sh", IMAGE, "-c", script])
153-153: Fix implicit Optional type hints.PEP 484 prohibits implicit
Optional. Use explicit union syntax for optional parameters.Apply this diff:
-def _assert_contains(result, snippet: str, cmd: list[str] = None) -> None: +def _assert_contains(result, snippet: str, cmd: list[str] | None = None) -> None: """Assert that the result output contains the given snippet.""" if snippet not in result.output: cmd_str = " ".join(cmd) if cmd else "" raise AssertionError( f"Expected to find '{snippet}' in container output.\n" f"Got:\n{result.output}\n" f"Container command:\n{cmd_str}" ) -def _assert_not_contains(result, snippet: str, cmd: list[str] = None) -> None: +def _assert_not_contains(result, snippet: str, cmd: list[str] | None = None) -> None: """Assert that the result output does not contain the given snippet."""Also applies to: 164-164
test/docker_tests/test_docker_compose_scenarios.py (2)
152-152: Consider using list unpacking for concatenation.For consistency with modern Python style, consider using unpacking syntax instead of
+concatenation.Apply this diff:
- up_cmd = cmd + ["up"] + up_cmd = [*cmd, "up"] if detached: up_cmd.append("-d") else: up_cmd.extend([ "--abort-on-container-exit", "--timeout", str(timeout) ]) # ... later in the function ... - logs_cmd = cmd + ["logs"] + logs_cmd = [*cmd, "logs"] logs_result = subprocess.run( # ... and at the end ... if detached: - logs_cmd_display = cmd + ["logs"] + logs_cmd_display = [*cmd, "logs"] print("[compose logs command]", " ".join(logs_cmd_display))Also applies to: 179-179, 230-230
371-374: Remove extraneous f-string prefixes.These strings don't contain any interpolation placeholders, so the
fprefix is unnecessary.Apply this diff:
"volumes": [ - f"./test_data/app_log:/app/log", - f"./test_data/app_api:/app/api", - f"./test_data/nginx_conf:/services/config/nginx/conf.active", - f"./test_data/services_run:/services/run" + "./test_data/app_log:/app/log", + "./test_data/app_api:/app/api", + "./test_data/nginx_conf:/services/config/nginx/conf.active", + "./test_data/services_run:/services/run" ],And similarly at lines 424-427:
"volumes": [ - f"./test_data/app_log:/app/log", - f"./test_data/app_api:/app/api", - f"./test_data/nginx_conf:/services/config/nginx/conf.active", - f"./test_data/services_run:/services/run" + "./test_data/app_log:/app/log", + "./test_data/app_api:/app/api", + "./test_data/nginx_conf:/services/config/nginx/conf.active", + "./test_data/services_run:/services/run" ],Also applies to: 424-427
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
test/docker_tests/test_docker_compose_scenarios.py(1 hunks)test/docker_tests/test_ports_available.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use 'logger.mylog' for logging at levels: none, minimal, verbose, debug, or trace.
Files:
test/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
test/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Tests must reside under 'test/' and use pytest.
Files:
test/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
🧠 Learnings (7)
📚 Learning: 2025-09-20T03:01:19.912Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:18-19
Timestamp: 2025-09-20T03:01:19.912Z
Learning: In the NetAlertX repository, .devcontainer/Dockerfile is auto-generated and should not be reviewed directly. Review comments about dependencies and build steps should be directed at the root Dockerfile where the actual source commands are located.
Applied to files:
test/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
📚 Learning: 2025-10-26T17:09:18.621Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1235
File: .devcontainer/scripts/setup.sh:146-148
Timestamp: 2025-10-26T17:09:18.621Z
Learning: In `.devcontainer/scripts/setup.sh` and other devcontainer setup scripts for NetAlertX, chmod 666 on /var/run/docker.sock is acceptable because devcontainer environments are single-user development contexts where convenience can take priority over strict permission hardening.
Applied to files:
test/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
📚 Learning: 2025-11-01T19:02:10.609Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1263
File: install/production-filesystem/entrypoint.sh:60-86
Timestamp: 2025-11-01T19:02:10.609Z
Learning: In the NetAlertX project (install/production-filesystem/entrypoint.sh), when fail-fast behavior is adopted for entrypoint checks in the future, be lenient during review because tests will be removed or changed to accommodate that behavior. The current continue-on-failure approach exists to support the existing test suite, but this is expected to change along with corresponding test adjustments.
Applied to files:
test/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
📚 Learning: 2025-09-20T14:08:44.292Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/scripts/stream-logs.sh:5-6
Timestamp: 2025-09-20T14:08:44.292Z
Learning: The .devcontainer/scripts/stream-logs.sh script in NetAlertX is designed as a diagnostic tool for troubleshooting devcontainer startup issues. When log files don't exist, this indicates that the executable/services didn't start properly, which is valuable diagnostic information. Pre-creating missing files would mask this diagnostic behavior.
Applied to files:
test/docker_tests/test_docker_compose_scenarios.pytest/docker_tests/test_ports_available.py
📚 Learning: 2025-09-20T14:13:33.635Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:11-16
Timestamp: 2025-09-20T14:13:33.635Z
Learning: In the NetAlertX repository with Alpine 3.22 base image, the `python -m venv` command works correctly in the devcontainer setup, likely due to symlink creation in the root Dockerfile that makes `python` available as an alias to `python3`.
Applied to files:
test/docker_tests/test_ports_available.py
📚 Learning: 2025-09-20T02:56:24.501Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/devcontainer.json:5-8
Timestamp: 2025-09-20T02:56:24.501Z
Learning: In the NetAlertX devcontainer setup, the final .devcontainer/Dockerfile is generated by combining the root Dockerfile with .devcontainer/resources/devcontainer-Dockerfile using the generate-dockerfile.sh script. The devcontainer.json should reference the generated file, not the root Dockerfile.
Applied to files:
test/docker_tests/test_ports_available.py
📚 Learning: 2025-09-20T14:13:33.635Z
Learnt from: adamoutler
Repo: jokob-sk/NetAlertX PR: 1184
File: .devcontainer/Dockerfile:11-16
Timestamp: 2025-09-20T14:13:33.635Z
Learning: In the NetAlertX devcontainer setup, the `python -m venv /opt/venv` command works successfully on Alpine 3.22 despite the typical Alpine behavior of not providing a /usr/bin/python symlink by default. The build completes successfully and pytest runs without issues.
Applied to files:
test/docker_tests/test_ports_available.py
🧬 Code graph analysis (1)
test/docker_tests/test_ports_available.py (1)
test/docker_tests/test_container_environment.py (4)
_setup_mount_tree(94-149)_build_volume_args(166-176)_run_container(187-279)_assert_contains(283-293)
🪛 Ruff (0.14.2)
test/docker_tests/test_docker_compose_scenarios.py
33-33: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
55-55: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
85-85: Probable insecure usage of temporary file or directory: "/tmp:uid=20211,gid=20211,mode=1700,rw,noexec,nosuid,nodev,async,noatime,nodiratime"
(S108)
152-152: Consider [*cmd, "up"] instead of concatenation
Replace with [*cmd, "up"]
(RUF005)
168-168: subprocess call: check for execution of untrusted input
(S603)
179-179: Consider [*cmd, "logs"] instead of concatenation
Replace with [*cmd, "logs"]
(RUF005)
180-180: subprocess call: check for execution of untrusted input
(S603)
198-198: subprocess call: check for execution of untrusted input
(S603)
210-210: subprocess call: check for execution of untrusted input
(S603)
210-210: Starting a process with a partial executable path
(S607)
215-215: subprocess call: check for execution of untrusted input
(S603)
215-215: Starting a process with a partial executable path
(S607)
230-230: Consider [*cmd, "logs"] instead of concatenation
Replace with [*cmd, "logs"]
(RUF005)
366-366: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
371-371: f-string without any placeholders
Remove extraneous f prefix
(F541)
372-372: f-string without any placeholders
Remove extraneous f prefix
(F541)
373-373: f-string without any placeholders
Remove extraneous f prefix
(F541)
374-374: f-string without any placeholders
Remove extraneous f prefix
(F541)
419-419: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
424-424: f-string without any placeholders
Remove extraneous f prefix
(F541)
425-425: f-string without any placeholders
Remove extraneous f prefix
(F541)
426-426: f-string without any placeholders
Remove extraneous f prefix
(F541)
427-427: f-string without any placeholders
Remove extraneous f prefix
(F541)
test/docker_tests/test_ports_available.py
43-43: subprocess call: check for execution of untrusted input
(S603)
44-44: Starting a process with a partial executable path
(S607)
56-56: subprocess call: check for execution of untrusted input
(S603)
56-56: Starting a process with a partial executable path
(S607)
70-70: Loop control variable target not used within loop body
Rename unused target to _target
(B007)
107-107: Probable insecure usage of temporary file or directory: "/tmp:mode=777"
(S108)
131-131: subprocess call: check for execution of untrusted input
(S603)
153-153: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
157-161: Avoid specifying long messages outside the exception class
(TRY003)
164-164: PEP 484 prohibits implicit Optional
Convert to T | None
(RUF013)
168-172: Avoid specifying long messages outside the exception class
(TRY003)
220-220: Unused function argument: dummy_container
(ARG001)
🔇 Additional comments (2)
test/docker_tests/test_ports_available.py (1)
220-240: LGTM: Fixture usage is correct.The
dummy_containerparameter appears unused in the function body, but this is the correct pytest pattern—the fixture's side effect (occupying ports 20211 and 20212) is what the test relies on. The static analysis warning can be safely ignored.test/docker_tests/test_docker_compose_scenarios.py (1)
291-342: LGTM: Test assertions are now consistent.The test correctly verifies that a properly configured startup shows success indicators in the mounts table without critical errors or permission issues. The assertions align with the expected behavior.
|
I think CodeRabbit is done @jokob-sk . I'm fine with this if you are. It does not include fail-fast. Errors will continue until they cause the system to attempt to start, fail to start, and then reboot instead of failing immediately and rebooting. I will rework the tests for a fail fast soon. That would be a separate reworking required. |
|
@jokob-sk I realized there were changes to the /Dockerfile already in this so I addressed that request from earlier with making the scripts executable instead of needing to run |
commit 90a07c6 Merge: 13341e3 031d810 Author: jokob-sk <jokob.sk@gmail.com> Date: Mon Nov 3 08:14:26 2025 +1100 Merge branch 'main' of https://github.com/jokob-sk/NetAlertX commit 13341e3 Author: jokob-sk <jokob.sk@gmail.com> Date: Mon Nov 3 08:14:15 2025 +1100 PLG: ARPSCAN prevent duplicates across subnets Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 031d810 Merge: cb69990 b806f84 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Sun Nov 2 22:20:13 2025 +1100 Merge branch `next_release` into main commit b806f84 Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Nov 2 22:16:28 2025 +1100 BE: invlaid return netalertx#1251 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 7c90c2e Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Nov 2 22:12:30 2025 +1100 BE: spinner + timestamp work netalertx#1251 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit cb69990 Merge: 71646e1 7037cf1 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Sun Nov 2 21:48:27 2025 +1100 Merge pull request netalertx#1268 from adamoutler/synology-fix Fix permissions on Synology commit 7037cf1 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Nov 2 10:26:21 2025 +0000 fxi permissions on synology inherited commit a27ee5c Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Nov 2 13:55:51 2025 +1100 BE: changes netalertx#1251 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit c3c570e Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Nov 2 13:51:17 2025 +1100 BE: added stateUpdated netalertx#1251 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 71646e1 Merge: e7ed9e0 dde542c Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Sun Nov 2 13:49:39 2025 +1100 Merge pull request netalertx#1263 from adamoutler/FEAT--Make-Errors-More-Helpful Feat: make errors more helpful commit 2215272 Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Nov 2 11:57:08 2025 +1100 BE: short-circuit of name resolution netalertx#1251 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit dde542c Author: Adam Outler <adamoutler@gmail.com> Date: Sun Nov 2 00:12:50 2025 +0000 make /services/scripts executable by default commit 23a0fac Author: Adam Outler <adamoutler@gmail.com> Date: Sat Nov 1 23:54:54 2025 +0000 Address Coderabbit issue commit 2fdecce Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Nov 2 09:07:59 2025 +1100 PLG: NMAPDEV stripping --vlan netalertx#1264 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit db5381d Author: Adam Outler <adamoutler@gmail.com> Date: Sat Nov 1 15:12:54 2025 -0400 Update test/docker_tests/test_docker_compose_scenarios.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit f1fbc47 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Nov 1 19:04:31 2025 +0000 coderabbit required fix commit 2a9d352 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Nov 1 14:57:57 2025 -0400 Update test/docker_tests/configurations/test_all_docker_composes.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 51aa3d4 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Nov 1 18:53:07 2025 +0000 coderabbit commit 70373b1 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Nov 1 18:18:32 2025 +0000 Address coderabbit-discoverd issues commit e7ed9e0 Author: jokob-sk <jokob.sk@gmail.com> Date: Sat Nov 1 17:58:22 2025 +1100 BE: logging fix and comments why eve_PendingAlertEmail not cleared Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 79887f0 Merge: a6bc96d ff96d38 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 31 23:59:45 2025 -0400 Merge branch 'jokob-sk:main' into FEAT--Make-Errors-More-Helpful commit a6bc96d Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 31 22:47:35 2025 +0000 Corrections on testing and behaviors commit 8edef9e Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 31 22:24:31 2025 +0000 All errors have documentation links commit 1e63cec Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 31 22:24:08 2025 +0000 Revise tests. Use docker-compose.yml where possible commit ff96d38 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 22:09:43 2025 +1100 DOCS:old docker installation guide Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 537be0f Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 22:01:16 2025 +1100 BE: typos Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit b89917c Merge: daea3a2 f42186b Author: Hosted Weblate <hosted@weblate.org> Date: Fri Oct 31 11:55:36 2025 +0100 Merge branch 'origin/main' into Weblate. commit daea3a2 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 21:55:15 2025 +1100 DOCS: WARNING use dockerhub docs Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit b86f636 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 21:46:59 2025 +1100 Revert "DOCS: clearer local_path instructions" This reverts commit dfc64fd. commit 0b08995 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 21:46:25 2025 +1100 Revert "DOCS: install refactor work" This reverts commit fe69972. commit f42186b Merge: 88f889f bc9fb6b Author: Hosted Weblate <hosted@weblate.org> Date: Fri Oct 31 11:10:55 2025 +0100 Merge branch 'origin/main' into Weblate. commit bc9fb6b Author: jeet moh <jeetdevpc@gmail.com> Date: Thu Oct 30 13:07:48 2025 +0100 Translated using Weblate (Persian (fa_FA)) Currently translated at 0.1% (1 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/fa_FA/ commit 88f889f Merge: 533c99e afa257f Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 20:56:36 2025 +1100 Merge branch 'next_release' of https://github.com/jokob-sk/NetAlertX into next_release commit 533c99e Merge: 78ab0fb 64e4586 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 20:45:31 2025 +1100 LNG: Swedish (sv_sv) commit afa257f Merge: 78ab0fb 64e4586 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 20:45:31 2025 +1100 Merge branch 'next_release' of https://github.com/jokob-sk/NetAlertX into next_release commit 78ab0fb Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 20:24:13 2025 +1100 PLG: SNMPDSC typo commit 64e4586 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 20:24:13 2025 +1100 PLG: Encode SMTP_PASS using base64 netalertx#1253 commit 2f7d9a0 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 15:02:51 2025 +1100 PLG: snmpwalk -OXsq clarification netalertx#1231 commit d29700a Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 31 00:07:34 2025 +0000 New mount test structure. commit 75072da Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 08:16:54 2025 +1100 GIT: build dev container from next_release branch Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 19b1fc9 Merge: 63d6410 929eb16 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Fri Oct 31 08:15:12 2025 +1100 Merge pull request netalertx#1260 from jokob-sk/main BE: Devices Tiles SQL syntax error netalertx#1238 commit 63d6410 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 08:12:38 2025 +1100 BE: handle missing buildtimestamp.txt Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit b89a44d Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 30 21:05:24 2025 +0000 Improve startup checks commit 929eb16 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Thu Oct 30 20:48:38 2025 +0000 BE: Devices Tiles SQL syntax error netalertx#1238 commit 8cb1836 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 29 23:49:37 2025 +0000 Move all check- scripts to /entrypoint.d/ for better organization commit 512dedf Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 31 06:39:55 2025 +1100 FE: increase filter debounce to 750ms netalertx#1254 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 2a2782b Merge: 869f28b b726518 Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 14:52:34 2025 +1100 Merge branch 'next_release' of https://github.com/jokob-sk/NetAlertX into next_release commit b726518 Merge: f81a1b9 274beca Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Thu Oct 30 14:52:19 2025 +1100 Merge pull request netalertx#1258 from jokob-sk/main BE: fix GRAPHQL_PORT commit 274beca Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 14:51:24 2025 +1100 BE: fix GRAPHQL_PORT Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 869f28b Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 14:50:13 2025 +1100 DOCS: typos Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit f81a1b9 Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 14:31:22 2025 +1100 DOCS: Docker guides Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 58fe531 Merge: 50f9277 8da136f Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Thu Oct 30 13:56:17 2025 +1100 Merge pull request netalertx#1257 from jokob-sk/main BE: Remove GraphQL check from healthcheck commit 8da136f Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 13:55:05 2025 +1100 BE: Remove GraphQL check from healthcheck Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 50f9277 Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 13:30:23 2025 +1100 DOCS: Docker guides (GRAPHQL_PORT fix) Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 7ca9d2a Merge: b76272b 55171e0 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Thu Oct 30 13:16:05 2025 +1100 Merge pull request netalertx#1256 from adamoutler/next_release update docker compose commit b76272b Merge: fba5359 22aa995 Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 13:14:12 2025 +1100 Merge branch 'next_release' of https://github.com/jokob-sk/NetAlertX into next_release commit fba5359 Author: jokob-sk <jokob.sk@gmail.com> Date: Thu Oct 30 13:14:06 2025 +1100 DOCS: Docker guides Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 55171e0 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 29 23:29:32 2025 +0000 update compose commit 22aa995 Merge: 647defb af80cff Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Thu Oct 30 08:33:06 2025 +1100 Merge pull request netalertx#1255 from Tweebloesem/patch-2 Fix typo in PiHole integration guide commit af80cff Author: Tweebloesem <139498987+Tweebloesem@users.noreply.github.com> Date: Wed Oct 29 22:18:42 2025 +0100 Fix typo in PiHole integration guide commit 647defb Merge: 2148a7f ea5e236 Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 20:33:42 2025 +1100 Merge branch 'next_release' of https://github.com/jokob-sk/NetAlertX into next_release commit 2148a7f Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 20:33:32 2025 +1100 DOCS: Docker guides Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit ea5e236 Merge: 61de637 0079ece Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Wed Oct 29 19:26:36 2025 +1100 Merge pull request netalertx#1249 from jokob-sk/main Sync commit 0079ece Merge: 5962312 8d4c7ea Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Wed Oct 29 19:25:32 2025 +1100 Merge pull request netalertx#1248 from adamoutler/Easy-Permissions Easy permissions commit 61de637 Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 15:51:31 2025 +1100 DOCS: Docker guides Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 57f3d6f Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 13:26:10 2025 +1100 DOCS: Security features - fix hierarchy Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 2e76ff1 Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 13:21:12 2025 +1100 DOCS: Migration and Security features navigation link commit 8d4c7ea Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 29 00:32:08 2025 +0000 less invasive permission changes commit b4027b6 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 29 00:08:32 2025 +0000 docker-compose needed for fast container rebuilds commit b36b3be Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 29 00:08:09 2025 +0000 Fix permissions messages and test parms commit 7ddb7d2 Author: Adam Outler <adamoutler@gmail.com> Date: Tue Oct 28 23:58:02 2025 +0000 new method of fixing permissions commit 40341a8 Merge: 304d4d0 6afa52e Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Wed Oct 29 07:37:55 2025 +1100 Merge pull request netalertx#1247 from adamoutler/next_release Security features overview commit 304d4d0 Merge: a353acf 4d148f3 Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 07:33:59 2025 +1100 Merge branch 'next_release' of https://github.com/jokob-sk/NetAlertX into next_release commit a353acf Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 29 07:32:56 2025 +1100 DOCS: builds Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 6afa52e Author: Adam Outler <adamoutler@gmail.com> Date: Tue Oct 28 00:15:12 2025 +0000 Security features overview commit 5962312 Merge: 84183f0 3ba4100 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Tue Oct 28 08:31:30 2025 +1100 Merge pull request netalertx#1235 from adamoutler/hardening-fixes Hardening fixes commit 3ba4100 Author: Adam Outler <adamoutler@gmail.com> Date: Mon Oct 27 16:51:17 2025 -0400 Update install/production-filesystem/entrypoint.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit a6ac492 Author: Adam Outler <adamoutler@gmail.com> Date: Mon Oct 27 20:19:17 2025 +0000 Add APP_CONF_OVERRIDE support commit 4d148f3 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Mon Oct 27 03:33:50 2025 +0000 DOCS: wording commit 9b0f45b Author: jokob-sk <jokob.sk@gmail.com> Date: Mon Oct 27 14:21:17 2025 +1100 DOCS: migration prep Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 84183f0 Author: jokob-sk <jokob.sk@gmail.com> Date: Mon Oct 27 12:58:48 2025 +1100 LANG: ru_ru updates Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 5dba0f1 Merge: 76419db 816b907 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Mon Oct 27 08:14:16 2025 +1100 Merge pull request netalertx#1244 from jokob-sk/main sync commit 095372a Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 16:49:28 2025 -0400 Rename GRAPHQL_PORT to APP_CONF_OVERRIDE commit d8c2dc0 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 19:58:57 2025 +0000 Apply coderabit's latest hare-brained idea commit cfffaf4 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 19:40:17 2025 +0000 Strengthen tests commit 01b64cc Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 19:34:28 2025 +0000 Changes requested by coderabbit. commit 63c4b0d Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 14:15:12 2025 -0400 Update .devcontainer/devcontainer.json Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 5ec35aa Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 18:12:02 2025 +0000 Build the netalertx-test image on start so tests don't fail commit ededd39 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 17:53:46 2025 +0000 Coderabbit fixes commit 15bc163 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 12:45:42 2025 -0400 Update install/production-filesystem/services/scripts/check-root.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 74a67e3 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 16:10:17 2025 +0000 Added clarifying examples to dockerfile commit 52b747b Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 15:54:01 2025 +0000 Remove warnings in devcontainer commit d2c28f6 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 15:30:03 2025 +0000 Changes for tests identified by CodeRabbit commit 816b907 Author: Almaz <almazgamer228@gmail.com> Date: Sat Oct 25 09:56:34 2025 +0200 Translated using Weblate (Russian) Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ru/ commit fb02774 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 26 00:14:03 2025 +0000 Fix errors for tests commit 2663227 Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Oct 26 11:07:34 2025 +1100 PLUG: SNMPDSC timeout multiplier netalertx#1231 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit dfc64fd Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Oct 26 10:59:42 2025 +1100 DOCS: clearer local_path instructions Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit b44369a Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Oct 26 10:59:05 2025 +1100 PLUG: 0 in device tiles netalertx#1238 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 8ada2c3 Author: jokob-sk <jokob.sk@gmail.com> Date: Sun Oct 26 10:58:34 2025 +1100 BE: 0 in device tiles netalertx#1238 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit c4a041e Author: Adam Outler <adamoutler@gmail.com> Date: Sat Oct 25 17:58:21 2025 +0000 Coderabit changes commit 170aeb0 Author: jokob-sk <jokob.sk@gmail.com> Date: Sat Oct 25 13:48:56 2025 +1100 PLUG: SNMPDSC timeout not respected netalertx#1231 Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit fe69972 Author: jokob-sk <jokob.sk@gmail.com> Date: Sat Oct 25 09:28:03 2025 +1100 DOCS: install refactor work Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 32f9111 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 24 20:32:50 2025 +0000 Restore test_safe_builder_unit.py to upstream version (remove local changes) commit bb35417 Merge: fe69bc4 05890b3 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Sat Oct 25 07:07:12 2025 +1100 Merge pull request netalertx#1237 from JVKeller/patch-3 Change branch back to main. commit fe69bc4 Merge: 6a20128 c278865 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Sat Oct 25 07:06:41 2025 +1100 Merge pull request netalertx#1236 from AlmazzikDev/patch-1 Rename CONTRIBUTING to CONTRIBUTING.md commit 05890b3 Author: rell3k <keller.jeff@gmail.com> Date: Fri Oct 24 09:24:01 2025 -0400 Change branch back to main. Forgot to change git clone branch back to main. commit c278865 Author: Almaz <almaz@weissx.net> Date: Fri Oct 24 15:35:18 2025 +0300 Rename CONTRIBUTING to CONTRIBUTING.md commit 7f74c2d Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 21:37:11 2025 -0400 docker compose changes commit 5a63b72 Merge: 0897c05 6a20128 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 21:19:30 2025 -0400 Merge main into hardening-fixes commit 0897c05 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 21:16:15 2025 -0400 Tidy up output commit 7a3bf67 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 20:46:39 2025 -0400 Remove code coverage from repository commit edd5bd2 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 23:33:04 2025 +0000 Devcontainer setup commit 3b7830b Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 21:15:15 2025 +0000 Add unit tests and updated messages commit 356caca Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 21:15:02 2025 +0000 Don't increment sqlite sequence commit d12ffb3 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 21:04:15 2025 +0000 Update readme with simple build instructions commit f70d3f3 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 20:36:04 2025 +0000 Limiter fix for older kernels commit 2789946 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 08:36:42 2025 +0000 use system speedtest, not un-updated & removed script commit 59c7d7b Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 23 00:27:16 2025 +0000 Add test dependencies commit 0851680 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 22 23:51:36 2025 +0000 Add additional startup checks commit 1af19fe Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 22 23:51:15 2025 +0000 Only nginx/python errors in docker logs. no stdout from backend. commit ce8bb53 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 22 19:48:58 2025 -0400 Refine devcontainer setup and docker tests commit 5636a15 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 22 00:02:03 2025 +0000 Add check permissions script commit 6a20128 Author: jokob-sk <jokob.sk@gmail.com> Date: Wed Oct 22 07:48:50 2025 +1100 BE: install refactor work Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 05f0837 Author: Adam Outler <adamoutler@gmail.com> Date: Tue Oct 21 19:18:59 2025 +0000 Fix missing storage check commit 3441f77 Author: Adam Outler <adamoutler@gmail.com> Date: Tue Oct 21 19:10:48 2025 +0000 Fix always fresh install env commit d6bcb27 Author: Adam Outler <adamoutler@gmail.com> Date: Tue Oct 21 19:05:47 2025 +0000 Missing devcontainer build timestamp commit 5d7af88 Merge: b916542 6f2e556 Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Tue Oct 21 12:35:08 2025 +1100 Merge pull request netalertx#1230 from adamoutler/hardening Feat: Enterprise-Grade Security Hardening and Build Overhaul commit 6f2e556 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 12:18:16 2025 -0400 Remove duplicate file replacement logic in update_vendors.sh Dang it coderabbit. We expect more of your diffs. commit ea4c70e Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 12:15:55 2025 -0400 Update install/production-filesystem/services/scripts/check-first-run-config.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 5ed46da Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 15:55:28 2025 +0000 Set caps on actual python3.12 commit 628f35c Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 15:41:57 2025 +0000 Remove unused pythonpathpath variable commit 066fecf Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 15:39:54 2025 +0000 add caps to python instead of scapy. commit 660f0c2 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 11:37:04 2025 -0400 Update install/production-filesystem/services/scripts/update_vendors.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 999feb2 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 11:36:09 2025 -0400 Update install/production-filesystem/services/scripts/update_vendors.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 86bf0a3 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 11:35:27 2025 -0400 Update install/production-filesystem/services/scripts/check-first-run-config.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 8eab7ee Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 11:33:07 2025 -0400 Update .devcontainer/scripts/setup.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> commit 84f1283 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 15:27:55 2025 +0000 Add novel coderabit no-write database creation commit dcf250d Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 15:12:27 2025 +0000 Coderabbit nitpicks. commit 131c0c0 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 14:28:09 2025 +0000 Fix fish terminal. Smarter code completion and other nicities. commit a58b3e3 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 14:18:07 2025 +0000 Coderabbit suggestions commit 14be7a2 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 02:45:19 2025 +0000 Missing Slash commit 9b3ddda Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 02:35:57 2025 +0000 Fix persistent environment issues commit 1f46f20 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 01:06:42 2025 +0000 Generate devcontainer configs commit 80c1459 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 19 00:39:26 2025 +0000 Final touches on devcontainer commit 62536e4 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Oct 18 14:07:27 2025 -0400 Coderabit suggestions commit 028335c Author: Adam Outler <adamoutler@gmail.com> Date: Sat Oct 18 13:45:48 2025 -0400 Coderabit suggestions commit 7483e46 Merge: c1b573f b916542 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Oct 18 13:23:57 2025 -0400 Merge remote-tracking branch 'origin/main' into hardening commit c1b573f Author: Adam Outler <adamoutler@gmail.com> Date: Sat Oct 18 13:16:35 2025 -0400 Add some todos commit d11c9d7 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 17 16:36:48 2025 -0400 Improve warnings. commit b916542 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 17 21:33:43 2025 +1100 BE: DB generate=ing script Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 6da3cfd Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 17 21:33:22 2025 +1100 FE: docs mikrotik Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit d38e77f Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 17 21:32:53 2025 +1100 docs Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 18eaee4 Author: jokob-sk <jokob.sk@gmail.com> Date: Fri Oct 17 21:32:22 2025 +1100 FE: lang Signed-off-by: jokob-sk <jokob.sk@gmail.com> commit 59e7463 Author: Safeguard <yo-safeguard@yandex.ru> Date: Thu Oct 16 10:55:31 2025 +0200 Translated using Weblate (Russian) Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ru/ commit dc44411 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 16 21:49:54 2025 -0400 Improve mount permissions commit a3dae08 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 16 19:51:57 2025 -0400 Fix debian docker start commit e733f8a Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 16 16:17:37 2025 -0400 Relay failed status to docker. commit ad0ddda Merge: 3686a4a 28e0e4a Author: Jokob @netalertx <96159884+jokob-sk@users.noreply.github.com> Date: Thu Oct 16 12:50:08 2025 +1100 Merge pull request netalertx#1229 from adamoutler/patch-5 Add script to regenerate the database from schema commit 28e0e4a Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 15 20:53:03 2025 -0400 Fix database regeneration script to use correct file commit 324cde9 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 15 20:50:42 2025 -0400 Add script to regenerate the database from schema This script recreates the database from schema code and imports the schema into the new database file. commit f57ec74 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 16 00:09:07 2025 +0000 Minor alterations to ddevcontainer. commit de92c95 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 15 18:18:30 2025 -0400 break apart services, fix startup commit 3686a4a Author: anton garcias <isaga.percompartir@gmail.com> Date: Mon Oct 13 22:37:42 2025 +0200 Translated using Weblate (Catalan) Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ca/ commit 44ba945 Author: Ettore Atalan <atalanttore@googlemail.com> Date: Sun Oct 12 22:12:37 2025 +0200 Translated using Weblate (German) Currently translated at 81.3% (620 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/de/ commit 5109a08 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 12 21:00:27 2025 -0400 Additional hardening commit 1be9155 Author: Adam Outler <adamoutler@gmail.com> Date: Sun Oct 12 15:05:20 2025 -0400 Set container parameters commit 3bf6ce6 Author: R <15691591183@163.com> Date: Sun Oct 12 15:49:48 2025 +0200 Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/zh_Hans/ commit 1532256 Author: Massimo Pissarello <mapi68@gmail.com> Date: Sat Oct 11 01:39:43 2025 +0200 Translated using Weblate (Italian) Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/it/ commit be73e3a Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 9 20:30:25 2025 -0400 debian dockerfile completed properly. commit 016a6ad Author: Adam Outler <adamoutler@gmail.com> Date: Wed Oct 8 19:55:16 2025 -0400 Dockerfile.debian building and running commit 558ab44 Author: Adam Outler <adamoutler@gmail.com> Date: Mon Oct 6 23:31:20 2025 +0000 Minimize differences between devcontainer and production commit 290b6c6 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Oct 4 18:51:10 2025 +0000 Remove nohup.out commit ada9271 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 3 22:12:42 2025 +0000 all debugging online. commit 1e04e9f Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 3 00:33:20 2025 +0000 Remove .git-placeholder, add dockerignore commit c81a054 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Oct 3 00:08:26 2025 +0000 Coderabit commit 33aa849 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Oct 2 21:19:29 2025 +0000 Debugging operational in vscode commit 0cd1dc8 Author: Adam Outler <adamoutler@gmail.com> Date: Tue Sep 30 22:01:03 2025 -0400 Scanning Operational with monitoring commit 044035e Author: Adam Outler <adamoutler@gmail.com> Date: Tue Sep 30 01:55:26 2025 +0000 Devcontainer overlay commit dc4848a Author: Adam Outler <adamoutler@gmail.com> Date: Sun Sep 28 21:59:06 2025 -0400 Information on default config and entrypoints for debug commit c6efe5a Author: Adam Outler <adamoutler@gmail.com> Date: Sun Sep 28 17:10:15 2025 -0400 All services moved to deployed filesystem commit d182a55 Author: Adam Outler <adamoutler@gmail.com> Date: Sat Sep 27 21:58:00 2025 -0400 Move filesystem to more generic name & add perms commit b47df7b Author: Adam Outler <adamoutler@gmail.com> Date: Sat Sep 27 19:48:36 2025 -0400 capcheck commit 46097bb Author: Adam Outler <adamoutler@gmail.com> Date: Sat Sep 27 19:15:07 2025 -0400 solid hardened config commit c5d7480 Merge: 2def3f1 d9feddd Author: Adam Outler <adamoutler@gmail.com> Date: Sat Sep 27 09:00:46 2025 -0400 Merge branch 'jokob-sk:main' into hardening commit 2def3f1 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Sep 26 21:01:58 2025 -0400 Validated launch on runner & hardend commit 2419a26 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Sep 26 17:52:17 2025 +0000 updated devcontainer dockerfile commit bad67b2 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Sep 26 17:52:11 2025 +0000 fix dockerfile error commit 178fb54 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Sep 26 17:32:58 2025 +0000 Python up and debuggable commit b0a6f88 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Sep 26 17:14:20 2025 +0000 Update gitignore commit 798d246 Author: Adam Outler <adamoutler@gmail.com> Date: Fri Sep 26 11:56:27 2025 +0000 expand initial filesystem commit c228d45 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Sep 25 23:03:55 2025 +0000 Devcontainer operational, services all down commit dfcc375 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Sep 25 14:10:06 2025 -0400 Non-root launch commit 8ed21a8 Author: Adam Outler <adamoutler@gmail.com> Date: Thu Sep 25 07:43:42 2025 -0400 monolithic alpine container commit 2e694a7 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Sep 24 19:46:11 2025 -0400 using 4 startup scripts instead of RC6 commit 29aa884 Author: Adam Outler <adamoutler@gmail.com> Date: Wed Sep 24 16:29:15 2025 -0400 architectural change 1
2 participants
🎯 Pull Request: Enhanced Error Visibility and Comprehensive Testing
Overview
This PR significantly improves NetAlertX's error reporting and diagnostic capabilities by introducing a visual status grid, comprehensive documentation links, and extensive unit testing. The primary feature is an intuitive ✅/❌/➖ status table that makes configuration issues immediately visible to users.
Key Features
🏗️ Visual Status Grid
📚 Comprehensive Documentation
🧪 Extensive Test Suite
Technical Changes
Script Reorganization
/entrypoint.d/directoryEnhanced Diagnostics
10-mounts.py)Testing Infrastructure
Example Output
Impact
Testing
This PR transforms NetAlertX's error handling from cryptic messages to actionable, visually clear diagnostics that guide users to correct configurations quickly and confidently.
I will check back tomorrow on CodeRabbit analysis.
Summary by CodeRabbit
New Features
Documentation
Tests
Bug Fixes