Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #13077 KafkaJs typing consistency #13084

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: #13077 KafkaJs typing consistency #13084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: #13077 KafkaJs typing consistency
  • Loading branch information
@edeesis
edeesis committed Jan 23, 2024
commit 5683d277b30c2f2fa3214775f4af326bc35dc9f1
8 changes: 6 additions & 2 deletions packages/microservices/external/kafka.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,17 @@ type Authenticator = {
authenticate: () => Promise<void>;
};

export type SaslAuthenticateArgs<ParseResult> = {
request: SaslAuthenticationRequest;
response?: SaslAuthenticationResponse<ParseResult>;
};

type AuthenticationProviderArgs = {
host: string;
port: number;
logger: Logger;
saslAuthenticate: <ParseResult>(
request: SaslAuthenticationRequest,
response?: SaslAuthenticationResponse<ParseResult>,
args: SaslAuthenticateArgs<ParseResult>,
) => Promise<ParseResult | void>;
};

Expand Down