-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KafkaJS typing mismatch #13077
Closed
4 of 15 tasks
edeesis opened this issue
Jan 22, 2024
· 3 comments
· Fixed by Cabreira97/connect-tech-api-main#1, Cabreira97/connect-tech-api-main#3, johanbook/meet#766, johanbook/meet#767 or johanbook/meet#768
Closed
4 of 15 tasks
KafkaJS typing mismatch #13077
edeesis opened this issue
Jan 22, 2024
· 3 comments
· Fixed by Cabreira97/connect-tech-api-main#1, Cabreira97/connect-tech-api-main#3, johanbook/meet#766, johanbook/meet#767 or johanbook/meet#768
Labels
needs triage
This issue has not been looked into
Comments
peer dependency & strictLibCheck = true -> TS errors Would you like to create a PR with updated types? |
edeesis
added a commit
to edeesis/nest
that referenced
this issue
Jan 23, 2024
12 tasks
@kamilmysliwiec Done, thanks! |
kamilmysliwiec
added a commit
that referenced
this issue
Feb 7, 2024
fix: #13077 KafkaJs typing consistency
This was referenced Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current behavior
Minimum reproduction code
https://github.com/edeesis/kafkajs-nest
Steps to reproduce
Attempt to re-use the KafkaJS KafkaConfig typing in the Nest MicroserviceOptions. You'll get a typescript error as screenshotted above.
Expected behavior
Typings should match.
I'm also curious why there's a need for separate typings, rather than using the typings exported from kafkajs.
Package
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
Other package
No response
NestJS version
10.x
Packages versions
Change was done in kafkajs 2.2.1
Node.js version
20.x
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: