Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

build: Add a minimal configure.ac #9

Closed
wants to merge 2 commits into from
Closed

Conversation

orbea
Copy link

@orbea orbea commented Dec 13, 2023

When building with slibtool using the rlibtool symlink the build will fail when it fails to find the generated libtool. This is required so rlibtool can determine if it should build shared or static libraries.

This can be fixed by adding a minimal configure.ac that can generate the required files with autoreconf.

Gentoo Bug: https://bugs.gentoo.org/913482

When building with slibtool using the rlibtool symlink the build will
fail when it fails to find the generated libtool. This is required so
rlibtool can determine if it should build shared or static libraries.

This can be fixed by adding a minimal configure.ac that can generate the
required files with autoreconf.

Gentoo Bug: https://bugs.gentoo.org/913482
orbea added a commit to orbea/gentoo that referenced this pull request Dec 13, 2023
@clason
Copy link
Member

clason commented Dec 13, 2023

Thank you, but you should propose any such changes to the original maintainer. (Neovim no longer uses this fork.)

@orbea
Copy link
Author

orbea commented Dec 13, 2023

@clason Mind pointing me in the right direction? I was not sure where else to submit this.

@orbea
Copy link
Author

orbea commented Dec 13, 2023

The libtermkey site (https://www.leonerd.org.uk/code/libtermkey/) states:

DEPRECATED

Note: Use of this library for new programs is discouraged. It is being maintained for legacy purposes only. For writing new programs, please use libtickit instead.

All of the code in this library will be migrated into libtickit in due course; currently it is used via an internal dependency.

@gpanders
Copy link
Member

@orbea Indeed, which is why Neovim has chosen to vendor libtermkey. The author is very reluctant to make a new release. The long term plan is to integrate libtermkey's functionality into libtickit, at which point Neovim may choose to unvendor libtermkey in favor of using libtickit as a dependency.

In any case, as of Neovim 0.10 (the next release) libtermkey should not be seen as a dependency of Neovim by distributors/package maintainers. It is now functionally part of Neovim's own source code.

@clason clason closed this Dec 13, 2023
@orbea
Copy link
Author

orbea commented Dec 13, 2023

That is understandable, thank you for the prompt replies.

@clason
Copy link
Member

clason commented Dec 13, 2023

No worries, sorry for getting your hopes up. The intent was never to create a separate maintained fork for other downstream users. It's probably best to archive this repo sooner rather than later in order to prevent further misunderstandings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants